Sedeniono marked 6 inline comments as done. Sedeniono added inline comments.
================ Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector<AnalyzerPass, 16> Passes; ---------------- HazardyKnusperkeks wrote: > owenpan wrote: > > This comment is unnecessary and too verbose IMO. I suggest that it be > > deleted. > > This comment is unnecessary and too verbose IMO. I suggest that it be > > deleted. > > I think one should note that there are more passes added than directly meets > the eye here. After looking at the code again, I decided to remove the comment. I think the "structure" of the code below that adds the passes already highlights that there is something "special" going on with the qualifier alignment passes, since they aren't added via a lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
