dgoldman added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:787 + // names like class and protocol names. + if (const auto *CD = dyn_cast<ObjCContainerDecl>(&RenameDecl)) + if (CD->getName() != IdentifierToken->text(SM)) ---------------- kadircet wrote: > this special casing should no longer be needed if we just map CategoryDecls > to InterfaceDecls in `locateDeclAt` rather than at canonicalization time Yep, no longer needed since the `Check the rename-triggering location is actually being renamed` check catches this although the error is no symbol found instead of unsupported symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
