erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:2024
if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
+ if (D->isPlaceholderVar())
+ return !VD->hasInit();
----------------
Why would we get here? Doesn't line 1995 pick this up? Or am I missing where
D is modified?
ALSO, I'd suggest making this VD->isPlaceholderVar, as to not annoy the SA
tools.
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:725
+void Sema::NotePlaceholderVariableDefinition(SourceLocation Loc) {
+ Diag(Loc, getLangOpts().CPlusPlus26
----------------
Not a fan of this function name... Perhaps Diag instead of Note?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153536/new/
https://reviews.llvm.org/D153536
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
