hazohelet marked an inline comment as done.
hazohelet added inline comments.
================
Comment at: clang/lib/Sema/Sema.cpp:1385
+ Diag(DiagD->getLocation(), diag::warn_unused_template)
+ << /*variable*/ 1 << DiagD;
} else if (DiagD->getType().isConstQualified()) {
----------------
shafik wrote:
> Sorry for late review but we should conform to
> [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)
> for these.
Thanks. Fixed in 940c94e1c1b99511630b6f61890ac54161b5829c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152796/new/
https://reviews.llvm.org/D152796
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
