[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. This needs a lit test. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:92-97 + StringRef Linker = + Args.getLastArgValue(options::OPT_fuse_ld_EQ, CLANG_DEFAULT_LINKER); + if (Linker.empty() || Linker.equals_insensitive("lld")) +Linker = "lld-

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This will fix unused-include false positive. // primary.h namespace ns { template class Z {}; // primary templat

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 529201. goldstein.w.n added a comment. Add header comments/license. Use enum for kMaybe, kYes, kNo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 Files: clan

[PATCH] D143260: [clangd] Add semantic token for labels

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. alright then, this patch LGTM. going forward let's try to introduce new kinds (or handling for different semantic constructs) in a more holistic manner. concerns with new language structs

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/ https://reviews.llvm.org/D151594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 529207. vikramRH added a comment. Further review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Please update the title and the summary of this patch to reflect what it actually achieves. We also usually use the `[analyzer]` tag only for changes touching `StaticAnalyzer` stuff. Afte

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev added a comment. I think this is heading in a good direction. Please find some comments inline. Comment at: clang/docs/ClangRepl.rst:60 + +Clang-Repl-Usage + Comment at: clang/docs/ClangRepl.rst:6

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH marked 4 inline comments as done. vikramRH added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:137 + +__device__ float f1 = 3.14f; +__device__ double f2 = 2.71828; arsenm wrote: > Also half C++ default arg promotions does not

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:176 + void reportSpecializations(SourceLocation Loc, NamedDecl *ND) { +if (const auto *TD = dyn

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } nridge wrote: > zyounan wrote: > > `PrintCanonicalTypes` turns on p

[clang] 22e95e0 - [clang] Fix assertion while parsing an invalid for loop

Author: Corentin Jabot Date: 2023-06-07T10:31:11+02:00 New Revision: 22e95e0bf375660dd3d083b16a5d92c33559a4a3 URL: https://github.com/llvm/llvm-project/commit/22e95e0bf375660dd3d083b16a5d92c33559a4a3 DIFF: https://github.com/llvm/llvm-project/commit/22e95e0bf375660dd3d083b16a5d92c33559a4a3.diff

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG22e95e0bf375: [clang] Fix assertion while parsing an invalid for loop (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D152009?vs=529186&id=529212#toc Repository: rG LLVM Git

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei added a comment. In D152318#4402234 , @mstorsjo wrote: > FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. > While it does match a GNU binutils tool, I'm kinda curious where it is needed. llvm-strings exists in the `output

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

hokein updated this revision to Diff 529215. hokein marked 5 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152345/new/ https://reviews.llvm.org/D152345 Files: clang-tools-

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 529216. massberg added a comment. Fix status of paper in status page to unreleased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added a comment. thanks, mostly LG. some nits around comments and request for a knob :) Comment at: clang-tools-extra/clangd/ClangdServer.cpp:80 + +auto Task = [FIndex(FIndex), Path(Path.str()), Version(Version.str()), + ASTCtx(std::move(ASTCtx)), -

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG100ffbf991e7: [include-cleaner] Report all specializations if the primary template is… (authored by hokein). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 100ffbf - [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

Author: Haojian Wu Date: 2023-06-07T10:52:36+02:00 New Revision: 100ffbf991e78bb3e94a9d5c8d656a9b8648082d URL: https://github.com/llvm/llvm-project/commit/100ffbf991e78bb3e94a9d5c8d656a9b8648082d DIFF: https://github.com/llvm/llvm-project/commit/100ffbf991e78bb3e94a9d5c8d656a9b8648082d.diff LO

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; isuckatcs wrote: > Please cover this line with both positive an

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

mstorsjo added a comment. In D152318#4402493 , @haowei wrote: > In D152318#4402234 , @mstorsjo > wrote: > >> FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. >> While it does match a GNU

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, arsenm, kpn, qiucf, efriedma. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, wdng. Herald added projects: cl

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 529219. vikramRH marked an inline comment as done. vikramRH added a comment. updated formating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/docs/Re

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon updated this revision to Diff 529220. Fznamznon added a comment. Use 1-element UnresolvedSet, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D152305: [clang-format] Add the KeepEmptyLinesAtEOF option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152305/new/ https://reviews.llvm.org/D152305 ___ cfe-commits mailing li

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11988 - return getDerived().RebuildCXXOperatorCallExpr(E->getOperator(), - E->getOperatorLoc(), - Callee.g

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

MyDeveloperDay added a comment. In D151761#4400056 , @galenelias wrote: > In D151761#4394758 , > @MyDeveloperDay wrote: > >> did you consider a case where the case falls through? (i.e. no return) >> >> "case l

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

michaelplatings created this revision. michaelplatings added reviewers: phosek, simon_tatham. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Follow u

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a comment. In D148700#4401451 , @rsmith wrote: > In D148700#4401353 , @jyknight > wrote: > >> Yes, standard attributes aren't supposed to be used for things which affect >> the type system (al

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Flag must be a flag accepted by the driver. + MultilibBuilder &flag(bool Required, StringRef Flag); p

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

steakhal added a comment. I had some improvement opportunities in mind scattered, so I decided to do them, and here is how the diff looks for me now: F27853795: recommendation.patch Basically, I reworked the two branches a bit to express the intent more stra

[PATCH] D152285: Add support for the NO_COLOR environment variable

jhasse added a comment. There's a valid usecase `CLICOLOR_FORCE`: Force color diagnostics. The "disable colors" part of https://bixense.com/clicolors/ is not that important to me, I could change it to point to `NO_COLOR` instead? btw: I've tried to join the "standards" a few years ago: https:/

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:15216-15217 - if (Op == OO_Subscript) { -SourceLocation LBrace; -SourceLocation RBrace; - -if (DeclRefExpr *DRE = dyn_cast(Callee)) { - DeclarationNameLoc NameLoc = DRE->getNameInfo().

[PATCH] D152351: [clang] Add __builtin_isfpclass

qiucf added a comment. It's necessary to check range of first argument in `SemaChecking.cpp` using `SemaBuiltinConstantArgRange`. _Bool check_isfpclass_1(float x) { return __builtin_isfpclass(123456, x); } // ICE int g; // error: cannot compile this builtin function yet // there's be

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon updated this revision to Diff 529229. Fznamznon added a comment. Remove RequiresADL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTran

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 529231. massberg added a comment. Format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[clang-tools-extra] e72baa7 - [clangd] Add semantic token for labels

Author: Christian Kandeler Date: 2023-06-07T12:28:06+02:00 New Revision: e72baa76b91fbcb2b16747cb7d2088723478a754 URL: https://github.com/llvm/llvm-project/commit/e72baa76b91fbcb2b16747cb7d2088723478a754 DIFF: https://github.com/llvm/llvm-project/commit/e72baa76b91fbcb2b16747cb7d2088723478a754.

[PATCH] D143260: [clangd] Add semantic token for labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGe72baa76b91f: [clangd] Add semantic token for labels (authored by ckandeler). Changed prior to commit: https://reviews.llvm.org/D143260?vs=494583&id=529234#toc Repository: rG LLVM Github Monorepo CH

cfe-commits@lists.llvm.org

Author: Jens Massberg Date: 2023-06-07T12:56:35+02:00 New Revision: 593a2740f7a499e35f19e64d180d0b8246b52ba3 URL: https://github.com/llvm/llvm-project/commit/593a2740f7a499e35f19e64d180d0b8246b52ba3 DIFF: https://github.com/llvm/llvm-project/commit/593a2740f7a499e35f19e64d180d0b8246b52ba3.diff

cfe-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG593a2740f7a4: [clang] Show error if defaulted comparions operator function is volatile or has… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:15216-15217 - if (Op == OO_Subscript) { -SourceLocation LBrace; -SourceLocation RBrace; - -if (DeclRefExpr *DRE = dyn_cast(Callee)) { - DeclarationNameLoc NameLoc = DRE->getNameInfo().g

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff updated this revision to Diff 529243. sepavloff added a comment. Add check for test bit mask value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon updated this revision to Diff 529244. Fznamznon added a comment. Remove dead code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransf

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I think this looks good! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff added a comment. In D152351#4402615 , @qiucf wrote: > It's necessary to check range of first argument in `SemaChecking.cpp` using > `SemaBuiltinConstantArgRange`. > > _Bool check_isfpclass_1(float x) { return __builtin_isfpclass(123456, x); }

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added inline comments. Comment at: clang/test/CodeGen/isfpclass.c:1 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + Use generated checks? Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %cla

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added a comment. Also should get mentioned in the builtin docs and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 ___ cfe-commits mailing

[PATCH] D152002: [clang][wip] Better handling of dependent lambda. This is an attempt to fix GH62916. However, it breaks GH57960 I seem unable to find something that works for both issues.

cor3ntin abandoned this revision. cor3ntin added a subscriber: Eric. cor3ntin added a comment. @eric suggested we should not try to transform the body of the lambda at all, which may be a better approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGcda46cc4f921: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable &… (authored by agozillon). Changed prior to commit: https://reviews.llvm.org/D149162?vs=524279&id=529258#toc Repository: rG

[clang] cda46cc - [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

Author: Andrew Gozillon Date: 2023-06-07T07:02:25-05:00 New Revision: cda46cc4f921f6b288c57a68b901ec2f57134606 URL: https://github.com/llvm/llvm-project/commit/cda46cc4f921f6b288c57a68b901ec2f57134606 DIFF: https://github.com/llvm/llvm-project/commit/cda46cc4f921f6b288c57a68b901ec2f57134606.dif

[clang] f10b1c5 - [Clang][OpenMP] Fix -Wcovered-switch-default in CGOpenMPRuntime.cpp (NFC)

Author: Jie Fu Date: 2023-06-07T20:23:48+08:00 New Revision: f10b1c5f3cbef76b189566332eebabd017296655 URL: https://github.com/llvm/llvm-project/commit/f10b1c5f3cbef76b189566332eebabd017296655 DIFF: https://github.com/llvm/llvm-project/commit/f10b1c5f3cbef76b189566332eebabd017296655.diff LOG: [

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. Any advice how I should proceed here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

aaron.ballman added a comment. In D148700#4401451 , @rsmith wrote: > In D148700#4401353 , @jyknight > wrote: > >> Yes, standard attributes aren't supposed to be used for things which affect >> the type system (a

[PATCH] D152207: [HIP] Instruct lld to go through all archives

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 __

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 529269. michaelplatings added a comment. @phosek thanks for your suggestion, that's now implemented. In practise for LLVM Embedded Toolchain for Arm we haven't yet needed `NoMatchFlags` so I've removed that feature. Repository: rG LLVM Github Mon

[PATCH] D152312: HIP: Use frexp builtins in math headers

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152312/new/ https://reviews.llvm.org/D152312 ___ cfe-commits mailing list cfe-

[PATCH] D138396: HIP: Directly call signbit builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138396/new/ https://reviews.llvm.org/D138396 ___ cfe-commits mailing list cfe-

[PATCH] D138399: HIP: Directly call isinf builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138399/new/ https://reviews.llvm.org/D138399 ___ cfe-commits mailing list cfe-c

[PATCH] D138395: HIP: Directly call fmin/fmax builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138395/new/ https://reviews.llvm.org/D138395 ___ cfe-commits mailing list cfe-

[PATCH] D152285: Add support for the NO_COLOR environment variable

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D152285#4401348 , @MaskRay wrote: > If we don't intend to support both standards, we can close > https://github.com/llvm/llvm-project/issues/23983 (CLICOLOR) as a wontfix :

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:35 +// INTERNALIZE: attributes #[[ATTR]] = {{.*}} "target-cpu"="gfx{{.*}}" "target-features"="+gfx11-insts" +// NOINTERNALIZE: at

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/Address.h:135 llvm::Constant *BitCast = llvm::ConstantExpr::getBitCast( -getPointer(), ElemTy->getPointerTo(getAddressSpace())); +getPointer(), llvm::PointerType::get(ElemTy, getAddressSpace()));

[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin added a comment. As I told Aaron, someone who disables color for accessibility reason is likely to have both variables(NO_COLOR/CLICOLOR) set. So supporting one is enough. Picking the one that is the simplest and most popular makes perfect sense. This is great. Repository: rG LLVM G

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg updated this revision to Diff 529277. massberg added a comment. Use correct format for burprone-argument-comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https://reviews.llvm.org/D139541 Files: clang/include/clang/Sema

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added a comment. @nikic Did you have a look at the new patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 __

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on the ongoing migration to strict

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. Could always go with `-gsuppress-undefined-methods` if you're not happy about default-on options. I don't have a strong opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4480 MaximumAlignment = std::min(MaximumAlignment, uint64_t(8192)); - if (AlignVal > MaximumAlignment) { + bool TooManyActiveBits = Alignment.getActiveBits() > llvm::APInt(64, MaximumAlignment).

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. In D150446#4337657 , @donat.nagy wrote: > After some thinking and discussion with @gamesh411 I decided that it'd be > better to replace

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4484 + if (!TooManyActiveBits) { +AlignVal = Alignment.getZExtValue(); +// C++11 [dcl.align]p2: So looking more closely, THIS is the problem right here. I think we probably s

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 529283. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && + LHSBuiltinTy && RHSBuiltinTy && Context.getBuiltinVectorTypeInfo(LHSBuiltinTy).EC != I think this

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

Pierre-vh marked 2 inline comments as done. Pierre-vh added inline comments. Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:34 +// CHECK: define {{.*}} i32 @do_intrin_stuff() #[[ATTR:[0-9]+]] +// CHECK: attributes #[[ATTR]] = {{.*}} "target-featur

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Pierre-vh marked an inline comment as done. Closed by commit rG23431b524603: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking (authored by

[clang] 23431b5 - [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

Author: pvanhout Date: 2023-06-07T15:51:52+02:00 New Revision: 23431b52460328c554ad244fd7b50ecb751cec31 URL: https://github.com/llvm/llvm-project/commit/23431b52460328c554ad244fd7b50ecb751cec31 DIFF: https://github.com/llvm/llvm-project/commit/23431b52460328c554ad244fd7b50ecb751cec31.diff LOG:

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 529287. Krishna-13-cyber added a comment. - Update with addressing the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://reviews.llvm.org/D152109 Files: clang/docs/ClangRep

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

compnerd added a comment. In D152051#4392612 , @tstellar wrote: > I was not sure what to do with inline functions and also functions that were > implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY > macro to most of those functions

[clang] e60b30d - Reland "D144999 [MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs."

Author: Vy Nguyen Date: 2023-06-07T10:03:50-04:00 New Revision: e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc URL: https://github.com/llvm/llvm-project/commit/e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc DIFF: https://github.com/llvm/llvm-project/commit/e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc.diff LOG

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. > ! In D152051#4403167 , @compnerd > wrote: > Please do not use LLVM_EXTERNAL_VISIBILITY but rather introduce a new macro > (this will prevent the use on Windows). OK, so should I create a clang specific macro for this? And s

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg updated this revision to Diff 529293. massberg added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https://reviews.llvm.org/D139541 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaLambd

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM with a minor nit. Thanks for the optimization! Comment at: clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.cpp:124 +if (ND0->getAcc

[clang] 4418434 - [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

Author: Kristina Bessonova Date: 2023-06-07T16:43:12+02:00 New Revision: 4418434c6de7a861e241ba2448ea4a12080cf08f URL: https://github.com/llvm/llvm-project/commit/4418434c6de7a861e241ba2448ea4a12080cf08f DIFF: https://github.com/llvm/llvm-project/commit/4418434c6de7a861e241ba2448ea4a12080cf08f.

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4418434c6de7: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7) (authored by krisb, committed by dzhidzhoev). Reposito

[PATCH] D99201: [HIP] Diagnose unaligned atomic for amdgpu

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7215 +// warnings as errors. +CmdArgs.push_back("-Werror=atomic-alignment"); } tra wrote: > Should it be done from `HIPAMDToolChain

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC added a comment. In D152269#4402593 , @steakhal wrote: > I had some improvement opportunities in mind scattered, so I decided to do > them, and here is how the diff looks for me now: F27853795: > recommendation.patch

[PATCH] D99201: [AMDGPU] Diagnose unaligned atomic for amdgpu

yaxunl updated this revision to Diff 529301. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[HIP] Diagnose unaligned atomic for amdgpu" to "[AMDGPU] Diagnose unaligned atomic for amdgpu". yaxunl added a comment. Herald added a reviewer: jdoerfert. Herald added subscri

[PATCH] D152285: Add support for the NO_COLOR environment variable

aaron.ballman updated this revision to Diff 529299. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Update based on review feedback so that we check for an empty environment variable value. This was a fun rabbit hole to fall into: lit is not a PTY, so our fallback

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356 // Region 00 +// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64 +// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}}, // CK2: br i1

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

cor3ntin added a comment. In D146924#4224237 , @tahonermann wrote: >> It's not in the range of any of the universal-character-names. > > I assume you mean that it isn't included in the range of UCNs that are > allowed in identifiers. If so, that is corr

[clang] 2878282 - [clang][DeclPrinter] Fix AST print of out-of-line record definitions

Author: Timo Stripf Date: 2023-06-07T10:57:31-04:00 New Revision: 2878282dc550e6a8174917480a2dc22bbe283ed1 URL: https://github.com/llvm/llvm-project/commit/2878282dc550e6a8174917480a2dc22bbe283ed1 DIFF: https://github.com/llvm/llvm-project/commit/2878282dc550e6a8174917480a2dc22bbe283ed1.diff L

[PATCH] D151528: [clang][DeclPrinter] Fix AST print of out-of-line record definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2878282dc550: [clang][DeclPrinter] Fix AST print of out-of-line record definitions (authored by strimo378, committed by aaron.ballman). Repository:

[PATCH] D152285: Add support for the NO_COLOR environment variable

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Glad that my comment on https://github.com/llvm/llvm-project/issues/23983 might bring attention to users. I'd like to make my stance softer: if we find `CLICOLOR_FORCE` useful, we can

  1   2   3   >