yaxunl accepted this revision.
yaxunl added a comment.

LGTM. Thanks



================
Comment at: 
clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:35
+// INTERNALIZE: attributes #[[ATTR]] = {{.*}} "target-cpu"="gfx{{.*}}" 
"target-features"="+gfx11-insts"
+// NOINTERNALIZE: attributes #[[ATTR]] = {{.*}} 
"target-features"="+gfx11-insts"
+
----------------
Do we know why internalize keeps the target-cpu attribute but non-internalize 
does not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152251/new/

https://reviews.llvm.org/D152251

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to