compnerd added a comment. In D152051#4392612 <https://reviews.llvm.org/D152051#4392612>, @tstellar wrote:
> I was not sure what to do with inline functions and also functions that were > implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY > macro to most of those functions. I think that inline functions should have the attribute applied as well. That should be the equivalent of `-fvisibility-inlines-hidden` and should allow this to be useable for windows as well. Please do not use LLVM_EXTERNAL_VISIBILITY but rather introduce a new macro (this will prevent the use on Windows). I did write a tool to help with this: https://GitHub.com/compnerd/ids Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152051/new/ https://reviews.llvm.org/D152051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
