[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4351147 , @nikic wrote: > Lowering to a rotate intrinsic only "solves" this for wasm and will at the > same time make these rotates completely opaque to optimization -- heck, it > looks like we don't even support const

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

craig.topper added a comment. > Preventing the simplification means adding target specific code in > instcombine which seems even worse than adding it here given as @dschuff > pointed out, there's precedent with x86. How harmful is it to avoid breaking rotate patterns even if the target doesn't

[clang] f0303bd - [gcov] Make .gcno/.gcda paths absolute

Author: Fangrui Song Date: 2023-05-18T00:27:10-07:00 New Revision: f0303bd67d32b41d6502d2ff5fa825a9d21acf96 URL: https://github.com/llvm/llvm-project/commit/f0303bd67d32b41d6502d2ff5fa825a9d21acf96 DIFF: https://github.com/llvm/llvm-project/commit/f0303bd67d32b41d6502d2ff5fa825a9d21acf96.diff

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 lines breaks in inline asm

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. Previously, using ColumnLimit: 0 with extend

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2490-2523 +**List of checked functions** + +``fgetc``, ``fread``, ``fwrite``, ``getc``, ``getchar``, ``getdelim``, +``getenv``, ``getline``, ``isalnum``, ``isalpha``, ``isascii``, ``isblank``, +``isdigit

[clang] fc89e90 - [C++20] [Modules] Emit an warning for experimental header units

Author: Chuanqi Xu Date: 2023-05-18T16:12:41+08:00 New Revision: fc89e9044d0b37dcd4e3f085f21bef1b21d2ab8d URL: https://github.com/llvm/llvm-project/commit/fc89e9044d0b37dcd4e3f085f21bef1b21d2ab8d DIFF: https://github.com/llvm/llvm-project/commit/fc89e9044d0b37dcd4e3f085f21bef1b21d2ab8d.diff LO

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic added a comment. In D150670#4352055 , @pmatos wrote: > In D150670#4351147 , @nikic wrote: > >> This doesn't looks like a wasm specific problem. You get essentially the >> same issue on any target that has a

[clang] e8cd046 - [AST] Initialize local counter

Author: Vitaly Buka Date: 2023-05-18T01:19:11-07:00 New Revision: e8cd04624e503ae063e925eb5609281a88716d83 URL: https://github.com/llvm/llvm-project/commit/e8cd04624e503ae063e925eb5609281a88716d83 DIFF: https://github.com/llvm/llvm-project/commit/e8cd04624e503ae063e925eb5609281a88716d83.diff L

[PATCH] D150492: [AST] Initialize local counter

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8cd04624e50: [AST] Initialize local counter (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D150492?vs=521819&id=523292#toc Repository: rG LLVM Github Monorepo CHANGES S

[clang] b96d063 - [NFC][AST] Align one line

Author: Vitaly Buka Date: 2023-05-18T01:19:48-07:00 New Revision: b96d0635f0c65de2fbbcf67fac7e70f9cce35171 URL: https://github.com/llvm/llvm-project/commit/b96d0635f0c65de2fbbcf67fac7e70f9cce35171 DIFF: https://github.com/llvm/llvm-project/commit/b96d0635f0c65de2fbbcf67fac7e70f9cce35171.diff L

[clang] 11fe931 - [AST] Initialized AutoTypeLocInfo::FoundDecl

Author: Vitaly Buka Date: 2023-05-18T01:21:29-07:00 New Revision: 11fe9310b9146ee7dfd7cf01662e8fc0a7cd508c URL: https://github.com/llvm/llvm-project/commit/11fe9310b9146ee7dfd7cf01662e8fc0a7cd508c DIFF: https://github.com/llvm/llvm-project/commit/11fe9310b9146ee7dfd7cf01662e8fc0a7cd508c.diff L

[clang] 9e270c6 - [test][clang-repl] Disable test incompatible with msan

Author: Vitaly Buka Date: 2023-05-18T01:24:03-07:00 New Revision: 9e270c64a7319929da2b92920a91136fd9e2df43 URL: https://github.com/llvm/llvm-project/commit/9e270c64a7319929da2b92920a91136fd9e2df43 DIFF: https://github.com/llvm/llvm-project/commit/9e270c64a7319929da2b92920a91136fd9e2df43.diff L

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4351614 , @MaskRay wrote: > In D150549#4349531 , @jobnoorman > wrote: > >> In D150549#4347056 , @MaskRay >> wrote: >> >>> This see

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

michaelplatings added inline comments. Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() The [[ https://cmake.org/cmake/help/latest/variable/CMAKE_TOOLCHAIN_FILE.html | documentation

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1 MaskRay wrote: > peter.smit

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4400ff587be2: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC) (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 4400ff5 - [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

Author: Balázs Kéri Date: 2023-05-18T11:25:09+02:00 New Revision: 4400ff587be2d0baff5067f3fa210f9c34af2737 URL: https://github.com/llvm/llvm-project/commit/4400ff587be2d0baff5067f3fa210f9c34af2737 DIFF: https://github.com/llvm/llvm-project/commit/4400ff587be2d0baff5067f3fa210f9c34af2737.diff L

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 523303. TIFitis added a comment. Done migrating from Clang. This makes use of the clang functions now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/i

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523304. TIFitis edited the summary of this revision. TIFitis added a comment. Small fix to code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llv

[PATCH] D150087: [Clang] Support more stdio builtins

qiucf updated this revision to Diff 523305. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150087/new/ https://reviews.llvm.org/D150087 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuil

[PATCH] D150087: [Clang] Support more stdio builtins

qiucf marked an inline comment as done. qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:109 + {Builtin::BI__builtin___vsnprintf_chk, "__vsnprintfieee128"}, + {Builtin::BI__builtin___vsprintf_chk, "__vsprintfieee128"}, + {Builtin::BI__builti

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523316. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Frontend

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523318. TIFitis added a comment. Fix lint messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/li

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added reviewers: qiucf, lkail, shchenz. ManuelJBrito added a comment. Adding some PowerPC folks to review the change in codegen for vec_promote. AFAICT its OK to have the undefined values be poison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 523323. eopXD marked an inline comment as done. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCV

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523331. TIFitis added a comment. Try to fix patch application. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, dpalermo, kiranktp, jdoerfert. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sste

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 523340. TIFitis added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/

[PATCH] D150863: [CLANG][AArch64][SVE2.1] Add UCLAMP/SCLAMP/FCLAMP function prototypes

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Submitting this patch in the name of:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:67-68 - // CK1-DAG: call void @__tgt_target_data_end_mapper(ptr @{{.+}}, i64 [[DEV:%[^,]+]], i32 1, ptr [[GEPBP:%.+]], ptr [[GEPP:%.+]], ptr [[SIZE00]], ptr [[MTYPE00]], ptr null, ptr null) -

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 523344. vikramRH added a comment. Hanldles Review comments from @sameerds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/include/clang/Basic/TargetOp

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:426-427 + +// The buffered version still follows OpenCL printf standards for +// printf return value, i.e 0 on success, 1 on failure. +ConstantPointerNull *zeroIntPtr =

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:458 +auto CreateControlDWord = M->getOrInsertFunction( +StringRef("__ockl_create_control_dword"), Builder.getInt32Ty(), +Builder.getInt32Ty(), Int1Ty, Int1Ty); -

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

thakis added a comment. Is it possible to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146664/new/ https://reviews.llvm.org/D146664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D150867: [AArch64][FMV] Prevent target attribute using for multiversioning.

ilinpv created this revision. ilinpv added a reviewer: danielkiss. Herald added a subscriber: kristof.beyls. Herald added a project: All. ilinpv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AArch64 for function multiversioning target_

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523354. oontvoo added a comment. rebase again (windows failures in flang tests looked unrelated) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/includ

[PATCH] D150829: [clang] Convert several tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp:22 +// CHECK: store i32 0, ptr @arr +// CHECK: call void @_ZN1AC1EPKc(ptr {{[^,]*}} getelementptr inbounds

[clang] 34e49d3 - Revert "[clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables"

Author: Erich Keane Date: 2023-05-18T06:44:39-07:00 New Revision: 34e49d3e85a6dd03856af0fb4b7f8d8ae1f4f06a URL: https://github.com/llvm/llvm-project/commit/34e49d3e85a6dd03856af0fb4b7f8d8ae1f4f06a DIFF: https://github.com/llvm/llvm-project/commit/34e49d3e85a6dd03856af0fb4b7f8d8ae1f4f06a.diff L

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

erichkeane added a comment. In D146358#4351787 , @hazohelet wrote: > In D146358#4350810 , @erichkeane > wrote: > >> Our downstream discovered that this causes a regression when compiling >> `utility` with `ast-d

[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

JMazurkiewicz updated this revision to Diff 523360. JMazurkiewicz marked 2 inline comments as done. JMazurkiewicz added a comment. - Address comments (thanks for the review @aaron.ballman!), - Remove `clang-format` changes (CI might fail), - Add extra tests in `clang/test/Preprocessor/feature_test

[clang] 0bf5f63 - [clang] Convert several tests to opaque pointers

Author: Sergei Barannikov Date: 2023-05-18T17:01:11+03:00 New Revision: 0bf5f632ed53cb8c986d69168589228014522e1b URL: https://github.com/llvm/llvm-project/commit/0bf5f632ed53cb8c986d69168589228014522e1b DIFF: https://github.com/llvm/llvm-project/commit/0bf5f632ed53cb8c986d69168589228014522e1b.d

[PATCH] D150829: [clang] Convert several tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf5f632ed53: [clang] Convert several tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150829/new/ https:/

[clang] 8e82376 - [clang][RISCV] Set HasLegalHalfType to true if zhinx is enabled

Author: Alex Bradbury Date: 2023-05-18T15:01:48+01:00 New Revision: 8e82376863460f6dc2dbb7fe6754af3ba69cc9c4 URL: https://github.com/llvm/llvm-project/commit/8e82376863460f6dc2dbb7fe6754af3ba69cc9c4 DIFF: https://github.com/llvm/llvm-project/commit/8e82376863460f6dc2dbb7fe6754af3ba69cc9c4.diff

[PATCH] D150777: [clang][RISCV] Set HasLegalHalfType to true if zhinx is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e8237686346: [clang][RISCV] Set HasLegalHalfType to true if zhinx is enabled (authored by asb). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523376. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.

[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming precommit CI doesn't come back with surprises, though there are some minor typos in the release notes to be fixed. Do you need someone to commit on your behalf? If

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

ymandel created this revision. ymandel added a reviewer: sammccall. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Google style is ch

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1790 SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder &operator=(const SemaDiagnosticBuilder &) = delete; ~SemaDiagnosticBuilder(); tahone

[PATCH] D150833: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD

This revision was automatically updated to reflect the committed changes. Closed by commit rGc672c3fe05ad: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150833/new/

[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

JMazurkiewicz added a comment. > Do you need someone to commit on your behalf? If so, what name and email > address would you like used for patch attribution? Yes, my name and email: "Jakub Mazurkiewicz ". > I can fix up the release notes when I land, so you don't have to upload a new > patch.

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane created this revision. erichkeane added reviewers: clang-vendors, clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Clang 16 changed to consider dereferencing a void* to be a warning-as-error, plus made this an error in SFINAE contexts, since

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked an inline comment as done. rsundahl added inline comments. Comment at: compiler-rt/docs/ASanABI.rst:29 + + Following are some examples of reasonable responses to such changes: + MaskRay wrote: > How does the 2-space indentation render in the buil

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523396. Manna added a comment. Fix clang-format issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang

[clang] 153d9b9 - Remove unreferenced files from Clang's website

Author: Aaron Ballman Date: 2023-05-18T11:53:27-04:00 New Revision: 153d9b9371c3adf719cad4307e395692caa752ac URL: https://github.com/llvm/llvm-project/commit/153d9b9371c3adf719cad4307e395692caa752ac DIFF: https://github.com/llvm/llvm-project/commit/153d9b9371c3adf719cad4307e395692caa752ac.diff

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523400. AlexVlx added a comment. Reworked in accordance with review comments, correcting the embedded assumption about VTT being always in the generic AS. This ended up being slightly noisier than anticipated since functionality is spread out. CHANGES SINC

[clang] fbd8f89 - Ensure comparison of constraints creates a code synth context

Author: Erich Keane Date: 2023-05-18T09:07:42-07:00 New Revision: fbd8f8985e36581487371e9ff4ac7d99655b51e7 URL: https://github.com/llvm/llvm-project/commit/fbd8f8985e36581487371e9ff4ac7d99655b51e7 DIFF: https://github.com/llvm/llvm-project/commit/fbd8f8985e36581487371e9ff4ac7d99655b51e7.diff L

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

cor3ntin added a comment. This generally looks good to me but i have a couple remarks Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

shafik added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; @tahonermann I feel like we should have a default member initializer for any member that by default is

[clang] fa0a391 - [RISCV] Fix assertion when casting LMUL!=1 RVV types to GNU types with -mrvv-vector-bits.

Author: Craig Topper Date: 2023-05-18T09:21:38-07:00 New Revision: fa0a39113a28448529f62d3ea30a7b7a8066f231 URL: https://github.com/llvm/llvm-project/commit/fa0a39113a28448529f62d3ea30a7b7a8066f231 DIFF: https://github.com/llvm/llvm-project/commit/fa0a39113a28448529f62d3ea30a7b7a8066f231.diff

[clang] 0e85260 - Removed outdated information from Clang's webpage menu

Author: Aaron Ballman Date: 2023-05-18T12:23:29-04:00 New Revision: 0e85260db1cfd4e8688d917a09a212c2d9a343f3 URL: https://github.com/llvm/llvm-project/commit/0e85260db1cfd4e8688d917a09a212c2d9a343f3 DIFF: https://github.com/llvm/llvm-project/commit/0e85260db1cfd4e8688d917a09a212c2d9a343f3.diff

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

rupprecht added a comment. I found one use here: https://github.com/ericniebler/range-v3/blob/48dc2eb666c07e6afc8ec5edf7db9a5c6cde7a56/include/range/v3/functional/invoke.hpp#L51 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150875/new/ https://reviews.llvm.org/D150875

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150875/new/ https://reviews.llvm.org/D150875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 523409. rsundahl added a comment. Implement suggestions from latest review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang/include/clang/Driver/Optio

[clang] d02d054 - Clean up Clang's index page slightly

Author: Aaron Ballman Date: 2023-05-18T12:37:53-04:00 New Revision: d02d054473834091ce662073654c947b0551d61d URL: https://github.com/llvm/llvm-project/commit/d02d054473834091ce662073654c947b0551d61d DIFF: https://github.com/llvm/llvm-project/commit/d02d054473834091ce662073654c947b0551d61d.diff

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/google/TodoCommentCheck.cpp:97 : ClangTidyCheck(Name, Context), + UseV2Style(Options.getLocalOrGlobal("UseV2Style", false)), Handler(std::make_unique( Given this check is pa

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

rnk added a comment. Can you expand on the motivation for removing this extension? This doesn't seem to save a lot of code complexity, and it increases migration costs for our users. I'd like to have some motivation for putting them through the trouble of migrating. CHANGES SINCE LAST ACTION

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. In D150875#4353209 , @rupprecht wrote: > I found one use here: > https://github.com/ericniebler/range-v3/blob/48dc2eb666c07e6afc8ec5edf7db9a5c6cde7a56/include/range/v3/functional/invoke.hpp#L51 Huh, that is an interesting use

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. In D150875#4353358 , @rnk wrote: > Can you expand on the motivation for removing this extension? This doesn't > seem to save a lot of code complexity, and it increases migration costs for > our users. I'd like to have some mo

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

aaron.ballman added a comment. In D150875#4353358 , @rnk wrote: > Can you expand on the motivation for removing this extension? This doesn't > seem to save a lot of code complexity, and it increases migration costs for > our users. I'd like to have some

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

shafik added a comment. I think it mostly makes sense but I want Aaron to also look at it. Comment at: clang/lib/AST/Interp/Pointer.cpp:10 #include "Pointer.h" +#include "Boolean.h" +#include "Context.h" Are all these headers really needed for the change below

[PATCH] D150645: [Driver] Support multi /guard: options

aeubanks added a comment. if you add a test for the repro, relanding lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 ___ cfe-commits mailing list cfe-commi

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

tra updated this revision to Diff 523426. tra added a comment. Actually connected the Sema check for the optional argument, and added a test to cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150820/new/ https://reviews.llvm.org/D150820 F

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

tra updated this revision to Diff 523428. tra added a comment. Cosmetic test cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150820/new/ https://reviews.llvm.org/D150820 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/include/c

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

rnk added a comment. In D150875#4353398 , @aaron.ballman wrote: > Note, there was an RFC: > https://discourse.llvm.org/t/rfc-can-we-stop-the-extension-to-allow-dereferencing-void-in-c/65708 Thanks, that addresses my concern. Please link to it from the

[PATCH] D149716: clang: Use new frexp intrinsic for builtins and add f16 version

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149716/new/ https://reviews.llvm.org/D149716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3f43abc - [RISCV] Reduce dependency on RISCV::RVVBitsPerBlock for calculating vector size for -mrvv-vector-bits.

Author: Craig Topper Date: 2023-05-18T10:09:50-07:00 New Revision: 3f43abc9e78cce99741f7c8cf54552c95cc98d9f URL: https://github.com/llvm/llvm-project/commit/3f43abc9e78cce99741f7c8cf54552c95cc98d9f DIFF: https://github.com/llvm/llvm-project/commit/3f43abc9e78cce99741f7c8cf54552c95cc98d9f.diff

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. In D150875#4353435 , @rnk wrote: > In D150875#4353398 , @aaron.ballman > wrote: > >> Note, there was an RFC: >> https://discourse.llvm.org/t/rfc-can-we-stop-the-extension-to-allow-der

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

jrtc27 added a comment. We heavily rely on this extension in CheriBSD via `__typeof__((*(p))) * __capability` as we want to be able to take any pointer, including to an array or function that needs to undergo decay to be an actual pointer, and turn it into a `__capability`-qualified one. Presum

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. In D150875#4353467 , @jrtc27 wrote: > We heavily rely on this extension in CheriBSD via `__typeof__((*(p))) * > __capability` as we want to be able to take any pointer, including to an > array or function that needs to underg

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

jrtc27 added a comment. In D150875#4353484 , @erichkeane wrote: > In D150875#4353467 , @jrtc27 wrote: > >> We heavily rely on this extension in CheriBSD via `__typeof__((*(p))) * >> __capability` as we want to b

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

craig.topper accepted this revision. craig.topper added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCall.cpp:3135 STy->getNumElements() > 1) { -uint64_t SrcSize = CGM.getDataLayout().getTypeAllocSize(STy); -

[clang] 09aaf53 - [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Author: Vy Nguyen Date: 2023-05-18T13:27:47-04:00 New Revision: 09aaf53a05e3786eea374f3ce57574225036412d URL: https://github.com/llvm/llvm-project/commit/09aaf53a05e3786eea374f3ce57574225036412d DIFF: https://github.com/llvm/llvm-project/commit/09aaf53a05e3786eea374f3ce57574225036412d.diff LOG

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG09aaf53a05e3: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

rsmith added a comment. In D150875#4353384 , @erichkeane wrote: > We are the only of the major compilers with this "extension" (I hesitate to > call it that, as I'm not sure this FITS in the 'extension's permitted by > standard) I'm not objecting to r

[PATCH] D150473: [clang/Driver] Also consider `gnu++` standard when checking for modules support

akyrtzi added a comment. Ping 🙏 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150473/new/ https://reviews.llvm.org/D150473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

ymandel updated this revision to Diff 523440. ymandel added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150872/new/ https://reviews.llvm.org/D150872 Files: clang-tools-extra/clang-tidy/google/TodoCommentCh

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

ymandel marked 3 inline comments as done. ymandel added a comment. Thank you for the very fast review! Comment at: clang-tools-extra/clang-tidy/google/TodoCommentCheck.cpp:97 : ClangTidyCheck(Name, Context), + UseV2Style(Options.getLocalOrGlobal("UseV2Style", false)),

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. In D150875#4353535 , @rsmith wrote: > In D150875#4353384 , @erichkeane > wrote: > >> We are the only of the major compilers with this "extension" (I hesitate to >> call it that, as

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1528 + + unsigned Offset = IsMasked ? 1 : 0; + llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr; I don't think we need the `Value *` variables here. They're

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3135 STy->getNumElements() > 1) { -uint64_t SrcSize = CGM.getDataLayout().getTypeAllocSize(STy); -llvm::Type *DstTy = Ptr.getElementType(); -uint64_t DstSize = CGM.getDataLayo

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 523446. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/inclu

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1575 + unsigned Offset = IsMasked ? 1 : 0; + llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr; + llvm::Value *PtrOperand = Ops[Offset]; Similar comment

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1635 + Operands.push_back(PtrOperand); + if (MaskOperand) +Operands.push_back(MaskOperand); Same comment as previous patch Repository: rG LLVM Github M

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1693 + unsigned Offset = IsMasked ? 1 : 0; + llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr; + llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0]; S

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:2178-2182 +// When parsing an identifier after an arrow +// it may be a member expression, in which case we +// should not annotate it as an independant expression +// so we just lookup that name,

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148665/new/ https://reviews.llvm.org/D148665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150817/new/ https://reviews.llvm.org/D150817 ___ cfe-c

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. Ok, so I was curious why this was an extension. This is the original patch: https://github.com/llvm/llvm-project/commit/80877c228d019e9cdca6295f3197867cc86e1720 where @rsmith mentions there is no good reason for this limitation, then mentions a core issue having bee

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Please also mark resolved comments as done, otherwise reviewers can presume that some comments are unresolved and don't necessarily give another round of reviews. Comment at: clang/test/Driver/print-supported-extensions.c:6 +// RUN: %clang --target=ri

  1   2   3   >