shafik added inline comments.

================
Comment at: clang/include/clang/Parse/Parser.h:1190
   class ParseScopeFlags {
     Scope *CurScope;
+    unsigned OldFlags = 0;
----------------
@tahonermann I feel like we should have a default member initializer for any 
member that by default is not initialized. I realize in this case there 
currently should be no way for this to be bot initialized but that may not stay 
true and I don't believe there will be a penalty for doing this since it is 
initialized in the `mem-initializer-list` and therefore the default init should 
be omitted when calling the constructor. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150744/new/

https://reviews.llvm.org/D150744

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to