ymandel marked 3 inline comments as done.
ymandel added a comment.

Thank you for the very fast review!



================
Comment at: clang-tools-extra/clang-tidy/google/TodoCommentCheck.cpp:97
     : ClangTidyCheck(Name, Context),
+      UseV2Style(Options.getLocalOrGlobal("UseV2Style", false)),
       Handler(std::make_unique<TodoCommentHandler>(
----------------
njames93 wrote:
> Given this check is part of the google module, doesn't it make sense to have 
> the default as what google now recommends.
The style guide hasn't been updated yet. Once that happens, I think we should 
switch the default. I can add a FIXME -- what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150872/new/

https://reviews.llvm.org/D150872

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to