qiucf marked an inline comment as done.
qiucf added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:109
+      {Builtin::BI__builtin___vsnprintf_chk, "__vsnprintfieee128"},
+      {Builtin::BI__builtin___vsprintf_chk, "__vsprintfieee128"},
+      {Builtin::BI__builtin_fprintf, "__fprintfieee128"},
----------------
tuliom wrote:
> Any reasons to not map these built-ins to their respective `_chkieee128` 
> counterparts? e.g. `__fprintf_chkieee128`.
Updated.

I just saw GCC in some cases emits no-chk version when calling 
`__builtin_*printf_chk`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150087/new/

https://reviews.llvm.org/D150087

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D... Qiu Chaofan via Phabricator via cfe-commits
    • [PAT... Timm Bäder via Phabricator via cfe-commits
    • [PAT... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
    • [PAT... Qiu Chaofan via Phabricator via cfe-commits
    • [PAT... Qiu Chaofan via Phabricator via cfe-commits
    • [PAT... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
    • [PAT... Qiu Chaofan via Phabricator via cfe-commits

Reply via email to