[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477398. anderslanglands added a comment. Remove whitespace changes on unaffected lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138377/new/ https://reviews.llvm.org/D138377 Files: clang/docs/Rel

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477399. anderslanglands added a comment. couple of little spaces I missed... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138377/new/ https://reviews.llvm.org/D138377 Files: clang/docs/ReleaseNotes.

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer created this revision. cpsauer added reviewers: nridge, sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. cpsauer requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. In D134859#3945709 , @sepavloff wrote: > In D134859#3943926 , @tbaeder wrote: > >> FYI, I noticed the way the floating values are serialized doesn't work if >> the `APFloat` heap-allocate

[PATCH] D138547: [X86][AMX] Fix typo of the headerfile.

LuoYuanke created this revision. Herald added a project: All. LuoYuanke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138547 Files: clang/lib/Headers/amxfp16intrin.h In

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

nridge added a comment. In D137770#3945095 , @spartacoos wrote: > I realised this is an active issue that's not being worked on. So, I want to > put myself forward to help implement this new module system for clangd once > you have settled on a design/

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; tbaeder wrote: > tahonerma

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kito-cheng updated this revision to Diff 477406. kito-cheng added a comment. Changes: - Add comment for RVVTypeCache - computeRVVTypeHashValue become a local function rather than static function of RVVTypeCache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kito-cheng marked 3 inline comments as done. kito-cheng added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:284 + +class RVVTypeCache { +private: khchen wrote: > nit: maybe we could add some comments to said the motivation for >

[clang] 3fe89be - [clang][RISCV][NFC] Prevent data race in RVVType::computeType

Author: Kito Cheng Date: 2022-11-23T16:59:19+08:00 New Revision: 3fe89be8015955f2e8403f8b7d7580db13cedb2c URL: https://github.com/llvm/llvm-project/commit/3fe89be8015955f2e8403f8b7d7580db13cedb2c DIFF: https://github.com/llvm/llvm-project/commit/3fe89be8015955f2e8403f8b7d7580db13cedb2c.diff LO

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kito-cheng marked 2 inline comments as done. Closed by commit rG3fe89be80159: [clang][RISCV][NFC] Prevent data race in RVVType::computeType (authored by kito-cheng). R

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 477409. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

hokein added a comment. >> we are missing refs in some using declarations (line 31, line32), but line >> 33 does have a link which seems weird > > They are different types of symbol (template vs function), may make a > difference? You're right, the template is the reason here. Taking a closing

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

sammccall added a comment. My biggest concern here is propagating more information here without including it in the cache key. Originally the computation was strictly using the cache key as input, but started using the command-line flags in D73453 . @kadircet an

[clang] 64f5fed - [ASTContext][NFC] Remove getTargetAddressSpace(Qualifiers Q)

Author: Alex Richardson Date: 2022-11-23T09:04:42Z New Revision: 64f5fedb59e82a79c0c669c3d6591ca9eadb82fb URL: https://github.com/llvm/llvm-project/commit/64f5fedb59e82a79c0c669c3d6591ca9eadb82fb DIFF: https://github.com/llvm/llvm-project/commit/64f5fedb59e82a79c0c669c3d6591ca9eadb82fb.diff LO

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TidyFastChecks.py:31 +default='clang-tools-extra/clangd/TidyFastChecks.inc') +parser.add_argument('--file', help='clangd binary to invoke', +default='clang/lib/Sema/Sema.cpp') `file to u

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall added a comment. (I do think the outstanding issues are not related to this patch, so this is ready for review) In D138219#3945954 , @hokein wrote: > E.g. for the following case, the `UsingShadowDecl` refers to the *primary* > template decl,

[PATCH] D138552: [docs] Document that the modules can improve the linking time

ChuanqiXu created this revision. ChuanqiXu added reviewers: dblaikie, iains, aaronmondal, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We found that t

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder updated this revision to Diff 477418. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ https://reviews.llvm.org/D136920 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp Index: clang/test/AST/Interp/arrays.cpp

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. Sam, my read, too, is that the memoizing design isn't safe--also that the key bug is preexisting. I had the same reaction reading through this file after spotting problems in the log. That's what spawned https://github.com/clangd/clangd/issues/1378. Any chance I could

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:962-963 + } else if (const auto *Ctor = dyn_cast(Initializer)) { +const ArrayType *AT = Ctor->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = cast(AT); +size_t NumElems = CAT->g

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyFastChecks.py:41 +def read_old_fast(path): +text = subprocess.check_output(["cpp", "-P", "-FAST(C,T)=C", path]) +for line in text.splitlines(): --

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik, sepavloff. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is split-out from https://reviews.

[PATCH] D137415: [clang][Interp] Implement switch statements

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137415/new/ https://reviews.llvm.org/D137415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall added a comment. In D138219#3946020 , @sammccall wrote: > In D138219#3945954 , @hokein wrote: > >> E.g. for the following case, the `UsingShadowDecl` refers to the *primary* >> template decl, which is n

[PATCH] D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready

dstuttard updated this revision to Diff 477423. dstuttard added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated - adding test for builtin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138216/new/ https://re

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

hokein added a comment. In D138219#3946020 , @sammccall wrote: > (I do think the outstanding issues are not related to this patch, so this is > ready for review) Agree (sorry, I didn't mean we should address in this patch). We have found a few issues,

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

sammccall added a comment. In D138546#3946046 , @cpsauer wrote: > Sam, my read, too, is that the memoizing design isn't safe--also that the key > bug is preexisting. > Nathan and I were thinking, though, that we'd should post this incremental > fix for

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

sammccall updated this revision to Diff 477424. sammccall marked an inline comment as done. sammccall added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138491/new/ https://reviews.llvm.org/D138491 Files: clang-tools-

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TidyFastChecks.inc:2 +// This file is generated, do not edit it directly! +// This describes +#ifndef FAST can

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. Makes sense! Thanks for your time, Sam, and for being great, as always. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. I suppose, if it ever might help make the case with said employer (Google, right?) the broken, non-stock-clang use case that's motivating this is Android (and also usage from Bazel/Blaze). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/HTMLReport.cpp:116 FileID File; + const FileEntry *FE; hokein wrote: > nit: the `FE` can be removed -- we have the FileID, we can

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report.

sammccall updated this revision to Diff 477429. sammccall retitled this revision from "[include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/raw/8736e64c45af411e2c2d72ada

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

njames93 added a comment. In D138505#3944285 , @sammccall wrote: > Ideas on testing welcome. Does it make sense to rely on the fact that > `misc-const-correctness` is always slow? :-D I'd say it doesn't, if the check is ever updated in a way to be more

[clang] 63d65d3 - Reland "[CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)"

Author: Stefan Gränitz Date: 2022-11-23T11:35:22+01:00 New Revision: 63d65d3764ea2fc27e0e1a6054ec42cff6d84158 URL: https://github.com/llvm/llvm-project/commit/63d65d3764ea2fc27e0e1a6054ec42cff6d84158 DIFF: https://github.com/llvm/llvm-project/commit/63d65d3764ea2fc27e0e1a6054ec42cff6d84158.diff

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/HTMLReport.cpp:116 const PragmaIncludes *PI; FileID File; + const FileEntry *MainFE; nit: maybe

[PATCH] D138426: Fix #58958 on github

krsch added a comment. Should I change the title myself or you can change it during commit? If it's on me, how do I change it? `git commit --amend; arc diff`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ https://reviews.llvm.org/D1384

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

sgraenitz updated this revision to Diff 477433. sgraenitz added a comment. clang-format includes and sort clang-formatted-files.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138122/new/ https://reviews.llvm.org/D138122 Files: clang/docs/tool

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. lldb parts LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539 ___ cfe-commits m

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:487 + } + CTFactories = std::move(FastFactories); +} njames93 wrote: > Not exactly related but surely both check factories could be made into static > variables and

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

kadircet added a comment. i can't think of a proper way to test this out either. unless we somehow let slow-tidy-check list to be configurable, so probably fine to make sure it works locally and hope that new people introducing tidy checks do complain. Comment at: clang-tools

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 10 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:141-145 unsigned getAllocSize() const { return AllocSize; } /// returns the size of an element when the structure is viewed as an array. unsigned getEl

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 477437. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall planned changes to this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:518 + +if (F.SlowChecks.has_value()) + Out.Apply.push_back([V = **F.SlowChecks](const Params &, Config &C) { kadircet wrot

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Records macro references in #ifdef clauses as ambiguous. Repository: rG LLVM Github Monorepo https://review

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

sammccall updated this revision to Diff 477443. sammccall added a comment. Script reads/writes from file rather than redirecting output. Update .inc file to show "no-op" changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138491/new/ https://rev

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

ebrevnov updated this revision to Diff 477446. ebrevnov marked an inline comment as done. ebrevnov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137149/n

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

DavidSpickett added a comment. We (Linaro) also have an issue with a bot that uses `-DCOMPILER_RT_BUILD_SANITIZERS=OFF`. https://lab.llvm.org/buildbot/#/builders/178/builds/3318 CMake Error at cmake/modules/AddLLVM.cmake:1915 (add_dependencies): The dependency target "ScudoUnitTests" of t

[clang] 5cfc22c - Revert "[SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes"

Author: Benjamin Kramer Date: 2022-11-23T13:11:16+01:00 New Revision: 5cfc22cafe3f2465e0bb324f8daba82ffcabd0df URL: https://github.com/llvm/llvm-project/commit/5cfc22cafe3f2465e0bb324f8daba82ffcabd0df DIFF: https://github.com/llvm/llvm-project/commit/5cfc22cafe3f2465e0bb324f8daba82ffcabd0df.dif

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137399: [clang][Interp] Emit negated integers directly as constants

tbaeder abandoned this revision. tbaeder added a comment. This was just to make the byte code a little more readable, but given the amount of pending patches I already have, I'll abandon this and maybe revisit at a later point, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 updated this revision to Diff 477453. Origami404 added a comment. Change implements according reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.org/D137043 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D138564: Format changes with clang-format

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138564 Files: clang-tools-extra/include-clea

[PATCH] D138566: [clang-tidy][NFC] Make CheckFactories::CreateChecks* const

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-comm

[clang-tools-extra] 19ab2a6 - [include-cleaner] Show includes matched by refs in HTML report.

Author: Sam McCall Date: 2022-11-23T13:41:24+01:00 New Revision: 19ab2a671eb32bede5a0bf686aebf3c6838848e3 URL: https://github.com/llvm/llvm-project/commit/19ab2a671eb32bede5a0bf686aebf3c6838848e3 DIFF: https://github.com/llvm/llvm-project/commit/19ab2a671eb32bede5a0bf686aebf3c6838848e3.diff LO

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG19ab2a671eb3: [include-cleaner] Show includes matched by refs in HTML report. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D1382

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477461. VitaNuo added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tools-extra/

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hans added a comment. Chromium is broken too CMake Error at /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/cmake/modules/AddLLVM.cmake:1915 (add_dependencies): The dependency target "ScudoUnitTests" of target "check-runtimes" does not exist. Call Stack (most recent call first):

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 updated this revision to Diff 477467. njames93 added a comment. Hopefully fixed line endings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 Files: clang/include/clang/AST/Decl.h clang/include/

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 477470. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rebase and update check-lines after D137939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13794

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 477471. sgraenitz added a comment. Handle potential multi-color basic blocks in addOpBundleForFunclet() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944 Files: cla

[PATCH] D134177: Add MC support of RISCV Zcd Extension

VincentWu updated this revision to Diff 477475. VincentWu added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.org/D134177 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Suppor

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 updated this revision to Diff 477482. Origami404 added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 Files: clang/docs/ReleaseNotes.rst clang/include/clan

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

ismaelJimenez created this revision. Herald added a project: All. ismaelJimenez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138571 Files: clang/docs/LibASTMatchersTutor

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

ismaelJimenez updated this revision to Diff 477488. ismaelJimenez added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138571/new/ https://reviews.llvm.org/D138571 Files: clang/docs/LibASTMatchersTutorial.rst Index: clang/docs/Li

[PATCH] D138559: Record macro references in #ifdef clause.

hokein added a comment. Thanks, this code looks good to me overall. I think we can extend it to handle the `Defined`, `Elifdef`, `Elifndef` cases. And please add a `[include-cleaner]` prefix in the commit title. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:95

Re: [clang] 5cfc22c - Revert "[SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes"

Thank you! On Wed, Nov 23, 2022 at 3:11 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2022-11-23T13:11:16+01:00 > New Revision: 5cfc22cafe3f2465e0bb324f8daba82ffcabd0df > > URL: > https://github.com/llvm/llvm-project/commit/5cfc22cafe3f2465e0bb324f8daba82ffcabd0

[clang] 93b98eb - [analyzer] getBinding should auto-detect type only if it was not given

Author: Balazs Benics Date: 2022-11-23T15:52:11+01:00 New Revision: 93b98eb399a14f2c626ed82eaaa70997f8323406 URL: https://github.com/llvm/llvm-project/commit/93b98eb399a14f2c626ed82eaaa70997f8323406 DIFF: https://github.com/llvm/llvm-project/commit/93b98eb399a14f2c626ed82eaaa70997f8323406.diff

[PATCH] D136603: [analyzer] getBinding should auto-detect type only if it was not given

This revision was automatically updated to reflect the committed changes. Closed by commit rG93b98eb399a1: [analyzer] getBinding should auto-detect type only if it was not given (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D136603?vs=471112&id=477493#toc Repository

[PATCH] D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready

Joe_Nash accepted this revision. Joe_Nash added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138216/new/ https://reviews.llvm.org/D138216 ___

[PATCH] D138319: [analyzer] Prepare structures for integral cast feature introducing

steakhal added a comment. I spent some time on this patch. But I'm left thinking about why we need the extra indirection? Couldn't we just use a `std::pair` pair as a key instead? You mention //effective// bitwidths in your summary, but the code does not mention this concept. Maybe you could ela

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hans added a comment. Reverted in 907baeec49bfbe9e76498634a9418e1dc6c973d9 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 ___ cfe-commits mailing list

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

steakhal added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:54-55 + bool TraverseDecl(Decl *Node) { +if (!Node) + return true; +if (!match(*Node)) Can `Node` be ever null if the visitor is initiated only be `AST_MATCHER_P`?

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(&Val); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D138577: Use proper triple in CmdArgsSansAnalyses for html info files

angroyer created this revision. angroyer added a reviewer: LLVM. angroyer added a project: LLVM. Herald added a reviewer: NoQ. Herald added a project: All. angroyer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The CmdArgsSansAnalyses arr

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(&Val); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

tmatheson created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. tmatheson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements assembly support for the 202

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

ankineri created this revision. ankineri added a reviewer: sammccall. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ankineri requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commi

[PATCH] D138577: Use proper triple in CmdArgsSansAnalyses for html info files

angroyer added a reviewer: honggyu.kim. angroyer added a comment. Please review this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138577/new/ https://reviews.llvm.org/D138577 ___ cfe-commits mailin

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. In D138426#3946202 , @krsch wrote: > Should I change the title myself or you can change it during commit? If it's > on me, how do I change it? `git commit --amend; arc diff`? phabricator isn't very elegant, locally changing the

[PATCH] D138426: Fix #58958 on github

dblaikie added a comment. In D138426#3947044 , @aeubanks wrote: > In D138426#3946202 , @krsch wrote: > >> Should I change the title myself or you can change it during commit? If it's >> on me, how do I change it?

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. the precommit bot is still complaining that flang/lib/Frontend/FrontendActions.cpp needs to be updated lgtm if the precommit bot doesn't show anything related to this patch Repository:

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

steakhal added a comment. Are you sure about the speedup? When I looked at the implementation of the `StringSwitch`, it boiled down to an `if-else` chain under the hood. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137258/new/ https://reviews.llv

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ben.boeckel added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:192 +"p1689-targeted-directory", llvm::cl::Optional, +llvm::cl::desc("Only supported for P1689, the targeted directory of which " + "the dependencies are to be c

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477549. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tools-extra

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson updated this revision to Diff 477550. royjacobson added a comment. Add a missing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138387/new/ https://reviews.llvm.org/D138387 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477551. VitaNuo added a comment. Remove the extra test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp cl

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14462-14467 + RLoc, CurFPFeatureOverrides()); +else + TheCall = + CallExpr::Create(Context, FnExpr.get(), Method

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked an inline comment as done. royjacobson added a comment. In D138387#3944211 , @cor3ntin wrote: > Beside the formatting nitpick this looks good Thanks! I'll wait until next week to let other people have a chance to take a look. Reposi

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477554. VitaNuo added a comment. Make explicit RefType default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(&Val); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885

[PATCH] D138552: [docs] Document that the modules can improve the linking time

dblaikie added a comment. I'm not sure I follow this - the comparison doesn't seem equal. If you wanted the modules-like code in non-modules, you could get it by having `notDirectlyUsed` declared-but-not-defined in the header file, and defined in the corresponding .cpp file, yeah? Repository:

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539 _

[PATCH] D138426: Fix #58958 on github

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cea4c239570: Do not suggest taking the address of a const pointer to get void* (authored by krsch, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 2cea4c2 - Do not suggest taking the address of a const pointer to get void*

Author: Alexey Kreshchuk Date: 2022-11-23T18:43:06Z New Revision: 2cea4c239570c37f46ad0003b3d41d9473aca60f URL: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f DIFF: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f.diff L

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders updated this revision to Diff 477566. tom-anders added a comment. Add end-to-end test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137894/new/ https://reviews.llvm.org/D137894 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie created this revision. dblaikie added reviewers: aprantl, probinson. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. dblaikie requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits

  1   2   >