sammccall added a comment.

My biggest concern here is propagating more information here without including 
it in the cache key.
Originally the computation was strictly using the cache key as input, but 
started using the command-line flags in D73453 
<https://reviews.llvm.org/D73453>. @kadircet any extra context on when/why this 
is safe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138546/new/

https://reviews.llvm.org/D138546

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to