kito-cheng marked 3 inline comments as done.
kito-cheng added inline comments.
================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:284
+
+class RVVTypeCache {
+private:
----------------
khchen wrote:
> nit: maybe we could add some comments to said the motivation for
> `RVVTypeCache`.
good suggestion, thanks :)
================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:289
+
+ static uint64_t computeRVVTypeHashValue(BasicType BT, int Log2LMUL,
+ PrototypeDescriptor Proto);
----------------
kadircet wrote:
> khchen wrote:
> > `static` could be eliminated now.
> nit: i'd actually drop it from the header completely
I just move that to a local static function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138429/new/
https://reviews.llvm.org/D138429
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
