ben.boeckel added inline comments.

================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:192
+    "p1689-targeted-directory", llvm::cl::Optional,
+    llvm::cl::desc("Only supported for P1689, the targeted directory of which "
+                   "the dependencies are to be computed."),
----------------
I'm not sure what this means. Is it the compiler's working directory when 
compiling?


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:197
+llvm::cl::opt<std::string> P1689TargetedCommand(
+    "p1689-targeted-command", llvm::cl::Optional,
+    llvm::cl::desc("Only supported for P1689, the targeted command of which "
----------------
Can this be something like `--` so that I don't have to figure out how to quote 
the thing (for the shell and whatever parsing Clang does internally)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137534/new/

https://reviews.llvm.org/D137534

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to