[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

ychen updated this revision to Diff 470546. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaConcept.cpp clang/li

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

erichkeane added a comment. In D136533#3882976 , @mizvekov wrote: > I don't have access to a macOS machine, and I don't believe any of the > pre-commit CI machines are running it either. > So I don't have much to go on here. > > How do you think we shall

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument &Arg = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type)

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3883048 , @erichkeane wrote: > One thing you might try is seeing if this is a libcxx-specific thing instead, > and try doing a self-build using libcxx. We tested this on the libc++ CI, as this patch touches a test c

[PATCH] D136700: clang: Add a cmake toggle to disable libclang's libxml2 dependency

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. By default, libclang will still depend on libxml2 according to LLVM_ENABLE_LIBXML2, but with this it's possible to make libclang not depend on libxml2 even though LLV

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

w2yehia added a comment. > I wasn't included as a reviewer on D124857 > and I missed that change so couldn't comment there, but I'm not a fan of > including the AIX support in InstrProfilingPlatformLinux.c. AIX is neither > Linux nor ELF-based and big chunks o

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

erichkeane added a comment. In D136533#3883089 , @mizvekov wrote: > In D136533#3883048 , @erichkeane > wrote: > >> One thing you might try is seeing if this is a libcxx-specific thing >> instead, and try doing a

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield, ronlieb. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the device li

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet updated this revision to Diff 470558. kadircet marked 5 inline comments as done. kadircet added a comment. - Rename Related to Ambigious in RefKind - Add more tests for implicit constructor calls - Default to Explicit as RefKind when reporting references - Don't report unused overloads, u

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:107 TEST(WalkAST, DeclRef) { - testWalk("int ^x;", "int y = ^x;"); - testWalk("int ^foo();", "int y = ^foo();"); - testWalk("namespace ns { int ^x; }", "int y = ns::^x;");

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3883116 , @erichkeane wrote: > I don't believe that the libc++ CI does 'self build with libcxx as the host > library', so it would not have caught this. That said, this could definitely > just be an issue in the ve

[PATCH] D136571: [RISCV] add svinval extension

BeMg updated this revision to Diff 470559. BeMg added a comment. Update RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet updated this revision to Diff 470560. kadircet marked an inline comment as done. kadircet added a comment. - Clarify default constructor call example in RefType::Implicit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135859/new/ https://re

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:33 +/// Indicates the relation between the reference and the target. +enum class RefType { + /// Target is explicit from the reference, e.g. function call. hokei

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 470561. void added a comment. Update the release notes to something resembling English. Also add a better explanation of what "3" means. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.ll

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. Thank you! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 ___ cfe-commits mailing lis

[PATCH] D136615: [Instrumentation] Remove legacy passes

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. dfsan removal can use the dedicated D136615 . Other legacy instrumentation passes can use this patch:) Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D124594: [LegacyPM] Remove DataFlowSanitizerLegacyPass

MaskRay added a subscriber: aeubanks. MaskRay added a comment. Herald added a subscriber: Enna1. In D124594#3479202 , @MaskRay wrote: > In D124594#3479195 , @browneee > wrote: > >> I know this is currently used i

[PATCH] D124594: [LegacyPM] Remove DataFlowSanitizerLegacyPass

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa527bda520f0: [LegacyPM] Remove DataFlowSanitizerLegacyPass (autho

[clang] 1232f97 - [docs] Update clang-formatted-files.txt after bindings/go removal (D135436)

Author: Fangrui Song Date: 2022-10-25T10:57:19-07:00 New Revision: 1232f977706282e1dbf9b55b34ab44e468ad8bf6 URL: https://github.com/llvm/llvm-project/commit/1232f977706282e1dbf9b55b34ab44e468ad8bf6 DIFF: https://github.com/llvm/llvm-project/commit/1232f977706282e1dbf9b55b34ab44e468ad8bf6.diff

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. In D134902#3882255 , @aaron.ballman wrote: > One thing I would appreciate is, once we're getting close to done with the > work around flexible arrays, is to explicitly document our > implementation-defined behaviors around flexibl

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. @Eugene.Zelenko , could you please stamp the patch if you don't have any other concerns? @njames93 , if you don't have spare cycles could you please suggest other reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

aganea added subscribers: thieta, saudi. aganea added a comment. +@saudi @thieta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits mailing list cf

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

tra added a comment. I would argue that parallel compilation and linking may need to be disabled by default. I believe similar patches were discussed in the past regarding sub-compilations, but they are relevant for parallel linking, too. Google search shows D52193

[PATCH] D136615: [Instrumentation] Remove legacy passes

aeubanks added a comment. did you mean to point to a different patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136615/new/ https://reviews.llvm.org/D136615 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

tra added a comment. @yaxunl - Found it: D69582 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.org/D136701 ___ cfe-commits mailing list c

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added a comment. In D128372#3883214 , @denik wrote: > @Eugene.Zelenko , could you please stamp the patch if you don't have any > other concerns? Please wait for developers approval. I look only for trivial issues. Repository: rG LLVM

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice!! Just nits. At a high level, I'm a little concerned about this as a demo, since I wouldn't recommend this implementation in practice (for various reasons, e.g. I would encode with 2

[clang] 0e8a414 - [CUDA, NVPTX] Added basic __bf16 support for NVPTX.

Author: Artem Belevich Date: 2022-10-25T11:08:06-07:00 New Revision: 0e8a414ab3d330ebb2996ec95d8141618ee0278b URL: https://github.com/llvm/llvm-project/commit/0e8a414ab3d330ebb2996ec95d8141618ee0278b DIFF: https://github.com/llvm/llvm-project/commit/0e8a414ab3d330ebb2996ec95d8141618ee0278b.diff

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e8a414ab3d3: [CUDA, NVPTX] Added basic __bf16 support for NVPTX. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added a comment. In D136701#3883218 , @tra wrote: > I would argue that parallel compilation and linking may need to be disabled > by default. I believe similar patches were discussed in the past regarding > sub-compilations, but they are relevan

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:24 +/// Indicates the relation between the reference and the target. +enum class RefType { as discussed I moved the other vocab types into t

[clang] effd75b - [M68k][Driver] Rename target features and macros test files

Author: Min-Yih Hsu Date: 2022-10-25T11:24:48-07:00 New Revision: effd75bda4b1a9b26e554c1cda3e3b4c72fa0aa8 URL: https://github.com/llvm/llvm-project/commit/effd75bda4b1a9b26e554c1cda3e3b4c72fa0aa8 DIFF: https://github.com/llvm/llvm-project/commit/effd75bda4b1a9b26e554c1cda3e3b4c72fa0aa8.diff L

[PATCH] D136615: [Instrumentation] Remove legacy passes

MaskRay added a comment. In D136615#3883220 , @aeubanks wrote: > did you mean to point to a different patch? My fault. Updated my previous comment. Pushed it:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D134902#3883209 , @void wrote: > In D134902#3882255 , @aaron.ballman > wrote: > >> One thin

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, probinson. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've been worki

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4206-4214 // If a -gdwarf argument appeared, remember it. const Arg *GDwarfN = getDwarfNArg(Args); bool EmitDwarf = false; if (GDwarfN) { if (checkDebugInfoOption(GDwarfN, Ar

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:107 unsigned ParseDebugDefaultVersion(const ToolChain &TC, const llvm::opt::ArgList &Args); This can be made static to the .cpp file

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

rymiel added a comment. Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136658/new/ https://reviews.llvm.org/D136658 ___ cfe-c

[clang] 1e4e243 - [WebAssembly] Update supported features in the generic CPU configuration

Author: Dan Gohman Date: 2022-10-25T11:44:22-07:00 New Revision: 1e4e2433bcd1a0296ef1043c462252f0d087d90c URL: https://github.com/llvm/llvm-project/commit/1e4e2433bcd1a0296ef1043c462252f0d087d90c DIFF: https://github.com/llvm/llvm-project/commit/1e4e2433bcd1a0296ef1043c462252f0d087d90c.diff LO

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4e2433bcd1: [WebAssembly] Update supported features in the generic CPU configuration (authored by sunfish). Changed prior to commit: https://rev

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && + La

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

tra added a comment. In D136701#3883300 , @jhuber6 wrote: > However, as an opt-in feature it would be very helpful in some cases. I'm OK with the explicit opt-in. > Like consider someone creating a static library that supports every GPU > architecture

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

rjmccall added inline comments. Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-property.m:89 + +// CHECK: call void @__destructor_8_s0(ptr %[[AGG_TMP_ENSURED]]) + It looks like we're copying `a` into a temporary and then copying out of that temporary int

[clang] 4981a18 - [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia

Author: Alex Brachet Date: 2022-10-25T19:17:52Z New Revision: 4981a186b3aa5fbe207dce4902d4dce504974f3f URL: https://github.com/llvm/llvm-project/commit/4981a186b3aa5fbe207dce4902d4dce504974f3f DIFF: https://github.com/llvm/llvm-project/commit/4981a186b3aa5fbe207dce4902d4dce504974f3f.diff LOG:

[PATCH] D136703: [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4981a186b3aa: [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia (authored by abrachet). Herald added a project: clang. He

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Maetveis added a comment. In D131469#3808758 , @dongjunduo wrote: > I'm sorry that I didn't see the comments until now because of some personal > work... Thank you for your kindness and suppot, I will improve this part of > work according to your idea

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D13671

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D136658#3883372 , @rymiel wrote: > Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? I'm all i

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet updated this revision to Diff 470597. abrachet added a comment. Use sed to filter nm output instead of grep. grep exits with exit code 1 because there are no matching lines. This is expected because there are no more external symbols other than `_main` and `__mh_execute_header`, note `_

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet added a comment. In D135340#3882280 , @thakis wrote: > This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` > on mac. I'm reverting this again for now. Sorry about that, I've tested it locally and it should be good to go

[PATCH] D133998: [HIP][test] Avoid %T

probinson added subscribers: lamb-j, probinson. probinson added a comment. @MaskRay I see that you restored the `clang-driver` keyword in hip-link-bc-to-bc.hip, and of course that keyword is not defined anywhere so the test is never being run. Is there an issue filed to track this? Or is the or

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) {

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw updated this revision to Diff 470598. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136638/new/ https://reviews.llvm.org/D136638 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein updated this revision to Diff 470599. hokein marked an inline comment as not done. hokein added a comment. refine the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136539/new/ https://reviews.llvm.org/D136539 Files: clang/lib/Lex/To

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein added a comment. In D136539#3882922 , @sammccall wrote: > In D136539#3882316 , @hokein wrote: > >>> This is a subtle change that needs careful review, and honestly should have >>> a test. >> >> I agree, an

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta created this revision. manojgupta added reviewers: abidh, tomhughes. Herald added subscribers: kristof.beyls, ki.stfu, dschuff. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches

[clang] ef37504 - [Instrumentation] Remove legacy passes

Author: Arthur Eubanks Date: 2022-10-25T13:11:07-07:00 New Revision: ef37504879eecab1af98c70888bee0be403b9c60 URL: https://github.com/llvm/llvm-project/commit/ef37504879eecab1af98c70888bee0be403b9c60 DIFF: https://github.com/llvm/llvm-project/commit/ef37504879eecab1af98c70888bee0be403b9c60.diff

[PATCH] D136615: [Instrumentation] Remove legacy passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef37504879ee: [Instrumentation] Remove legacy passes (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D136615?vs=470185&i

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. We have tooling that uses this command line from the PDB. I think the conservative approach is to emit the command line by default since this is how MSVC behaves. I don't mind this flag now that I know about it, but I think we should keep the default to what MSVC does fo

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. Also this should have a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) { Curren

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

tomhughes added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:697-698 Builder.defineMacro("__ELF__"); +if (Opts.CPlusPlus) + Builder.defineMacro("_GNU_SOURCE"); + } I think this should apply to both C and C++ Repository: rG LLVM

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-c

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

sammccall accepted this revision. sammccall added a comment. LG other than removing the redundant same-sloc-address check again (sorry!) Comment at: clang/lib/Lex/TokenLexer.cpp:1010 +unsigned distance = +T.getLocation().getRawEncoding() - LastLoc.getRawEnco

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. FWIW we do have precedent of deviating from cl.exe for determinism reasons. I think having deterministic output is a good default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474

[PATCH] D136638: [clang-doc] Fix typedef/using output.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:396-397 +template <> llvm::Expected getCommentInfo(TypedefInfo *I) { + I->Description.emplace_back(); +

[clang-tools-extra] 7231c99 - [clang-doc] Fix typedef/using output.

Author: Brett Wilson Date: 2022-10-25T13:47:24-07:00 New Revision: 7231c9966e523a6fa20aa63b9a9245aff49cf881 URL: https://github.com/llvm/llvm-project/commit/7231c9966e523a6fa20aa63b9a9245aff49cf881 DIFF: https://github.com/llvm/llvm-project/commit/7231c9966e523a6fa20aa63b9a9245aff49cf881.diff

[PATCH] D136638: [clang-doc] Fix typedef/using output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7231c9966e52: [clang-doc] Fix typedef/using output. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 470611. manojgupta added a comment. Removed c++ limitation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/D

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added a comment. In D136701#3883416 , @tra wrote: > In D136701#3883300 , @jhuber6 wrote: > >> However, as an opt-in feature it would be very helpful in some cases. > > I'm OK with the explicit opt-in. Mig

[PATCH] D133998: [HIP][test] Avoid %T

MaskRay added a comment. In D133998#3883517 , @probinson wrote: > @MaskRay I see that you restored the `clang-driver` keyword in > hip-link-bc-to-bc.hip, and of course that keyword is not defined anywhere so > the test is never being run. > Is there an

[PATCH] D136293: [IncludeCleaner] Add public API

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:27 + Symbol(Decl &D) : Storage(&D) {} + Symbol(tooling::stdlib::Symbol S) : Storage(S) {} + Doh, I was skimming and missed that you removed

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

rnk added a comment. In D136474#3883629 , @thakis wrote: > FWIW we do have precedent of deviating from cl.exe for determinism reasons. I > think having deterministic output is a good default. This is true, but the cc1 flag isn't inherently non-determini

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

yaxunl added a comment. In general, I think parallelizing the linking workload for multiple GPU's in the linker wrapper is a useful feature. I am not sure whether the workload to be parallelized includes the LLVM passes and codegen, which is usually the bottleneck. Parallelizing this workload w

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 470623. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittest

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5196-5206 + std::function FormatBadBranches = + [&](std::string Prefix, unsigned Lines) { +const std::string Directives[] = {"", "#if X\n", "#els

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great to me, thanks!! Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-notes.cpp:32-33 __buf_size_arg_constraint_concrete(buf); // \ -// expe

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:2179 + for (unsigned I = 0; I < E->NumExprs; I++) +E->getTrailingObjects()[I] = Record.readSubExpr(); +} ilya-biryukov wrote: > FYI: I think this is where the crash comes fro

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers updated this revision to Diff 470638. nickdesaulniers added a comment. - more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136707/new/ https://reviews.llvm.org/D136707 Files: clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7966 } + unsigned DwarfVersion = GetDwarfVersion(getToolChain(), Args); RenderDebugEnablingArgs(Args, CmdArgs, DebugInfoKind, DwarfVersion, Consider `const` if this variable i

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 470644. friss added a comment. Address some review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.t

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470645. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D136715: formatting clang offloadbundler source file

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136715/new/ https://reviews.llvm.org/D136715 ___

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

aganea added a comment. Hello @gchatelet! This patches introduces a regression in a two-stage build using rpmalloc on Windows. Bisection lead me here. Would you have a chance to take a look please? Thanks in advance. To reproduce, I used the following script (rename to make_llvm.bat) F25053901:

[PATCH] D136715: formatting clang offloadbundler source file

jdoerfert accepted this revision. jdoerfert added a comment. I'm not sure why you fight with phabricator so much. I was going to edit your revision metadata but you for some reason disallowed that. I would generally suggest against that. --- The patch itself is fine, the commit subject line and

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

steven_wu added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:3002 +// The format of the stat cache is (pseudo-code): +// struct stat_cache { +//char Magic[4]; // "STAT" or "Stat" Few comments about stats representation. 1. Ca

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

efriedma added a comment. It's not really a regression, just a bug in the feature. The rpmalloc code is checking `__has_builtin(__builtin_memset_inline)`, so older versions of clang aren't seeing the same source code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ce78940b4c: [clang] Changes to produce sugared converted template arguments (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/ne

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. > Hey @dongjunduo, > Are you still interested in finishing this? If not I was thinking that I > would pick it up, so I can work on the follow ups. @Maetveis Sorry for delaying the issue due to some personal trifles... This part of the implementation has been prelimin

[PATCH] D136715: [NFC][Offload Bundler] Formatting clang offloadbundler source file

raghavmedicherla added a comment. @jdoerfert Sorry for the inconvenience! I had no idea that you would be added as a reviewer by default, so I was trying to remove you as a reviewer. I'll be careful next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The occurrences are roots for finding used headers, like walkAS

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:75 +// - for a logical file like , we check Spelled +llvm::SmallVector match(Header H) const; + in the prototype I reimplemented this f

[clang] e5d9e80 - [clang] Perform sugared substitution of builtin templates

Author: Matheus Izvekov Date: 2022-10-26T02:34:42+02:00 New Revision: e5d9e802e50dd55a326e31a0d562e5263b208f3b URL: https://github.com/llvm/llvm-project/commit/e5d9e802e50dd55a326e31a0d562e5263b208f3b DIFF: https://github.com/llvm/llvm-project/commit/e5d9e802e50dd55a326e31a0d562e5263b208f3b.dif

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5d9e802e50d: [clang] Perform sugared substitution of builtin templates (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/ ht

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && +

[PATCH] D136725: [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This list was originally used for to make sure MacroInfo's clever memory management

[PATCH] D136725: [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC

sammccall added a comment. (I'm sure this doesn't matter much, I just ran into it while trying to understand lifetimes of various macro description objects) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136725/new/ https://reviews.llvm.org/D136725

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

Allen added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:186 + !eq(name, "v2f16"): Float16x2Regs, + !eq(name, "bf16"): Float16Regs, + !eq(name, "v2bf16"): Float16x2Regs, tra wrote: > tra wrote: > > Allen wrote: > > > sorry for

<    1   2   3   >