mizvekov added a comment.

In D136533#3883048 <https://reviews.llvm.org/D136533#3883048>, @erichkeane 
wrote:

> One thing you might try is seeing if this is a libcxx-specific thing instead, 
> and try doing a self-build using libcxx.

We tested this on the libc++ CI, as this patch touches a test case in there, 
and I also tested it on my machine on both windows and linux.

I believe this is a macOS specific issue, and I don't believe the problem is in 
this patch.

In either case, this seems to be an issue with libc++ that is out there in the 
wild.

There are likely some cases where folks were using unsupported features for 
their macOS version, and this bug that we fixed prevented us from correctly 
diagnosing that.

If I understood everything correctly so far, we can't change shipped libc++.
So we either:

- Bump the minimum macOS version.
- Stop using whatever libc++ declared as being unsupported in those old macOS 
versions.

libc++ gated that feature on a minimum OS version, if you try to use it 
otherwise, this doesn't compile, as intended.

Would it even be right to add some kind of libc++ specific workaround, if that 
configuration was declared as unsupported?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136533/new/

https://reviews.llvm.org/D136533

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to