kadircet added inline comments.
================
Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:33
+/// Indicates the relation between the reference and the target.
+enum class RefType {
+ /// Target is explicit from the reference, e.g. function call.
----------------
hokein wrote:
> I'm wondering what's our plan of supporting policy (different coding-style
> may have different decisions about which includes are used)?
>
> IIUC, the RefType is part of the picture, providing fine-grained information
> about each reference, and the caller can make their decisions based on it?
>
> Thinking about the `Implicit` type, I think cases like non-spelled
> constructor call, implicit conversion calls (maybe more?) fall into this
> type, if we support `Policy.Constructor`, and `Policy.Conversion`, how do we
> distinguish with these cases? We can probably do some ad-hoc checks on the
> `TargetDecl`, but I'm not sure that the tuple `<SourceLocation, TargetDecl,
> Ref>` will provide enough information to implement different policy .
> IIUC, the RefType is part of the picture, providing fine-grained information
> about each reference, and the caller can make their decisions based on it?
Exactly that's the idea.
> if we support Policy.Constructor, and Policy.Conversion, how do we
> distinguish with these cases? We can probably do some ad-hoc checks on the
> TargetDecl
In our previous discussions we've also come to the conclusion that TargetDecl
will have enough information for the caller to infer such information later on.
We've decided to not make it part of the public api (at least initially)
because it's unclear how widely useful those signals will be. But if it turns
out to be needed by a variety of applications the design is extensible to
either provide a:
- inferDetails(Symbol) helper, which would derive a signal structure that
extracts most of those signals needed, or
- update Callback signature to also carry that information derived from the
Symbol
Does that make sense?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135859/new/
https://reviews.llvm.org/D135859
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
