aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D134902#3883209 <https://reviews.llvm.org/D134902#3883209>, @void wrote: > In D134902#3882255 <https://reviews.llvm.org/D134902#3882255>, @aaron.ballman > wrote: > >> One thing I would appreciate is, once we're getting close to done with the >> work around flexible arrays, is to explicitly document our >> implementation-defined behaviors around flexible arrays in >> https://clang.llvm.org/docs/LanguageExtensions.html. Right now, what is and >> isn't a flexible array to Clang is really complex and not having the rules >> written down anywhere is not helpful to users. These cleanup efforts are >> fantastic and seem like a good opportunity for us to rectify the lack of >> docs. > > Sure. Do you want that done with this change? Up to you -- I'd be fine if you preferred to do it in a follow-up given that it's somewhat indirectly related to adding support for `3`. Changes LGTM currently, but please wait a day or so before landing in case @serge-sans-paille or @kees have comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
