mizvekov added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101
+ const TemplateArgument &Arg =
+ FunctorParentType->template_arguments()[ArgNum];
if (Arg.getKind() != TemplateArgument::Type)
----------------
thakis wrote:
> This is overall a nice change, but here (and a few other places), the RHS
> looks strictly uglier to me. Maybe it makes sense to keep the getNumArgs() /
> getArg() functions (and make them call template_arguments() internally), for
> the cases where the code doesn't iterate over everything?
I think in those cases, it would just look better to assign the
template_arguments to an `Args` variable or so.
I will propose another patch to improve those cases, and CC you on it.
Otherwise if that doesn't work out, we can try something else.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136602/new/
https://reviews.llvm.org/D136602
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
