[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder updated this revision to Diff 461148. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134057/new/ https://reviews.llvm.org/D134057 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 461151. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:673 + if (Optional T = classify(Init->getType())) { +if (!this->emitDupPtr(Initializer)) + return false; shafik wrote: > This section of code looks duplicate

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 3 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7332 +def err_attribute_webassembly_funcref : Error< + "'__clang_webassembly_funcref' attribute can only be applied to function pointer types">;

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 461159. pmatos added a comment. Addressed some of the concerns from the comments but not ready for review yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files:

[PATCH] D134137: [clangd] Return earlier when snippet is empty

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { +// See https://github.com/clangd/clangd/issues/1216 Does this test trigger the crash for you when run

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

JonasToth added a comment. In D130181#3769618 , @njames93 wrote: > In D130181#3769083 , @JonasToth > wrote: > >> ... > > Your concerns aren't actually that important. Because the transformations > only work on f

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

mgorny added a comment. In D106577#2965059 , @aaron.ballman wrote: > Thanks! I've passed them along to WG14 and will report back what I hear. Have you heard anything since? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D134137: [clangd] Return earlier when snippet is empty

tom-anders marked an inline comment as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { +// See https://github.com/clangd/clangd/issues/1216

[PATCH] D134137: [clangd] Return earlier when snippet is empty

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { +// See https://github.com/clangd/clangd/issues/1216 tom-anders wrote: > nridge wrote: > > Does this

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:915 +in the directory where Clang resides. If Clang is started via an executable +without target prefix, Clang will use ``default.cfg`` instead. What about using default config based on dri

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added inline comments. Comment at: clang/docs/UsersManual.rst:915 +in the directory where Clang resides. If Clang is started via an executable +without target prefix, Clang will use ``default.cfg`` instead. sepavloff wrote: > What about using default con

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

sepavloff added a comment. In D109621#3791511 , @mstorsjo wrote: > On this topic, it would be great if we could pick up a per-target default > config file too, if clang is invoked with `clang -target `. Currently > this is done automatically if clang is

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added a comment. In D109621#3799133 , @sepavloff wrote: > In D109621#3791511 , @mstorsjo > wrote: > >> On this topic, it would be great if we could pick up a per-target default >> config file too, if clan

[PATCH] D134137: [clangd] Return earlier when snippet is empty

tom-anders marked an inline comment as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { +// See https://github.com/clangd/clangd/issues/1216

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#3799067 , @mgorny wrote: > In D106577#2965059 , @aaron.ballman > wrote: > >> Thanks! I've passed them along to WG14 and will report back what I hear. > > Have you heard a

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

mgorny added a comment. In D106577#3799276 , @aaron.ballman wrote: > Sorry, thanks for re-pinging this, it fell off my radar. Yes, I have heard > back from WG14 but there was not really a consensus position (which means > we'd need to write a paper if

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Continuation of https://reviews.llvm.org/D134057. I

[clang] f51789c - Fix a typo in the release notes; NFC

Author: Aaron Ballman Date: 2022-09-19T07:37:41-04:00 New Revision: f51789ce5e759b68584fe6c04a31930496bd6a41 URL: https://github.com/llvm/llvm-project/commit/f51789ce5e759b68584fe6c04a31930496bd6a41 DIFF: https://github.com/llvm/llvm-project/commit/f51789ce5e759b68584fe6c04a31930496bd6a41.diff

[clang] a244194 - Add additional test coverage for C2x N2508

Author: Aaron Ballman Date: 2022-09-19T07:52:07-04:00 New Revision: a244194f73788de6dfd6d753ff09be3625613f9f URL: https://github.com/llvm/llvm-project/commit/a244194f73788de6dfd6d753ff09be3625613f9f DIFF: https://github.com/llvm/llvm-project/commit/a244194f73788de6dfd6d753ff09be3625613f9f.diff

[PATCH] D133887: [Clang] Support label at end of compound statement

aaron.ballman added a comment. Thank you for working on this! I spotted an issue where we're not quite complete with this implementation work. I pushed up a new test case in https://github.com/llvm/llvm-project/commit/a244194f73788de6dfd6d753ff09be3625613f9f that shows it (and set the C status

[PATCH] D134176: Add MC support of RISCV Zcf Extension

VincentWu created this revision. VincentWu added reviewers: kito-cheng, MaskRay, craig.topper, jrtc27, HsiangKai, asb. Herald added subscribers: sunshaoce, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult

[PATCH] D134177: Add MC support of RISCV Zcd Extension

VincentWu created this revision. VincentWu added reviewers: kito-cheng, MaskRay, craig.topper, jrtc27, HsiangKai, asb. Herald added subscribers: sunshaoce, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a comment. In D133853#3797598 , @RIscRIpt wrote: > In D133853#3795579 , @aaron.ballman > wrote: > >> FWIW, one Microsoft-specific attribute I know people have been asking about >> is `[[msvc:

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron added a comment. In D133887#3799310 , @aaron.ballman wrote: > Thank you for working on this! I spotted an issue where we're not quite > complete with this implementation work. I pushed up a new test case in > https://github.com/llvm/llvm-project

[PATCH] D133887: [Clang] Support label at end of compound statement

aaron.ballman added a comment. In D133887#3799347 , @Izaron wrote: > In D133887#3799310 , @aaron.ballman > wrote: > >> Thank you for working on this! I spotted an issue where we're not quite >> complete with thi

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think we're OK for now, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133934 ___ cfe

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

hokein created this revision. hokein added reviewers: kadircet, adamcz. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. It is possible that we can pass a null ParamType to CheckNonTypeTemplateParameter -- the ParamType var can be reset to a nul

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron added a comment. In D133887#3799399 , @aaron.ballman wrote: > I can fix up the C++ status page as well if you'd like, or I can hold off if > you're already working on this, it's up to you! Thank you! I'll support empty labels in switch statement

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:6960 +if (ParamType.isNull()) + return ExprError(); // CheckNonTypeTemplateParameterType will produce a diagnost

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

erichkeane added a comment. I'm still having trouble from the description and test figuring out what this means. Can you better clarify the intent/effect of this? Is the point that the type-aliases could also store a non-canonicalized type? if so, perhaps the patch should better reflect that

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

jamieschmeiser added a comment. Great. Also, something you may want to consider, either as part of or after you land this code. This really is a specific instance of a more generic problem: setting up option handling for something that saves results in a file for each compilation. This is eq

[PATCH] D133887: [Clang] Support label at end of compound statement

aaron.ballman added a comment. In D133887#3799450 , @Izaron wrote: > In D133887#3799399 , @aaron.ballman > wrote: > >> I can fix up the C++ status page as well if you'd like, or I can hold off if >> you're alrea

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

erichkeane added a comment. Patch generally seems OK to me. I would vastly prefer a better commit message explaining the intent here. Also, not quite sure I see the need for the extra bit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. Thanks for taking this over! FIRST, please make sure you re-submit this with the entire 'context' (see context-not-available), by making sure you use -U99 on your patch before uploading it. It DOES appear from the tests that we're already checking everything we'

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane abandoned this revision. erichkeane added a comment. Taken over by someone else here: https://reviews.llvm.org/D134128 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110641/new/ https://reviews.llvm.org/D110641 ___ cfe-commits maili

[PATCH] D134145: [Clang] Implement fix for DR2628

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems right to me, thanks! I'm currently pushing to try to make our diagnostics 'check' lines more readable... it doesn't gain a ton in this case, but more to try to push for con

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3799475 , @erichkeane wrote: > I'm still having trouble from the description and test figuring out what this > means. Can you better clarify the intent/effect of this? The effect is that you can effectively have a

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

erichkeane added a comment. Thanks for the explanation, I think that makes more sense to me. A summarized version in the commit message would be appreciated. As far as the 'asserts', i see them now in the `ASTContext` functions. as far as `Divergent`, I wonder if we should call it something mo

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov added a comment. In D132816#3799484 , @erichkeane wrote: > Patch generally seems OK to me. I would vastly prefer a better commit message > explaining the intent here. Also, not quite sure I see the need for the > extra bit? Well mechanically

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

erichkeane added a comment. In D132816#3799535 , @mizvekov wrote: > In D132816#3799484 , @erichkeane > wrote: > >> Patch generally seems OK to me. I would vastly prefer a better commit >> message explaining the

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3799522 , @erichkeane wrote: > as far as `Divergent`, I wonder if we should call it something more > descriptive, since it isn't just that it 'differs', it is that it is a > non-canonical version, right? Well, curr

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov added a comment. In D132816#3799543 , @erichkeane wrote: > As far as the "commit summary", the patch summary at least is empty... Yeah I meant the one line title of the commit, but I will update it to include a summary with further elaboration

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:281 - void addReturnTypeHint(FunctionDecl *D, SourceLocation Loc) { + void addReturnTypeHint(FunctionDecl *D, SourceRange Range) { auto *AT = D->getReturnType()->getContainedAutoType();

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

erichkeane added a comment. In D133468#3799557 , @mizvekov wrote: > In D133468#3799522 , @erichkeane > wrote: > >> as far as `Divergent`, I wonder if we should call it something more >> descriptive, since it isn

[clang-tools-extra] 924974a - [clangd] Improve inlay hints of things expanded from macros

Author: Sam McCall Date: 2022-09-19T16:44:21+02:00 New Revision: 924974a3a13b03090d04860f209ce11b3d9d00a6 URL: https://github.com/llvm/llvm-project/commit/924974a3a13b03090d04860f209ce11b3d9d00a6 DIFF: https://github.com/llvm/llvm-project/commit/924974a3a13b03090d04860f209ce11b3d9d00a6.diff LO

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG924974a3a13b: [clangd] Improve inlay hints of things expanded from macros (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133982/new/

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

tbaeder updated this revision to Diff 461205. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134175/new/ https://reviews.llvm.org/D134175 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/records.cpp Index: clang/test/AST

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3799572 , @erichkeane wrote: > I agree with all of that, but still am not thrilled at 'Divergent', it isn't > particularly descriptive... `Divergent` has some additional implications that > I'm not sure we mean as w

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D133468#3799609 , @mizvekov wrote: > In D133468#3799572 , @erichkeane > wrote: > >> I agree with

[clang-tools-extra] e424418 - [clangd] Allow programmatically disabling rename of virtual method hierarchies.

Author: Sam McCall Date: 2022-09-19T16:59:28+02:00 New Revision: e4244183582721b1ff47be669f1a115625c46a2f URL: https://github.com/llvm/llvm-project/commit/e4244183582721b1ff47be669f1a115625c46a2f DIFF: https://github.com/llvm/llvm-project/commit/e4244183582721b1ff47be669f1a115625c46a2f.diff LO

[PATCH] D133440: [clangd] Allow programmatically disabling rename of virtual method hierarchies.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGe42441835827: [clangd] Allow programmatically disabling rename of virtual method hierarchies. (authored b

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

ahatanak added a comment. I'm going to commit this in a day or two if there are no more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 ___ cfe-commit

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

beanz added a comment. We should also have a library test case that verifies that the `global_dtors` variable is kept. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:50 void annotateHLSLResource(const VarDecl *D, llvm::GlobalVariable *GV); - void generateGlobalCtorDtorCalls

[PATCH] D133856: [clang][Interp] Pass initializer through when creating variables

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133856/new/ https://reviews.llvm.org/D133856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay added a comment. In D133329#3798371 , @mgorny wrote: > I think you misunderstood me. The aforementioned tests fail if I put > `--gcc-install-dir=` in the config file. There is no way to put it in the > config file that wouldn't affect these test

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl. Herald added subscribers: kosarev, mattd, kerbowa, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Hera

[PATCH] D133856: [clang][Interp] Pass initializer through when creating variables

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Seems fine to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133856/new/ https://reviews.llvm.org/D133856 ___

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske added reviewers: steakhal, martong. balazske added a comment. Herald added a subscriber: rnkovacs. I see that there are problems to solve with this patch. If a global variable is used at `realloc` or the pointer is a function parameter, it may have aliases that are not checkable. In the

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay, hfinkel. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Make `--config`, `--no-default-config` and `--config-*-dir` CoreOptions to enable their availability to a

[PATCH] D134191: [clang] Make config-related options CoreOptions

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134191/new/ https://reviews.llvm.org/D134191 ___ cfe-commits mailing list cfe-comm

[PATCH] D134191: [clang] Make config-related options CoreOptions

MaskRay added a comment. They don't need to be `NoXarchOption` if I am not mistaken. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134191/new/ https://reviews.llvm.org/D134191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

rnk accepted this revision. rnk added a comment. Sound like a good plan. 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 ___ cfe-commits mailing list cfe-comm

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920

[PATCH] D133634: [clang] Allow vector of BitInt

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG649a59712ffb: [clang] Allow vector of BitInt (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 649a597 - [clang] Allow vector of BitInt

Author: Xiang Li Date: 2022-09-19T09:26:56-07:00 New Revision: 649a59712ffbc937174268d04ee9a8885f572e2a URL: https://github.com/llvm/llvm-project/commit/649a59712ffbc937174268d04ee9a8885f572e2a DIFF: https://github.com/llvm/llvm-project/commit/649a59712ffbc937174268d04ee9a8885f572e2a.diff LOG:

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG95b394711106: [clang-format] JSON formatting add new option for controlling newlines in json… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 95b3947 - [clang-format] JSON formatting add new option for controlling newlines in json arrays

Author: mydeveloperday Date: 2022-09-19T17:54:39+01:00 New Revision: 95b39471110680f609cf56f5babf031a1c855d64 URL: https://github.com/llvm/llvm-project/commit/95b39471110680f609cf56f5babf031a1c855d64 DIFF: https://github.com/llvm/llvm-project/commit/95b39471110680f609cf56f5babf031a1c855d64.diff

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny added a comment. In D134191#3799841 , @MaskRay wrote: > They don't need to be `NoXarchOption` if I am not mistaken. I don't know about that. The comment on top says "The option is a "driver"-only option, and should not be forwarded to other tools

[clang] daebf2c - [clang] Make config-related options CoreOptions

Author: Michał Górny Date: 2022-09-19T18:58:09+02:00 New Revision: daebf2c13ce27ac6a7403525cc7fcbc063eb892e URL: https://github.com/llvm/llvm-project/commit/daebf2c13ce27ac6a7403525cc7fcbc063eb892e DIFF: https://github.com/llvm/llvm-project/commit/daebf2c13ce27ac6a7403525cc7fcbc063eb892e.diff

[PATCH] D134191: [clang] Make config-related options CoreOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaebf2c13ce2: [clang] Make config-related options CoreOptions (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Mono

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae updated this revision to Diff 461251. python3kgae added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/lib/Basic/Targets/DirectX.h clang/li

[clang-tools-extra] 8edce2f - [test][clangd] Join back -Xclang and -undef

Author: Vitaly Buka Date: 2022-09-19T10:11:37-07:00 New Revision: 8edce2ff049d2fc635fc20c658daa283661a9958 URL: https://github.com/llvm/llvm-project/commit/8edce2ff049d2fc635fc20c658daa283661a9958 DIFF: https://github.com/llvm/llvm-project/commit/8edce2ff049d2fc635fc20c658daa283661a9958.diff L

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

MaskRay added a comment. In D134127#3798442 , @dmgreen wrote: > This looks like a subset of D133359 ? D133359 looks like it is for AArch64 and may change the diagnostic in a more aggre

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461259. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record &R, llvm::APSInt &Field, llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > brettw wrote: > > paulkirth wrote: >

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

hokein updated this revision to Diff 461260. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134180/new/ https://reviews.llvm.org/D134180 Files: clang/lib/Sem

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

hokein added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:6960 +if (ParamType.isNull()) + return ExprError(); // CheckNonTypeTemplateParameterType will produce a diagnostic if there's adamcz wrote: > So this can only happen when Resu

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe782d9a4a49c: [clang] Fix a nullptr-access crash in CheckTemplateArgument. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] e782d9a - [clang] Fix a nullptr-access crash in CheckTemplateArgument.

Author: Haojian Wu Date: 2022-09-19T19:18:50+02:00 New Revision: e782d9a4a49c8aaf65bea4209cb6a8e7739526ac URL: https://github.com/llvm/llvm-project/commit/e782d9a4a49c8aaf65bea4209cb6a8e7739526ac DIFF: https://github.com/llvm/llvm-project/commit/e782d9a4a49c8aaf65bea4209cb6a8e7739526ac.diff LO

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 ___ cfe-commits mailing list cfe-co

[clang] 7538b36 - [clang][dataflow] Replace usage of deprecated functions with the optional check

Author: Wei Yi Tee Date: 2022-09-19T17:33:25Z New Revision: 7538b3604519b03d32221cdcc346cc1c181b50fb URL: https://github.com/llvm/llvm-project/commit/7538b3604519b03d32221cdcc346cc1c181b50fb DIFF: https://github.com/llvm/llvm-project/commit/7538b3604519b03d32221cdcc346cc1c181b50fb.diff LOG: [c

[PATCH] D133930: [clang][dataflow] Replace usage of deprecated functions with the optional check

This revision was automatically updated to reflect the committed changes. Closed by commit rG7538b3604519: [clang][dataflow] Replace usage of deprecated functions with the optional check (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4391 DDep.add(*PackagerAction, *C.getSingleOffloadToolChain(), - nullptr, Action::OFK_None); + nullptr, C.getActiveOffloadKinds()); } `getActiveOffloadKinds` return

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae updated this revision to Diff 461271. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Add test for dtor in lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/new/ https://reviews.llvm.org/D133993 Files: cl

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

compnerd added a comment. I don't see anything wrong with this change per se, but I'm conflicted on the name of the variable. These are not standard variables but are encroaching on the CMake namespace. What happens if upstream decides to use these names? I think that we should keep the name

[clang] cf94c52 - [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `clang/Analysis/FlowSensitive`.

Author: Wei Yi Tee Date: 2022-09-19T18:06:57Z New Revision: cf94c52e35f2daf4e4caaeb93648f4b5413b557a URL: https://github.com/llvm/llvm-project/commit/cf94c52e35f2daf4e4caaeb93648f4b5413b557a DIFF: https://github.com/llvm/llvm-project/commit/cf94c52e35f2daf4e4caaeb93648f4b5413b557a.diff LOG: [c

[PATCH] D133931: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `clang/Analysis/FlowSensitive`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf94c52e35f2: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const… (authored by wyt). Changed prior to commit: https://re

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 updated this revision to Diff 461286. jhuber6 added a comment. Mixing the concept of the mask passing via an `unsigned` and a single enum value was incorrect. Add a new interface that accepts a mask and adds all active values instead. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4391 DDep.add(*PackagerAction, *C.getSingleOffloadToolChain(), - nullptr, Action::OFK_None); + nullptr, C.getActiveOffloadKinds()); } -

[PATCH] D133933: [clang][dataflow] Modify `transfer` in `DataflowModel` to take `CFGElement` as input instead of `Stmt`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41d52c5a7f7a: [clang][dataflow] Modify `transfer` in `DataflowModel` to take `CFGElement` as… (authored by wyt). Repository: rG LLVM Github Monore

[clang] 41d52c5 - [clang][dataflow] Modify `transfer` in `DataflowModel` to take `CFGElement` as input instead of `Stmt`.

Author: Wei Yi Tee Date: 2022-09-19T18:40:29Z New Revision: 41d52c5a7f7ad1acf8e84ad6d7f04813c1a5a7ec URL: https://github.com/llvm/llvm-project/commit/41d52c5a7f7ad1acf8e84ad6d7f04813c1a5a7ec DIFF: https://github.com/llvm/llvm-project/commit/41d52c5a7f7ad1acf8e84ad6d7f04813c1a5a7ec.diff LOG: [c

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang/include/clang/Driver/Action.h:304 +/// Add a action along with the associated toolchain, bound arch, and +/// offload kinds. -

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Action.cpp:320 +if (OKind & Mask) + DeviceOffloadKinds.push_back(OKind); +} tra wrote: > It would be good to clear processed bits in `Mask` and then ass

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. if(LLVM_ENABLE_ZSTD) list(APPEND imported_libs zstd::libzstd_shared) endif() This hard codes shared linking which breaks the use case of static linking LLVM. Also LLVM needs to now include a Findzstd.cmake file or else we get this error: CMake Error at cmake/

[PATCH] D133935: [clang][dataflow] Refactor `clang/Analysis/FlowSensitive/MatchSwitchTest.cpp`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88210b81eed8: [clang][dataflow] Refactor `clang/Analysis/FlowSensitive/MatchSwitchTest.cpp`. (authored by wyt). Changed prior to commit: https://r

[clang] 88210b8 - [clang][dataflow] Refactor `clang/Analysis/FlowSensitive/MatchSwitchTest.cpp`.

Author: Wei Yi Tee Date: 2022-09-19T19:10:41Z New Revision: 88210b81eed803598afeeaa2a60eb26ddbb65435 URL: https://github.com/llvm/llvm-project/commit/88210b81eed803598afeeaa2a60eb26ddbb65435 DIFF: https://github.com/llvm/llvm-project/commit/88210b81eed803598afeeaa2a60eb26ddbb65435.diff LOG: [c

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding some codegen reviewers for awareness. Comment at: clang/lib/Basic/Targets/DirectX.h:66 + bool hasBitIntType() const override { return true; } bool hasFeature(StringRef Feature) const

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. zstd provides GNU Makefile, CMake, and Meson. The CMake files are only installed when configured with CMake. Debian and Ubuntu lack such files. The pkg-config file libzstd.pc is probably the most portable file. (I have also used it for a binutils-gdb patch.) I think we

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

Izaron created this revision. Izaron added reviewers: clang-language-wg, aaron.ballman, cor3ntin. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Direct continuation of https://reviews.llvm.org/D133887

  1   2   >