This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf94c52e35f2: [clang][dataflow] Replace `transfer(const Stmt
*, ...)` with `transfer(const… (authored by wyt).
Changed prior to commit:
https://reviews.llvm.org/D133931?vs=460350&id=461278#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133931/new/
https://reviews.llvm.org/D133931
Files:
clang/include/clang/Analysis/FlowSensitive/NoopAnalysis.h
clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp
clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp
clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp
Index: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp
===================================================================
--- clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp
+++ clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp
@@ -111,7 +111,7 @@
static NonConvergingLattice initialElement() { return {0}; }
- void transfer(const Stmt *S, NonConvergingLattice &E, Environment &Env) {
+ void transfer(const CFGElement *, NonConvergingLattice &E, Environment &) {
++E.State;
}
};
@@ -162,7 +162,11 @@
static FunctionCallLattice initialElement() { return {}; }
- void transfer(const Stmt *S, FunctionCallLattice &E, Environment &Env) {
+ void transfer(const CFGElement *Elt, FunctionCallLattice &E, Environment &) {
+ auto CS = Elt->getAs<CFGStmt>();
+ if (!CS)
+ return;
+ auto S = CS->getStmt();
if (auto *C = dyn_cast<CallExpr>(S)) {
if (auto *F = dyn_cast<FunctionDecl>(C->getCalleeDecl())) {
E.CalledFunctions.insert(F->getNameInfo().getAsString());
@@ -314,7 +318,11 @@
static NoopLattice initialElement() { return {}; }
- void transfer(const Stmt *S, NoopLattice &, Environment &Env) {
+ void transfer(const CFGElement *Elt, NoopLattice &, Environment &Env) {
+ auto CS = Elt->getAs<CFGStmt>();
+ if (!CS)
+ return;
+ auto S = CS->getStmt();
auto SpecialBoolRecordDecl = recordDecl(hasName("SpecialBool"));
auto HasSpecialBoolType = hasType(SpecialBoolRecordDecl);
@@ -466,7 +474,11 @@
static NoopLattice initialElement() { return {}; }
- void transfer(const Stmt *S, NoopLattice &, Environment &Env) {
+ void transfer(const CFGElement *Elt, NoopLattice &, Environment &Env) {
+ auto CS = Elt->getAs<CFGStmt>();
+ if (!CS)
+ return;
+ auto S = CS->getStmt();
auto OptionalIntRecordDecl = recordDecl(hasName("OptionalInt"));
auto HasOptionalIntType = hasType(OptionalIntRecordDecl);
Index: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp
===================================================================
--- clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp
+++ clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp
@@ -19,10 +19,10 @@
#include "clang/AST/Stmt.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/CFG.h"
#include "clang/Analysis/FlowSensitive/DataflowAnalysis.h"
#include "clang/Analysis/FlowSensitive/DataflowEnvironment.h"
#include "clang/Analysis/FlowSensitive/DataflowLattice.h"
-#include "clang/Tooling/Tooling.h"
#include "llvm/ADT/None.h"
#include "llvm/ADT/Optional.h"
#include "llvm/ADT/StringRef.h"
@@ -123,8 +123,12 @@
return ConstantPropagationLattice::bottom();
}
- void transfer(const Stmt *S, ConstantPropagationLattice &Element,
+ void transfer(const CFGElement *E, ConstantPropagationLattice &Element,
Environment &Env) {
+ auto CS = E->getAs<CFGStmt>();
+ if (!CS)
+ return;
+ auto S = CS->getStmt();
auto matcher = stmt(
anyOf(declStmt(hasSingleDecl(varDecl(hasType(isInteger()),
hasInitializer(expr().bind(kInit)))
Index: clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp
===================================================================
--- clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp
+++ clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp
@@ -19,6 +19,7 @@
#include "clang/AST/Stmt.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/CFG.h"
#include "clang/Analysis/FlowSensitive/DataflowAnalysis.h"
#include "clang/Analysis/FlowSensitive/DataflowEnvironment.h"
#include "clang/Analysis/FlowSensitive/DataflowLattice.h"
@@ -132,8 +133,12 @@
return ConstantPropagationLattice::bottom();
}
- void transfer(const Stmt *S, ConstantPropagationLattice &Vars,
+ void transfer(const CFGElement *E, ConstantPropagationLattice &Vars,
Environment &Env) {
+ auto CS = E->getAs<CFGStmt>();
+ if (!CS)
+ return;
+ auto S = CS->getStmt();
auto matcher =
stmt(anyOf(declStmt(hasSingleDecl(
varDecl(decl().bind(kVar), hasType(isInteger()),
Index: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp
===================================================================
--- clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp
+++ clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp
@@ -11,6 +11,7 @@
#include "TestingSupport.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/CFG.h"
#include "clang/Analysis/FlowSensitive/NoopLattice.h"
#include "clang/Tooling/Tooling.h"
#include "llvm/ADT/ArrayRef.h"
@@ -117,8 +118,10 @@
static NoopLattice initialElement() { return NoopLattice(); }
- void transfer(const Stmt *S, NoopLattice &, Environment &Env) {
- M.transfer(S, Env);
+ void transfer(const CFGElement *E, NoopLattice &, Environment &Env) {
+ if (auto S = E->getAs<CFGStmt>()) {
+ M.transfer(S->getStmt(), Env);
+ }
}
private:
Index: clang/include/clang/Analysis/FlowSensitive/NoopAnalysis.h
===================================================================
--- clang/include/clang/Analysis/FlowSensitive/NoopAnalysis.h
+++ clang/include/clang/Analysis/FlowSensitive/NoopAnalysis.h
@@ -14,7 +14,7 @@
#define LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_NOOPANALYSIS_H
#include "clang/AST/ASTContext.h"
-#include "clang/AST/Stmt.h"
+#include "clang/Analysis/CFG.h"
#include "clang/Analysis/FlowSensitive/DataflowAnalysis.h"
#include "clang/Analysis/FlowSensitive/DataflowEnvironment.h"
#include "clang/Analysis/FlowSensitive/NoopLattice.h"
@@ -38,7 +38,7 @@
static NoopLattice initialElement() { return {}; }
- void transfer(const Stmt *S, NoopLattice &E, Environment &Env) {}
+ void transfer(const CFGElement *E, NoopLattice &L, Environment &Env) {}
};
} // namespace dataflow
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
