kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { + // See https://github.com/clangd/clangd/issues/1216 ---------------- tom-anders wrote: > nridge wrote: > > Does this test trigger the crash for you when run without the fix? > Yes it does, I double checked. Not sure why it didn't work for you it doesn't trigger the crash for me either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134137/new/ https://reviews.llvm.org/D134137 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits