tom-anders marked an inline comment as done.
tom-anders added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017
+TEST(CompletionTests, EmptySnippetDoesNotCrash) {
+ // See https://github.com/clangd/clangd/issues/1216
----------------
kadircet wrote:
> tom-anders wrote:
> > nridge wrote:
> > > Does this test trigger the crash for you when run without the fix?
> > Yes it does, I double checked. Not sure why it didn't work for you
> it doesn't trigger the crash for me either.
Huh, maybe this is a b
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017
+TEST(CompletionTests, EmptySnippetDoesNotCrash) {
+ // See https://github.com/clangd/clangd/issues/1216
----------------
tom-anders wrote:
> kadircet wrote:
> > tom-anders wrote:
> > > nridge wrote:
> > > > Does this test trigger the crash for you when run without the fix?
> > > Yes it does, I double checked. Not sure why it didn't work for you
> > it doesn't trigger the crash for me either.
> Huh, maybe this is a b
Hmm could be a build type thing? I ran the tests for a Debug build, maybe it's
different in Release?
Maybe we could also ask the author of the GitHub issue to check if it fixes the
crash for them?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134137/new/
https://reviews.llvm.org/D134137
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
