[PATCH] D124540: [clang][dataflow] Perform structural comparison of indirection values in `join`.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:357-365 +// FIXME: add unit tests that cover this statement. +if (auto *IndVal1 = dyn_cast(Val)) { + auto *IndVal2 = cast(It->second); +

[PATCH] D117112: [AArch64] Support for Ampere1 core

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I don't know the details of the scheduling latencies for the core, but this looks perfectly sensible. There are a few comments inline, but other than those this patch LGTM. ==

[PATCH] D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap"

steakhal added a comment. I'm not comfortable with reverting this. We depend on taint capabilities downstream, thus we would rather help fixing the underlying issue. Do you have a reproducer for the crash in any form? I would take it from there. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

owenpan updated this revision to Diff 425710. owenpan added a comment. Also checks the token before `*` and adds a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124589/new/ https://reviews.llvm.org/D124589 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/F

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

owenpan added a comment. In D124589#3479241 , @curdeius wrote: > Looks more or less correct, but I am afraid that this change may misbehave in > some rare cases. > Consider `*[](auto *x) { return x; }();`, so an immediately invoked lambda > returning a

[PATCH] D123605: [WIP][Sema][SVE] Move/simplify Sema testing for SVE ACLE builtins

RosieSumpter added inline comments. Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_imm_n.cpp:25 +{ + // expected-error-re@+1 3 {{argument value {{[0-9]+}} is outside the valid range [0, 7]}} + EXPAND_XZM_FUNC(SVE_ACLE_FUNC(svqshlu,_n_s8,,), pg, svundef_s8(), -1)

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

foad accepted this revision. foad added a reviewer: t-tye. foad added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124536/new/ https://reviews.llvm.org/D124536

[PATCH] D123605: [WIP][Sema][SVE] Move/simplify Sema testing for SVE ACLE builtins

RosieSumpter marked an inline comment as done. RosieSumpter added inline comments. Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_imm_lane.cpp:151-152 +{ + // expected-error-re@+1 {{argument value {{[0-9]+}} is outside the valid range [0, 1]}} + SVE_ACLE_FUNC(s

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

nikic added a comment. This change seems to have broken switching to a branch before the commit completely. The only way I was able to recover my git checkout is to comment out the `* text=auto` line and then run `git reset --hard`, otherwise the crlf.cpp files always show up as changed. Repo

[PATCH] D124532: [AST] Improve traversal of concept requirements

ilya-biryukov updated this revision to Diff 425713. ilya-biryukov added a comment. - Mention the `AutoType` traversal does not traverse the constrained concept decl anymore and add a test for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124532/

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. It also seems weird to me that a file that relies on CRLF line endings is checked in explicitly with LF line endings. A better approach IMHO would be to check it in as binary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] e8cc749 - Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C"

Author: Krasimir Georgiev Date: 2022-04-28T11:00:32+02:00 New Revision: e8cc7490d23477233d21c72923a4f8ea43bfbbc0 URL: https://github.com/llvm/llvm-project/commit/e8cc7490d23477233d21c72923a4f8ea43bfbbc0 DIFF: https://github.com/llvm/llvm-project/commit/e8cc7490d23477233d21c72923a4f8ea43bfbbc0.d

[clang] be656df - [clang-format] add a regression test for include sorting

Author: Krasimir Georgiev Date: 2022-04-28T11:02:14+02:00 New Revision: be656df18721dc55a1de2eea64a3f73b6afa29a2 URL: https://github.com/llvm/llvm-project/commit/be656df18721dc55a1de2eea64a3f73b6afa29a2 DIFF: https://github.com/llvm/llvm-project/commit/be656df18721dc55a1de2eea64a3f73b6afa29a2.d

[PATCH] D124513: [clang-format] add a regression test for include sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe656df18721: [clang-format] add a regression test for include sorting (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

jansvoboda11 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3300 - Decl *ActOnObjCContainerStartDefinition(Decl *IDecl); + void ActOnObjCContainerStartDefinition(ObjCContainerDecl *IDecl); vsapsai wrote: > jansvoboda11 wrote: > > Why the

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

jansvoboda11 added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:528 + + //FIXME: Hash other interface-specific elements like protocols, etc. + Is this important to implement now, or are you fine leaving this be for the time being? Repository: rG L

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

jansvoboda11 added a comment. In D124287#3476040 , @vsapsai wrote: > In D124287#3474369 , @jansvoboda11 > wrote: > >> This sounds reasonable to me. What use-cases does `ASTStructuralEquivalence` >> fit better th

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

iains added a comment. In D124287#3479484 , @jansvoboda11 wrote: > In D124287#3476040 , @vsapsai wrote: > >> In D124287#3474369 , @jansvoboda11 >> wrote: >> >>> This sou

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3342 + "public:\n" + " std::unique_ptr b() { return nullptr; }\n" + "\n" How about `int const *`, `const int*`? Is `const` & co. a simple

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

hans added a comment. Herald added a project: All. This seems to have caused a strange indentation problem, see https://github.com/llvm/llvm-project/issues/55161 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D1

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I currently don't know exactly how `isSimpleTypeSpecifier` works, but what is with `auto x = Foo * []{return 5;}();` `auto x = Foo * *[]{static y = 5; return &y;}();`

[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

jansvoboda11 added a comment. LGTM in general, with some suggestions in-line. Besides those, I think we should be able to remove `PPSkipMappings` from the condition in `MinimizedVFSFile::create` (`DependencyScanningFilesystem.cpp`). Comment at: clang/lib/Tooling/DependencySc

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. Feel free to revert and add a regression test please. I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 ___ cfe-commit

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

jansvoboda11 added a comment. In D124287#3479493 , @iains wrote: > Presumably `ASTStructuralEquivalence` can also be used as a tie-breaker in > the case of a hash collision? Ah, that's a good point. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 425726. philipp.tomsich added a comment. - additional tab -> space conversion (hopefully, I have emacs configured correctly now) - added SBSS and MTE to the SubtargetFeatures - inserted AMpere1 in the subtarget enum in alphabetical order Repository:

[PATCH] D69740: [profile] Support counter relocation at runtime

fhahn added inline comments. Herald added subscribers: abrachet, MaskRay. Herald added a project: All. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:673 +auto *Add = Builder.CreateAdd(Builder.CreatePtrToInt(Addr, Int64Ty), LI); +Addr = Builder.CreateI

[PATCH] D124532: [AST] Improve traversal of concept requirements

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b833d4086ab: [AST] Improve traversal of concepts and concept requirements (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124532/

[clang-tools-extra] 2b833d4 - [AST] Improve traversal of concepts and concept requirements

Author: Ilya Biryukov Date: 2022-04-28T09:33:26Z New Revision: 2b833d4086aba3c0fca480549309af54bfdd8e2e URL: https://github.com/llvm/llvm-project/commit/2b833d4086aba3c0fca480549309af54bfdd8e2e DIFF: https://github.com/llvm/llvm-project/commit/2b833d4086aba3c0fca480549309af54bfdd8e2e.diff LOG:

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

hans added a comment. In D116527#3479509 , @curdeius wrote: > Feel free to revert and add a regression test please. I'll take a look. Since this patch landed a couple of months back, I don't think we need to rush to revert it. Repository: rG LLVM Gi

[clang] bf0bcb5 - [Analyzer] Remove undefined function

Author: Marco Antognini Date: 2022-04-28T11:54:40+02:00 New Revision: bf0bcb5e539b1177cb2023691a13635e8cab5d2f URL: https://github.com/llvm/llvm-project/commit/bf0bcb5e539b1177cb2023691a13635e8cab5d2f DIFF: https://github.com/llvm/llvm-project/commit/bf0bcb5e539b1177cb2023691a13635e8cab5d2f.dif

[PATCH] D124461: [Analyzer] Remove undefined function

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf0bcb5e539b: [Analyzer] Remove undefined function (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124461/new/ https://reviews.llvm.

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam added a comment. In D124525#3478469 , @yaxunl wrote: > need a test for the generated registration code Yes, I will add tests. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1161 -LinkedImages.push_b

[PATCH] D124348: [1/2][RISCV]Add Intrinsics for B extension in Clang

joker881 added a comment. In D124348#3470612 , @craig.topper wrote: > The "B extension" terminology no longer exists. And I decide to ctz_32 and ctz_64 like clz. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D123605: [WIP][Sema][SVE] Move/simplify Sema testing for SVE ACLE builtins

paulwalker-arm added inline comments. Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_imm_n.cpp:25 +{ + // expected-error-re@+1 3 {{argument value {{[0-9]+}} is outside the valid range [0, 7]}} + EXPAND_XZM_FUNC(SVE_ACLE_FUNC(svqshlu,_n_s8,,), pg, svundef_s8(), -

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster created this revision. MForster added a reviewer: labath. Herald added a subscriber: jdoerfert. Herald added a project: All. MForster requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These automatic conversions lead to i

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:328 const LangOptions &LangOpts) const { - // FIXME: Make the checker useful on C++ code. - if (LangOpts.CPlusPlus) -return false; - - return true; + return LangO

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster updated this revision to Diff 425742. MForster added a comment. Force-add crlf.cpp(.expected) with CRLF line endings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 Files: clang-tools-extra/te

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. I'm proposing this: D124606 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124563/new/ https://reviews.llvm.org/D124563 ___ cfe-commits mailin

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added a comment. Ping for the other reviewers in case they have thoughts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.llvm.org/D124258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D123831: [clang][extract-api] Use relative includes

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:134 +if (!SpelledFilename.empty()) + return SpelledFilename.str(); + zixuw wrote: > zixuw wrote: > > zixuw wrote: > > > One problem I can see in this right now is

[PATCH] D123605: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter added inline comments. Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_imm_n.cpp:25 +{ + // expected-error-re@+1 3 {{argument value {{[0-9]+}} is outside the valid range [0, 7]}} + EXPAND_XZM_FUNC(SVE_ACLE_FUNC(svqshlu,_n_s8,,), pg, svundef_s8(), -1)

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

labath added a comment. I believe (based on some similar issues I was solving in lldb) that `-text` instead of `binary` is sufficient to prevent git from fidlling with the contents, while maintaining the ability to diff the files. Other than that, I am in favour of this approach, but I'd recomm

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster updated this revision to Diff 425745. MForster added a comment. Use `-text` instead of `binary`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 Files: clang-tools-extra/test/.gitattributes c

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:246 IRBuilder<> Builder(BasicBlock::Create(C, "entry", Func)); + // Create calls to __tgt_register_image_info for each image + auto *NullPtr = llvm::ConstantPointerNull::get(Builde

[clang-tools-extra] b1f1688 - [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

Author: Bernhard Manfred Gruber Date: 2022-04-28T13:49:18+02:00 New Revision: b1f1688e90b22dedc829f5abc9a912f18c034fbc URL: https://github.com/llvm/llvm-project/commit/b1f1688e90b22dedc829f5abc9a912f18c034fbc DIFF: https://github.com/llvm/llvm-project/commit/b1f1688e90b22dedc829f5abc9a912f18c03

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

whisperity added a comment. D'oh! I made a mistake when copying the URL and accidentally associated the commit with D12306 instead of D123065 ... Anyhow, this was committed in rGb1f1688e90b22dedc829f5abc9a912f18c034fbc

[PATCH] D124551: [Driver] Add f16 support to -mrecip parsing.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. AFAIK, these FP reciprocal options have never been officially documented. Would that go under here: https://clang.llvm.org/docs/UsersManual.html#controlling-code-generation ? Repositor

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

jchlanda added a comment. In D124382#3472888 , @Anastasia wrote: > > Can you provide an example of where it could be useful? Note that I feel that > such functionality could be implemented on top of full implementation of > target specific address spa

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. In D124563#3479373 , @nikic wrote: > This change seems to have broken switching to a branch before the commit > completely. The only way I was able to recover my git checkout is to comment > out the `* text=auto` line and t

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3184 +continue; + // We reject AT_LifetimeBound and AT_AnyX86NoCfCheck, even though they + // are type attributes, because we historically haven't allowed these -

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

ilya-biryukov added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

ilya-biryukov added a comment. NIT: change the commit message to say `-text` instead of `binary` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 ___ cfe-commits

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. As a temporary workaround for switching between branches, just add a local file `clang-tools-extra/test/clang-apply-replacements/.gitattributes` with contents: Inputs/crlf/crlf.cpp binary Inputs/crlf/crlf.cpp.expected binary This will remove all kinds of filter

[clang-tools-extra] 4aba5fa - Use `-text` git attribute instead of `text eol=...`

Author: Michael Forster Date: 2022-04-28T14:27:29+02:00 New Revision: 4aba5fa774821279c2e2e26dd6ed6e1c6a151044 URL: https://github.com/llvm/llvm-project/commit/4aba5fa774821279c2e2e26dd6ed6e1c6a151044 DIFF: https://github.com/llvm/llvm-project/commit/4aba5fa774821279c2e2e26dd6ed6e1c6a151044.dif

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aba5fa77482: Use `-text` git attribute instead of `text eol=...` (authored by MForster). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster added a comment. In D124606#3479798 , @ilya-biryukov wrote: > NIT: change the commit message to say `-text` instead of `binary` Ah, sorry, saw this too late... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

MForster added a comment. In D124606#3479805 , @MForster wrote: > In D124606#3479798 , @ilya-biryukov > wrote: > >> NIT: change the commit message to say `-text` instead of `binary` > > Ah, sorry, saw this too la

[clang-tools-extra] 5e4a77f - [clangd] Record latency for ASTSignal derivation

Author: Kadir Cetinkaya Date: 2022-04-28T14:34:39+02:00 New Revision: 5e4a77f0c4e7e8122e8ee3a15fff0971f5db2244 URL: https://github.com/llvm/llvm-project/commit/5e4a77f0c4e7e8122e8ee3a15fff0971f5db2244 DIFF: https://github.com/llvm/llvm-project/commit/5e4a77f0c4e7e8122e8ee3a15fff0971f5db2244.dif

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. > In D124563#3479405 , @MForster > wrote: > >> It also seems weird to me that a file that relies on CRLF line endings is >> checked in explicitly with LF line endings. A better approach IMHO would be >> to check it in as binary

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3479051 , @junaire wrote: >> In general, my concern with the this patch is that it loses test coverage by >> specifying an explicit language mode. We typically prefer to fix the tests >> so that they can work in

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 425753. balazske added a comment. Applied the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files: clang-tools-extra/clang-tidy/bugprone/SignalH

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. @hubert.reinterpretcast, Sorry to have missed providing a summary. In most cases, shadowing a declaration of a local variable should be avoided to prevent making others confused and mistakes because we need to figure out the boundaries of the declaration. In this ca

[PATCH] D124487: [HLSL] Adjust access specifier behavior

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from whitespace changes. Comment at: clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1 - -// This file intentionally uses a CRL

[clang] f2b31f0 - re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".""

Author: Devin Jeanpierre Date: 2022-04-28T14:53:59+02:00 New Revision: f2b31f06b79a6cfb7eb3146dfc1d514da52142e9 URL: https://github.com/llvm/llvm-project/commit/f2b31f06b79a6cfb7eb3146dfc1d514da52142e9 DIFF: https://github.com/llvm/llvm-project/commit/f2b31f06b79a6cfb7eb3146dfc1d514da52142e9.di

[PATCH] D123059: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".""

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b31f06b79a: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable""."" (authored by devin.jeanpierre, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

erichkeane added a comment. In D122920#3479192 , @yihanaa wrote: >> While we'd usually be happy to take the fix-in-hand and apply it, part of >> the discussion on the other thread is whether to remove >> `__builtin_dump_struct` entirely. Because of that

[PATCH] D123605: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter closed this revision. RosieSumpter added a comment. Commit: f7068c82a2560d97bf9826db1e917f931e887017 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123605/new/ https://reviews.llvm.org/D123605 __

[PATCH] D123958: [randstruct] Randomize all elements of a record

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/unittests/AST/RandstructTest.cpp:368 +int h; +char name[0]; +} __attribute__((randomize_layout)); v

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

aaron.ballman added a comment. In D122920#3479884 , @erichkeane wrote: > In D122920#3479192 , @yihanaa wrote: > >>> While we'd usually be happy to take the fix-in-hand and apply it, part of >>> the discussion on

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. CGBuiltin.cpp changes look good enough to me, but please add the newline aaron requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D124611: [RISCV][Clang] add more tests for clang driver. (NFC)

khchen created this revision. khchen added reviewers: craig.topper, asb, luismarques. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. In D124563#3479819 , @MForster wrote: > See D124606 . `-text` seems to be the right > compromise. To quote an earlier comment from this thread: In D124563#3478625

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: rnk. Herald added a reviewer: shafik. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added subscribers: smeenai, aaronpuchert. aaronpuchert added a comment. I think this change broke again what D97625 was trying to fix. These are text files and we want them to keep the specified line endings regardless of the local git configuration

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3477115 , @steakhal wrote: > Although gcc (and probably clang too) allows specifying > `__attribute__((noinline))` at any declaration (by merging //compatible// > attributes), I would prefer not to repeat ourselves

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

tahonermann added a comment. > Ping for the other reviewers in case they have thoughts. I took a gander and it all looks good to me. I added one comment regarding a test change. Comment at: clang/unittests/AST/SourceLocationTest.cpp:135-145 TEST(ParmVarDecl, KNRLocation) {

[PATCH] D124614: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini requested review of this revision. Herald added a project:

[PATCH] D124614: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini abandoned this revision. mantognini added a comment. Ran wrong `arc` command... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124614/new/ https://reviews.llvm.org/D124614 ___ cfe-commits maili

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

labath added inline comments. Comment at: clang-tools-extra/test/.gitattributes:7-15 +clang-apply-replacements/ClangRenameClassReplacements.cpp -text +clang-apply-replacements/Inputs/basic/basic.h -text +clang-apply-replacements/Inputs/format/no.cpp -text +clang-apply-replacement

[clang] 8854d12 - [PS5] Disable exceptions by default

Author: Paul Robinson Date: 2022-04-28T07:16:16-07:00 New Revision: 8854d1244c905b20dd62db3a7430043477e1ad3b URL: https://github.com/llvm/llvm-project/commit/8854d1244c905b20dd62db3a7430043477e1ad3b DIFF: https://github.com/llvm/llvm-project/commit/8854d1244c905b20dd62db3a7430043477e1ad3b.diff

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini updated this revision to Diff 425772. mantognini added a comment. Remove LLVM_DUMP_METHOD from definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ https://reviews.llvm.org/D124462 Files: clang/lib/StaticAnalyzer/Check

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

ilya-biryukov added a comment. In D124606#3480012 , @aaronpuchert wrote: > I think this change broke again what D97625 > was trying to fix. These are text files and we want them to keep the > specified line endings reg

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

ilya-biryukov added a comment. @labath, ah, sorry, you beat me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke marked an inline comment as done. Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. In D124556#3479833 , @ken-matsui wrote: > @hubert.reinterpretcast, > > Sorry to have missed providing a summary. You can still provide one by using the "Edit Revision" link. I suggest something like: Prevents con

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

MForster added a comment. Well, I tested this on Windows. :-) forster@Desktop MINGW64 ~/src/llvm-project/clang-tools-extra/test (main) $ git reset --hard 4aba5fa774821279c2e2e26dd6ed6e1c6a151044 && grep 'crlf.cpp ' .gitattributes && file clang-apply-replacements/Inputs/crlf/crlf.cpp HEAD i

[clang] 451c557 - [PS5] Set default cpu to znver2, with no tuning

Author: Paul Robinson Date: 2022-04-28T07:50:37-07:00 New Revision: 451c5578b834fe3aca4e495aaf6a2f32639e86a6 URL: https://github.com/llvm/llvm-project/commit/451c5578b834fe3aca4e495aaf6a2f32639e86a6 DIFF: https://github.com/llvm/llvm-project/commit/451c5578b834fe3aca4e495aaf6a2f32639e86a6.diff

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

yaxunl added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:98-104 + // struct __tgt_image_info { + // int32_t version; + // int32_t image_number; + // int32_t number_images; + // char* offload_arch; + // char* target_compile_opts

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. In D124563#3479990 , @aaronpuchert wrote: > In D124563#3478625 , @smeenai wrote: > >> I *think* this would mean that if you're on Windows and have `core.autocrlf` >> set to `input`, whe

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 425780. qiongsiwu1 added reviewers: ye-luo, rastogishubham. qiongsiwu1 added a comment. Herald added a subscriber: sstefan1. This patch is updated to address - https://github.com/llvm/llvm-project/issues/55002 @ye-luo - configuration issue with xcode @rast

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 425782. martong added a comment. - Add an option to config the inlining mode during the first phase - Change the `ctu-main.c[pp]` tests to have a RUN line with this new config option that mimics the old ctu implementation's behavor. - Change the on-demand-par

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 425784. martong added a comment. - Chosing the correct baseline this time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123773/new/ https://reviews.llvm.org/D123773 Files: clang/include/clang/CrossTU/CrossTr

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added a comment. Fair enough, but don't we want to enforce LF or CRLF, respectively? An editor could inadvertently change the line endings, and someone might not notice before commiting. Explicitly specifying the right line endings gives us the proper line endings even if some edit

[clang] 501cc4a - [PS5] Rename a test to reflect its new purpose

Author: Paul Robinson Date: 2022-04-28T08:07:50-07:00 New Revision: 501cc4ae304f29e392a2b7e21c316e3abf954daa URL: https://github.com/llvm/llvm-project/commit/501cc4ae304f29e392a2b7e21c316e3abf954daa DIFF: https://github.com/llvm/llvm-project/commit/501cc4ae304f29e392a2b7e21c316e3abf954daa.diff

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 425785. jhuber6 added a comment. Ping and update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Dr

[PATCH] D124487: [HLSL] Adjust access specifier behavior

beanz added inline comments. Comment at: clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1 - -// This file intentionally uses a CRLF newlines! - -void foo() { - int *x = 0; -} + +// This file intentionally uses a CRLF newlines! aaron.ballma

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong added inline comments. Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:23 +// FIXME On-demand ctu should be tested in the very same file that we have for +// the PCH version, but with a different a different verify prefix (e.g. +// -verfiy=on-demanc-ctu) -

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. @hubert.reinterpretcast, Thank you for your suggestion! I’ve updated the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 _

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added a comment. Also I still don't understand what specifically this is fixing. What exactly was wrong about the previous configuration? The commit message talks about "various workflows" but which workflows are that? Does that mean no one can use `.gitattributes` with something e

[clang] 062317f - [HIP] Add HIP runtime library arguments for linker

Author: Yaxun (Sam) Liu Date: 2022-04-28T11:12:23-04:00 New Revision: 062317f72ebfc19b0f3733b4181bb09344707653 URL: https://github.com/llvm/llvm-project/commit/062317f72ebfc19b0f3733b4181bb09344707653 DIFF: https://github.com/llvm/llvm-project/commit/062317f72ebfc19b0f3733b4181bb09344707653.dif

  1   2   3   >