aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/unittests/AST/RandstructTest.cpp:368 + int h; + char name[0]; + } __attribute__((randomize_layout)); ---------------- void wrote: > aaron.ballman wrote: > > Can you add a test where the last field is `char name[1];` and another one > > for `char name[];` so that we have full coverage there? > The `name[]` is above this test. The `name[1]` is due to a copy-paste error > (oops). Fixed. Ah, good call on `name[]`, I missed that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits