MForster added a comment.

> In D124563#3479405 <https://reviews.llvm.org/D124563#3479405>, @MForster 
> wrote:
>
>> It also seems weird to me that a file that relies on CRLF line endings is 
>> checked in explicitly with LF line endings. A better approach IMHO would be 
>> to check it in as binary.
>
> These are all text files though, not binaries. Checking it in as binary will 
> not show any diffs.

See D124606 <https://reviews.llvm.org/D124606>. `-text` seems to be the right 
compromise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124563/new/

https://reviews.llvm.org/D124563

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to