MForster added a comment.

In D124563#3479990 <https://reviews.llvm.org/D124563#3479990>, @aaronpuchert 
wrote:

> In D124563#3478625 <https://reviews.llvm.org/D124563#3478625>, @smeenai wrote:
>
>> I *think* this would mean that if you're on Windows and have `core.autocrlf` 
>> set to `input`, when you commit changes to this files, Git will convert them 
>> back to LF line endings. Not 100% sure of that though.
>
> Which convinced me that D97625 <https://reviews.llvm.org/D97625> was right: 
> we do want the line endings to remain CRLF, and not have them accidentally 
> destroyed. With `-text` we say that we don't care, which is not true.

I verified manually on Windows that the behavior is still what we want. D124606 
<https://reviews.llvm.org/D124606> explains that `-text` means that 
`core.autocrlf` is ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124563/new/

https://reviews.llvm.org/D124563

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to