[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D123874#3454723 , @MaskRay wrote: >> Add support to clang (-Wa,-generate-unused-section-symbols={yes|no}) and >> llvm-mc. > > > >> This

[PATCH] D124215: [clang-format][NFC] Use isComment() in setCommentLineLevels()

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Thanks for the clean up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124215/new/ https://reviews.llvm.org/D124215 ___

[PATCH] D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

steffenlarsen added a comment. In D100394#3466316 , @nirvedhmeshram wrote: > Hello, I was interested in using `llvm.nvvm.cp.async.cg.shared.global.8` and > `llvm.nvvm.cp.async.cg.shared.global.4` and was wondering if there is some > fundamental reason

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall marked an inline comment as done. sammccall added a subscriber: hliao. sammccall added a comment. In D123668#3466376 , @maryammo wrote: > It seems it breaks the following builds: > https://lab.llvm.org/buildbot/#/builders/121/builds/18618 > htt

[clang] 5c6a146 - [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

Author: Iain Sandoe Date: 2022-04-22T09:24:29+01:00 New Revision: 5c6a14649843ccd2c50ed9e2fcacaa8ebd820ae8 URL: https://github.com/llvm/llvm-project/commit/5c6a14649843ccd2c50ed9e2fcacaa8ebd820ae8 DIFF: https://github.com/llvm/llvm-project/commit/5c6a14649843ccd2c50ed9e2fcacaa8ebd820ae8.diff L

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c6a14649843: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}… (authored by iains). Herald added a subscriber: MaskRay. Re

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett abandoned this revision. DavidSpickett added a comment. People are leaning toward fixes on the buildkite side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 ___

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This is a followup cleanup of 1234b1c6d8113d50beef5801be607ad1d502b2f7

[PATCH] D124239: [analyzer] Fix ValistChecker false-positive involving symbolic pointers

steakhal created this revision. steakhal added reviewers: NoQ, martong, xazax.hun, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet updated this revision to Diff 424417. kadircet added a comment. Get rid of shrink_to_fit as PostingList representation doesn't really make a copy of the vector, but rather build a new representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi updated this revision to Diff 424420. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/ https://reviews.llvm.org/D124006 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-struct-align.cpp Index: clang/test/CodeGenCXX/debug-info-struct-align.

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-struct-align.cpp:11 +} __attribute__((aligned(1))); +struct MyType mt; + dblaikie wrote: > You can drop the "struct" here and from other references to these types (in > mt1/mt2 and the

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), + std::move(E.second)); +TrigramDocs.clear(); the move here does nothing,

[PATCH] D124242: [Frontend] shrink in-memory PCH buffers to fit

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After building a PCH, the vector capacity is on average ~1/3 unused. If we're goin

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ItaniumMangle.cpp:2206 switch (TN.getKind()) { case TemplateName::QualifiedTemplate: +TD = TN.getAsQualifiedTemplateName() -

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, martong, steakhal, balazske, vsavchenko. zukatsinadze added a project: clang. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xaza

[clang] b09ba42 - Bug 51277: [DWARF] DW_AT_alignment incorrect when

Author: Ying Yi Date: 2022-04-22T12:15:00+01:00 New Revision: b09ba42620768c0092b20cf526a30b14752a5dc9 URL: https://github.com/llvm/llvm-project/commit/b09ba42620768c0092b20cf526a30b14752a5dc9 DIFF: https://github.com/llvm/llvm-project/commit/b09ba42620768c0092b20cf526a30b14752a5dc9.diff LOG:

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb09ba4262076: Bug 51277: [DWARF] DW_AT_alignment incorrect when (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. Hi, unfortunately for some reason it doesn't play well with coroutines HALO. There is regression seen on Gor's Nishanov classical code snippet: https://godbolt.org/z/PKMxqq4Gr I'm checking IR to find out more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

hans accepted this revision. hans added inline comments. Comment at: clang/docs/ReleaseNotes.rst:175 - Remove anonymous tag locations. - Beautify dump format, add indent for nested struct and struct members. +- Previously disabled sanitizer options now enabled by default --

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When exprs are written unabbre

[PATCH] D123300: [Clang] Enable opaque pointers by default

markus added a comment. We have run into a slight performance degrading issue with our downstream target. The situation is that we relay on the "consthoist" pass with option "-consthoist-gep=1" to factor out the common parts of GEP expresseions to reduce the number of symbol references. For exa

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall updated this revision to Diff 424443. sammccall added a comment. Don't hardcode 5 dependence bits in abbreviaions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250 Files: clang/lib/Serializatio

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. In D123300#3467278 , @markus wrote: > We have run into a slight performance degrading issue with our downstream > target. The situation is that we relay on the "consthoist" pass with option > "-consthoist-gep=1" to factor out the

[PATCH] D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124127/new/ https://reviews.llvm.org/D124127

[PATCH] D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a question (if we can't use `emplace_back()` the code is still fine). Comment at: clang/lib/Analysis/ThreadSafety.cpp:911-919 +UnderlyingMu

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup here! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124033/new/ https://reviews.llvm.org/D124033 __

[clang] 8dbc6b5 - Revert "[randstruct] Check final randomized layout ordering"

Author: Nico Weber Date: 2022-04-22T08:27:32-04:00 New Revision: 8dbc6b560055ff5068ff45b550482ba62c36b5a5 URL: https://github.com/llvm/llvm-project/commit/8dbc6b560055ff5068ff45b550482ba62c36b5a5 DIFF: https://github.com/llvm/llvm-project/commit/8dbc6b560055ff5068ff45b550482ba62c36b5a5.diff LO

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Reverted in 8dbc6b560055ff5068ff45b550482ba62c36b5a5 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

hokein updated this revision to Diff 424446. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124238/new/ https://reviews.llvm.org/D124238 Files: clang/include/clang/

[clang] 864752c - [AST] QualifiedTemplateName::getTemplateDecl cleanup.

Author: Haojian Wu Date: 2022-04-22T14:28:48+02:00 New Revision: 864752cfeba445652b6ee0e040da366894a86c88 URL: https://github.com/llvm/llvm-project/commit/864752cfeba445652b6ee0e040da366894a86c88 DIFF: https://github.com/llvm/llvm-project/commit/864752cfeba445652b6ee0e040da366894a86c88.diff LO

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG864752cfeba4: [AST] QualifiedTemplateName::getTemplateDecl cleanup. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Thanks! Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 updated this revision to Diff 424449. jhuber6 added a comment. Moving some stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm.org/D124220 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/

[clang] f693280 - [cc1as] Add support for emitting the build version load command for -darwin-target-variant

Author: Byoungchan Lee Date: 2022-04-22T08:38:07-04:00 New Revision: f69328049e9e7fde7a314de785c76c1b93e069b2 URL: https://github.com/llvm/llvm-project/commit/f69328049e9e7fde7a314de785c76c1b93e069b2 DIFF: https://github.com/llvm/llvm-project/commit/f69328049e9e7fde7a314de785c76c1b93e069b2.diff

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

This revision was automatically updated to reflect the committed changes. Closed by commit rGf69328049e9e: [cc1as] Add support for emitting the build version load command for -darwin… (authored by bc-lee, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The o

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

jhuber6 added a comment. Is this really the cause? `nvptx::assemble` should call `createOutputFile` which makes a temp file to output to that is added to `TempFiles`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.o

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 added a comment. In D124253#3467375 , @jhuber6 wrote: > Is this really the cause? `nvptx::assemble` should call `createOutputFile` > which makes a temp file to output to that is added to `TempFiles`. Hmm, that's interesting. After adding

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), + std::move(E.second)); +TrigramDocs.clear(); sammccall wrote: > the move h

[PATCH] D124199: [randstruct] Check final randomized layout ordering

DavidSpickett added a comment. We (Linaro) also got the same failure: https://lab.llvm.org/buildbot/#/builders/186/builds/5626 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork

john.brawn created this revision. john.brawn added reviewers: ldionne, Mordante, michaelplatings. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Currently check_a

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins for the new OpenCL ex

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

martong added a comment. I'd like to have a guarantee that if `Opts.ShouldSupportSymbolicIntegerCasts` is set to `true` then the `SymboCast` is produced both for the scoped and the unscoped enums. Could you please have an additional lit test for that? At some point we'd like to make `ShouldSupp

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. The issue is in `clang/lib/Driver/ToolChains/Cuda.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.org/D124253 ___

[clang] 4c4ff00 - [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

Author: Iain Sandoe Date: 2022-04-22T14:14:19+01:00 New Revision: 4c4ff004a2702b9b7538efd569bb621a5efac8f3 URL: https://github.com/llvm/llvm-project/commit/4c4ff004a2702b9b7538efd569bb621a5efac8f3 DIFF: https://github.com/llvm/llvm-project/commit/4c4ff004a2702b9b7538efd569bb621a5efac8f3.diff L

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c4ff004a270: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header= (authored by iains). Changed prior to commit: https://reviews.llvm.org/D121589?vs=418220&id=424459#toc Repository: r

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), + std::move(

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

erichkeane added a comment. I generally just question the usefulness of this. Despite its shortcomings, the 'dump struct' has the capability of runtime introspection into a type, whereas this seems to require that the user 'know' a significant amount about the type that they are introspecting

[PATCH] D86351: WIP: llvm-buildozer

aganea added inline comments. Comment at: llvm/lib/Analysis/MemorySSA.cpp:89 #ifdef EXPENSIVE_CHECKS -bool llvm::VerifyMemorySSA = true; +LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true; #else arsenm wrote: > Do command line flags like this really need to b

[PATCH] D123300: [Clang] Enable opaque pointers by default

markus added a comment. In D123300#3467309 , @nikic wrote: > Sounds reasonable in general -- though isn't this a pre-existing problem > you'd see if you simply had multiple loads from the same global (without any > GEP)? Looking at the current ConstantH

[PATCH] D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124132/new/ https://reviews.llvm.org/D124132

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added a comment. Some quick comments... I didn't even bother opening the tests besides checking on functionality, so hopefully those are ok too :D Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning op

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

StailGot created this revision. StailGot added a project: clang-format. Herald added a project: All. StailGot requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for https://github.com/llvm/llvm-project/issues/47624 Used token for counting

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 424470. steakhal added a comment. Added two new RUN lines, demonstrating the behavior of `support-symbolic-integer-casts={true,false}`. Also refined the match string to be less fuzzy. It helps to grasp the difference between the expectations. CHANGES SINC

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. Just one more thing regarding this: In D123300#3467165 , @yurai007 wrote: > Hi, unfortunately for some reason it doesn't play well with coroutines HALO. > There is regression seen on Gor's Nishanov classical code snippet: > h

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi created this revision. ishaangandhi added reviewers: nridge, sammccall. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ishaangandhi requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This

[PATCH] D124239: [analyzer] Fix ValistChecker false-positive involving symbolic pointers

steakhal updated this revision to Diff 424478. steakhal added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124239/new/ https://reviews.llvm.org/D124239 Files: clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp clang/test/Analysis/valist-uninitialized-no-undef.

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. In D123300#3467615 , @yurai007 wrote: > Just one more thing regarding this: > > In D123300#3467165 , @yurai007 > wrote: > >> Hi, unfortunately for some reason it doesn't play well with coro

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + erichkeane wrote: > This name seems inverse of wha

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + cor3ntin wrote: > erichkeane wrote: > > This nam

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

erichkeane added a comment. Herald added a subscriber: StephenFan. Note the error I found with this: https://github.com/llvm/llvm-project/issues/55038 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 __

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet updated this revision to Diff 424489. kadircet marked 2 inline comments as done. kadircet added a comment. Copy-assign to empty containers rather than clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124240/new/ https://reviews.llvm.or

[clang-tools-extra] 2efccf5 - [clangd][NFC] Reduce memory usage while building dex

Author: Kadir Cetinkaya Date: 2022-04-22T17:44:47+02:00 New Revision: 2efccf5166f4dd7d188eea2de4f4b7f50b64e477 URL: https://github.com/llvm/llvm-project/commit/2efccf5166f4dd7d188eea2de4f4b7f50b64e477 DIFF: https://github.com/llvm/llvm-project/commit/2efccf5166f4dd7d188eea2de4f4b7f50b64e477.dif

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2efccf5166f4: [clangd][NFC] Reduce memory usage while building dex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze updated this revision to Diff 424493. zukatsinadze added a comment. fix clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 424497. steakhal added a comment. Added the missing `-verify` flag for the new RUN line. Also, add an elaborate description in the test for explaining the situation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85528/new/ https://reviews.llvm.org/

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added a comment. In D124221#3467467 , @erichkeane wrote: > I generally just question the usefulness of this. Despite its shortcomings, > the 'dump struct' has the capability of runtime introspection into a type, > whereas this seems to require

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3466027 , @joaomoreira wrote: > I played a little bit with kcfi and here are some thoughts: > > - under -Os I saw functions being inlined, regardless of the source code > calling them indirectly. In these scenari

[clang] c9e7eec - [clang-format][NFC] Use isComment() in setCommentLineLevels()

Author: owenca Date: 2022-04-22T09:21:28-07:00 New Revision: c9e7eec7bc41e9cb86e01acd5c91faa5c9ee0bf1 URL: https://github.com/llvm/llvm-project/commit/c9e7eec7bc41e9cb86e01acd5c91faa5c9ee0bf1 DIFF: https://github.com/llvm/llvm-project/commit/c9e7eec7bc41e9cb86e01acd5c91faa5c9ee0bf1.diff LOG: [

[PATCH] D124215: [clang-format][NFC] Use isComment() in setCommentLineLevels()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9e7eec7bc41: [clang-format][NFC] Use isComment() in setCommentLineLevels() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wimplicit-int`` in C89 mode will

[clang-tools-extra] e9a902c - Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'"""

Author: Christopher Di Bella Date: 2022-04-22T16:37:20Z New Revision: e9a902c7f755a378e197c4b246a32859c0ee162d URL: https://github.com/llvm/llvm-project/commit/e9a902c7f755a378e197c4b246a32859c0ee162d DIFF: https://github.com/llvm/llvm-project/commit/e9a902c7f755a378e197c4b246a32859c0ee162d.dif

[PATCH] D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'"""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9a902c7f755: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""" (authored by cjdb). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

erichkeane added a comment. >> I think you've misunderstood; that is not required. Though with the design >> as-is, it might make sense to restrict this to being C++-only, given that >> there's not really a way to effectively use this from C. Ah, I see the example in SemaCXX. its sad we can't

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + aaron.ballman wrote: > erichkeane wrote: > > cor3n

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wimplicit-int`` in C89 mode will now issue + warnings instead of being a noop. ---

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a commenting nit. The Precommit CI test failures look unrelated to me as well. Do you need me to commit on your behalf? If so, what name and email address would you l

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah added a comment. Yes please commit on my behalf. My details are Tom Eccles tom.ecc...@codethink.co.uk Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667 __

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman marked 7 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + --

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm happy enough. I see both sides of the C89 debate enough to 'disagree and commit' on that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.l

[clang] 225b91e - Fix crash getting name of a template decl

Author: Tom Eccles Date: 2022-04-22T13:03:28-04:00 New Revision: 225b91e6cbba31ff1ce787a152a67977d08fdcab URL: https://github.com/llvm/llvm-project/commit/225b91e6cbba31ff1ce787a152a67977d08fdcab DIFF: https://github.com/llvm/llvm-project/commit/225b91e6cbba31ff1ce787a152a67977d08fdcab.diff LO

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've commit on your behalf in 225b91e6cbba31ff1ce787a152a67977d08fdcab . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2434 + + bool print(int arg1, int arg2, std::initializer_list fields) { + for (auto f : fields) { erichkeane wrote: > rsmith wrote: > > erichkeane wrote: > > > I'm curious as to

[PATCH] D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.

khchen updated this revision to Diff 424517. khchen edited the summary of this revision. khchen added a comment. update clang tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124186/new/ https://reviews.llvm.org/D124186 Files: clang/include/

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Oh, it's a //global// variable that supposed to shadow the function parameter! Thanks for clarifying. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123787/new/ https://reviews.llvm

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:420 +auto *FD = IFD ? IFD->getAnonField() : dyn_cast(D); +if (!FD || (FD->isUnnamedBitfield() || FD->isAnonymousStructOrUnion())) + continue; rsmith wrote: > erichkeane wrote:

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

erichkeane added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2434 + + bool print(int arg1, int arg2, std::initializer_list fields) { + for (auto f : fields) { rsmith wrote: > erichkeane wrote: > > rsmith wrote: > > > erichkeane wrote:

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D124280: [git-clang-format] Change run line from python to python3

thakis created this revision. thakis added a reviewer: MyDeveloperDay. Herald added a project: All. thakis requested review of this revision. Several systems no longer ship `python`. https://reviews.llvm.org/D124280 Files: clang/tools/clang-format/git-clang-format Index: clang/tools/clang-f

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 424534. jhuber6 added a comment. Herald added a subscriber: MaskRay. Adding warning for using both `-fno-gpu-rdc` and `-foffload-new-driver`. I think this is a good warning to have for now while this is being worked in as opt-in. Once this has matured I plan

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 424536. jhuber6 added a comment. Applied changes to wrong commit, whoops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files: clang/test/Driver/linker-wrapper-im

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 424537. jhuber6 added a comment. Adding warning for using both -fno-gpu-rdc and -foffload-new-driver. I think this is a good warning to have for now while this is being worked in as opt-in. Once this has matured I plan on adding the necessary logic to handle

[PATCH] D124282: [git-clang-format] Add some examples to the help text

thakis created this revision. thakis added reviewers: MyDeveloperDay, curdeius. Herald added a project: All. thakis requested review of this revision. https://reviews.llvm.org/D124282 Files: clang/tools/clang-format/git-clang-format Index: clang/tools/clang-format/git-clang-format ===

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overal, with few test nits. Comment at: clang/lib/AST/ASTContext.cpp:12300 + (D->hasAttr() && + GetGVALinkageForFunction(cast(D), +

  1   2   >