aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with a commenting nit. The Precommit CI test failures look unrelated to
me as well.
Do you need me to commit on your behalf? If so, what name and email address
would you like me to use for patch attribution? (I can fix the commenting issue
when I land, so don't worry about pushing up a new patch.)
================
Comment at: clang/unittests/AST/TypePrinterTest.cpp:74-75
+
+ // regression test ensuring we do not segfault getting the qualtype as a
+ // string
+ ASSERT_TRUE(PrintedTypeMatches(Code, {}, Matcher, "<int>",
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123667/new/
https://reviews.llvm.org/D123667
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
