sammccall marked an inline comment as done. sammccall added a subscriber: hliao. sammccall added a comment.
In D123668#3466376 <https://reviews.llvm.org/D123668#3466376>, @maryammo wrote: > It seems it breaks the following builds: > https://lab.llvm.org/buildbot/#/builders/121/builds/18618 > https://lab.llvm.org/buildbot/#/builders/57/builds/17125 It looks like @hliao fixed these aready, thanks! ================ Comment at: clang/lib/Testing/CMakeLists.txt:18 + clangBasic + clangFrontend + ) ---------------- thakis wrote: > Making clang/lib/Testing depend on clangFrontend (and hence on basically > everything) seems pretty heavy. Maybe this should be in a new library? I don't think there's any real dependency regression here. AFAICS everything using clangTesting was also using Frontend already, and this isn't a coincidence. Before this patch, clang/lib/testing contained only lists of command-line flags. In practice these are useful for parsing code in a variety of configurations, which requires frontend and everything. (In general I *would* prefer to have many fine-grained libraries of a header or two each, but our CMake setup makes it very costly to do so) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123668/new/ https://reviews.llvm.org/D123668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
