[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. In D115187#3192034 , @sammccall wrote: > A change that probably goes along with this one is having RecursiveASTVisitor > traverse the syntactic form instead of the semantic one if traversal of > implicit code is off. I believe t

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Looks definitely better! How about this slightly changed version protecting the interface? /// Helper which adds two underlying types of enumeration type. template , std::underlying_type_t>, typename UT2 = std::enable_if_t, std::underlying_type

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

bjope added a comment. Have had problems with failing stage 2 builds since this patch: FAILED: tools/clang/tools/extra/pseudo/unittests/CMakeFiles/ClangPseudoTests.dir/DirectiveMapTest.cpp.o /repo//install/stage2/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MAC

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

sammccall added a subscriber: rsmith. sammccall added a comment. This generally looks really good, I'm worried about the separate transformation in the template case though. Comment at: clang/include/clang/AST/ExprCXX.h:4731 + Expr *getOperand() const { +return static_c

[PATCH] D123019: [WIP][clang][extract-api] Add support for typedefs

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a subscriber: mgorny. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Typedef records consist of the symbol a

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420138. aaron.ballman added a comment. Fix clang-tools-extra test caught by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-to

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

hans added a comment. Herald added a project: All. This seems to have caused https://github.com/llvm/llvm-project/issues/54703 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120374/new/ https://reviews.llvm.org/D120374 _

[clang] 87b28f5 - [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

Author: Pavel Samolysov Date: 2022-04-04T12:16:39+03:00 New Revision: 87b28f5092f2f92fc380f18e8578746bdd2a54b2 URL: https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2 DIFF: https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2.dif

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

This revision was automatically updated to reflect the committed changes. Closed by commit rG87b28f5092f2: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member (authored by psamolysov-intel, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 506ec85 - [clang][dataflow] Add support for clang's `__builtin_expect`.

Author: Yitzhak Mandelbaum Date: 2022-04-04T12:20:43Z New Revision: 506ec85ba82a39748f8fb07c15b93e1e958a9611 URL: https://github.com/llvm/llvm-project/commit/506ec85ba82a39748f8fb07c15b93e1e958a9611 DIFF: https://github.com/llvm/llvm-project/commit/506ec85ba82a39748f8fb07c15b93e1e958a9611.diff

[PATCH] D122908: [clang][dataflow] Add support for clang's `__builtin_expect`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG506ec85ba82a: [clang][dataflow] Add support for clang's `__builtin_expect`. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122908/new/

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:396 break; + case APIRecord::RK_ObjCCategory: +Kind["identifier"] = AddLangPrefix("category"); Since we currently never actually emit a standalone categ

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan added a comment. Ah, I'd had a thinko about what 1703 was. that's superseded by p1757. That's what is needed. (your patch makes more sense in the 1703 context) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/ https://reviews.l

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method

psamolysov-intel created this revision. psamolysov-intel added reviewers: tejohnson, ddunbar, tobiasvk, tobiasvk_caf, paulkirth, greened. psamolysov-intel added a project: clang. Herald added subscribers: ormris, inglorion. Herald added a project: All. psamolysov-intel requested review of this rev

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. In D121233#3425793 , @bjope wrote: > Have had problems with failing stage 2 builds since this patch: > > FAILED: > tools/clang/tools/extra/pseudo/unittests/CMakeFiles/ClangPseudoTests.dir/DirectiveMapTest.cpp.o > > /repo/

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane added a comment. In D122820#3423712 , @thakis wrote: > Looks like this breaks tests on macOS: > http://45.33.8.238/macm1/31733/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. That is sad, it seems that llvm-c

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Thanks Quinn. i think this overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 __

[clang-tools-extra] 72ae6cc - [pseudo] respect CLANG_INCLUDE_TESTS

Author: Sam McCall Date: 2022-04-04T15:30:11+02:00 New Revision: 72ae6cc3a689869dcc15cfa8d0abcdd35a35a484 URL: https://github.com/llvm/llvm-project/commit/72ae6cc3a689869dcc15cfa8d0abcdd35a35a484 DIFF: https://github.com/llvm/llvm-project/commit/72ae6cc3a689869dcc15cfa8d0abcdd35a35a484.diff LO

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. In D121233#3425793 , @bjope wrote: > Have had problems with failing stage 2 builds since this patch: Should be fixed in 72ae6cc3a689869dcc15cfa8d0abcdd35a35a484

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

erichkeane added a comment. In D119609#3424434 , @junaire wrote: > Hi @aaron.ballman, do you think it's time to consider reviewing this? > > I don't why there's no response or progress in GCC, but I think I can submit > a patch for them if they think thi

[clang] d1205bb - Reapply"[GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs"

Author: Erich Keane Date: 2022-04-04T06:41:47-07:00 New Revision: d1205bb37d8c37c6e427c339d704e707147989d2 URL: https://github.com/llvm/llvm-project/commit/d1205bb37d8c37c6e427c339d704e707147989d2 DIFF: https://github.com/llvm/llvm-project/commit/d1205bb37d8c37c6e427c339d704e707147989d2.diff L

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder added a comment. In D122885#3426070 , @urnathan wrote: > Ah, I'd had a thinko about what 1703 was. that's superseded by > p1757wg21.link/p1857. That's what is needed. (your patch > makes more sense in the 1703 context) Ha, okay. Yes, that ma

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

erichkeane added inline comments. Comment at: clang/test/CodeGen/attr-target-mv.c:95-111 +// WINDOWS: $foo_used = comdat any +// WINDOWS: $foo_used2.avx_sse4.2 = comdat any +// WINDOWS: $pr50025.resolver = comdat any +// WINDOWS: $pr50025c.resolver = comdat any +// WINDOWS: $foo_

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

bjope added a comment. In D121233#3426155 , @sammccall wrote: > In D121233#3425793 , @bjope wrote: > >> Have had problems with failing stage 2 builds since this patch: > > Should be fixed in 72ae6cc3a689869dcc15cf

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. FWIW, I dislike this idea of doing tests in separate commits from the patch itself, it makes the review of the patch more difficult, and makes looking through history more difficult.

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 420168. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Frontend/CompilerInvocati

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire added inline comments. Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:10 + + void fn(int i, int j = ({{}, {}, {,}}), int k = ""); // expected-error {{expression statement not permitted in default argument}} expected-error {{cannot initialize a parameter o

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Attr.td:2730 +// used for the "default" variant be the largest mangling ID in the +// variant set. Note that, if dup

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

thakis added a comment. In D122820#3426132 , @erichkeane wrote: > In D122820#3423712 , @thakis wrote: > >> Looks like this breaks tests on macOS: >> http://45.33.8.238/macm1/31733/step_7.txt >> >> Please take a

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. In D121233#3426189 , @bjope wrote: > In D121233#3426155 , @sammccall > wrote: > >> In D121233#3425793 , @bjope wrote: >> >>> Have had problems

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3492 -if (TI.supportsIFunc() || FD->isTargetMultiVersion()) { - ResolverFunc = cast( - GetGlob

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

thakis added a comment. > Oh hm, if it's due to the wrong llvm-cxxfilt being called, maybe we just need > to update clang/test/lit.cfg.py to add llvm-cxxfilt to `tools` to make sure > it uses the just-built one instead of the one on PATH (? not sure). Actually, I consistently saw this failing

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks great! Just a couple of nits left. Appreciate you fixing the out-of-line `ns::f()` case too. It's easier to understand the fixed logic than the broken logic. I guess y

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[clang] a97e309 - fix comment typos to cycle bots

Author: Nico Weber Date: 2022-04-04T10:18:08-04:00 New Revision: a97e3097cfdfea5a20d3b867571c42ffa0666b01 URL: https://github.com/llvm/llvm-project/commit/a97e3097cfdfea5a20d3b867571c42ffa0666b01 DIFF: https://github.com/llvm/llvm-project/commit/a97e3097cfdfea5a20d3b867571c42ffa0666b01.diff LO

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added subscribers: MattDevereau, david-arm, paulwalker-arm, sdesmalen. erichkeane added a comment. I don't have any real comments (the changes are quite trivial), and I really like the approach here, I think it is more than generous. I see the transition of C89/C99: Warn C11/C17: W

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Google's protobufs are often quite large and their internal stat

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420175. kbobyrev added a comment. Fix the behavior: get Real Path instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/index/Ca

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think LGTM on technical perspective, Please don't commit until @aaron.ballman confirms he is OK with the direction, or would like to wait longer for GCC. Comment a

[PATCH] D122935: [AST] Dont invalidate a ref-type var decl if it has no initializer.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I'd be surprised if this *doesn't* break some fragile assumption somewhere, but it's a good change. For the record, the setInvalid was added in e6565625f456123ad6eb33c84c8100d8f9411192.

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire updated this revision to Diff 420178. junaire retitled this revision from " [Clang][Sema] Prohibit expr statement in the default argument" to "[Clang][Sema] Prohibit expr statement in the default argument". junaire edited the summary of this revision. junaire added a comment. Add tests f

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane added a comment. In D122820#3426211 , @thakis wrote: >> Oh hm, if it's due to the wrong llvm-cxxfilt being called, maybe we just >> need to update clang/test/lit.cfg.py to add llvm-cxxfilt to `tools` to make >> sure it uses the just-built on

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. This is required for D120306 which was landed but later reverted because of the failing Windows tests (different slash types for filenames requested during preamble parsing and in the main file). Repository: rG LLVM Github Monorepo

[clang] b1ed286 - Attempt to re-enable demangle test in mangle-nttp-anon-union

Author: Erich Keane Date: 2022-04-04T07:28:29-07:00 New Revision: b1ed28685766e6632938ea47d1d60c3028ebcfcf URL: https://github.com/llvm/llvm-project/commit/b1ed28685766e6632938ea47d1d60c3028ebcfcf DIFF: https://github.com/llvm/llvm-project/commit/b1ed28685766e6632938ea47d1d60c3028ebcfcf.diff L

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kadircet added a comment. note that you seem to be using `auto PublicHeader = CanonIncludes.mapHeader(Entry->getName());` (i.e. `getName`) in D120306 and not `tryGetRealPathName`. it might be nice to have a test case here, at least one that only fails/runs on

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3426303 , @kadircet wrote: > note that you seem to be using `auto PublicHeader = > CanonIncludes.mapHeader(Entry->getName());` (i.e. `getName`) in D120306 > and not `tryGetRealPathN

[PATCH] D121599: [AST] Better recovery on an expression refers to an invalid decl.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Diagnostic changes look great! Comment at: clang/lib/Sema/SemaDecl.cpp:1230 LookupResult Result(*this, Name, NameLoc, LookupOrdinaryName); return BuildDeclaration

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kadircet added a comment. > Right! I think I also need to do that in SymbolCollector.cpp. Now that you mentioned this too, it feels like the issue is not about being consistent, as I think all of the places that we have today are actually making use of `FileEntry::getName` as keys to `Canonica

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3426382 , @kadircet wrote: >> Right! I think I also need to do that in SymbolCollector.cpp. > > Now that you mentioned this too, it feels like the issue is not about being > consistent, as I think all of the places th

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

sammccall added a comment. Changing the strings here makes sense, but I'm confused by the use of tryGetRealPathName. Also, we ended up dropping the filename in favor of UniqueID in IncludeStructure, so that's an alternative here. Yes, I think we need a test here with a scope wide enough that it

[PATCH] D122965: Corrected A Command

ps-19 marked 2 inline comments as done. ps-19 added a comment. Can anyone please review the patch? Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": smeenai wrote: > ps-19 wrote: > > Comment Line No

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:73 + auto Filename = SM.getFileEntryForID(SM.getFileID(Range.getBegin())) + ->tryGetRealPathName(); + Includes->addMapping(Filename, isLiteralInclud

[PATCH] D122965: Corrected A Command

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D122965#3426403 , @ps-19 wrote: > Can anyone please review the patch? FYI: please only ping the patch after about a week has gone by

[PATCH] D122965: Corrected A Command

aaron.ballman added a comment. In D122965#3426412 , @aaron.ballman wrote: > In D122965#3426403 , @ps-19 wrote: > >> Can anyone please review the patch? > > FYI: please only ping the patch after about a week has g

[PATCH] D122965: Corrected A Command

ps-19 marked an inline comment as done. ps-19 added a comment. Priyansh Singh priyansh.singh...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122965/new/ https://reviews.llvm.org/D122965 ___ cf

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D122983#3426261 , @erichkeane wrote: > I don't have any real comments (the changes are quite trivial), and I really > like the approach here, I think it is more than gener

[clang] aa19500 - Correct a typo in a RUN line

Author: Priyansh Singh Date: 2022-04-04T11:32:05-04:00 New Revision: aa19500a4c3a66058078f88b3a7dd7a9ad30be12 URL: https://github.com/llvm/llvm-project/commit/aa19500a4c3a66058078f88b3a7dd7a9ad30be12 DIFF: https://github.com/llvm/llvm-project/commit/aa19500a4c3a66058078f88b3a7dd7a9ad30be12.diff

[PATCH] D123037: [clang][dataflow] Support integral casts

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adds support for implicit casts `CK_IntegralCast` and `CK_Integr

[PATCH] D122965: Corrected A Command

aaron.ballman closed this revision. aaron.ballman added a comment. In D122965#3426446 , @ps-19 wrote: > Priyansh Singh > priyansh.singh...@gmail.com Thanks! I've landed on your behalf in aa19500a4c3a66058078f88b3a7dd7a9ad30be12

[PATCH] D123037: [clang][dataflow] Support integral casts

ymandel updated this revision to Diff 420196. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123037/new/ https://reviews.llvm.org/D123037 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/unittests/Ana

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre added a comment. In D119017#3400347 , @devin.jeanpierre wrote: > I don't have easy access to a Windows machine at work so am struggling with > the reproduction instructions. Well, after much procrastinating, and an hour of fiddling wit

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

paulwalker-arm added a comment. Please consider this "AArch64 folks speaking up". What are your plans here exactly? I have no issue with adding `-std=c99` to the RUN lines, but "remove the // expected-warning comments" sounds like a significant loss of test coverage. CHANGES SINCE LAST ACTIO

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D122983#3426534 , @paulwalker-arm wrote: > Please consider this "AArch64 folks speaking up". What are your plans here > exactly? I have no issue with adding `-std=c99` to

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. Can you guys please help me review this patch? 😁 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 ___ cfe-commits mailing list cfe-comm

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

paulwalker-arm added a comment. The tests verify a set of builtins do not exist when the associated feature flag is not present. They sit within CodeGen because the tests were plentiful and it did not seem worth duplicating them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/ne

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

erichkeane added a comment. I don't particularly get what the 'fix' is here to Richard's issue. Additionally, I think this is showing me the absolute desperate need we have for some sort of 'text-checking' tests for this feature, checking vs the IR is too unreadable. Commen

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

hubert.reinterpretcast added a comment. In D122983#3426450 , @aaron.ballman wrote: > Yeah, those tests seem to be overly-constraining. There's no reason to be > validating whether there's an implicit function declaration warning in a > *codegen* test.

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

hubert.reinterpretcast added a comment. In D122983#3426541 , @paulwalker-arm wrote: > The tests verify a set of builtins do not exist when the associated feature > flag is not present. They sit within CodeGen because the tests were > plentiful and it

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3426541 , @paulwalker-arm wrote: > The tests verify a set of builtins do not exist when the associated feature > flag is not present. They sit within CodeGen because the tests were > plentiful and it did not s

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This includes: - replacing "relationhips" with "relationships" - emitting

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

paulwalker-arm added a comment. Thanks for this. I can see about cleaning up the tests but I'm still not sure what the advantage is. The affected RUN lines are already `-fsyntax-only` tests. Is it about where the test files live or is there something else I should be considering? The benefi

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. In D122983#3426661 , @paulwalker-arm wrote: > Thanks for this. I can see about cleaning up the tests but I'm still not > sure what the advantage is. The affected RUN lines are already > `-fsyntax-only` tests. Is it about

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. In D122920#3426556 , @erichkeane wrote: > I don't particularly get what the 'fix' is here to Richard's issue. > Additionally, I think this is showing me the absolute desperate need we have > for some sort of 'text-checking' te

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 LValue RecordLV, CharUnits Align, - llvm::FunctionCallee Func, int Lvl) { + bool dumpTypeName, llvm::Functio

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

paulwalker-arm added a comment. Ok, message understood. I'll try and get these cleaned up, I cannot say precisely when but will push for before we branch for 15 if that sounds sensible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 __

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 LValue RecordLV, CharUnits Align, - llvm::FunctionCallee Func, int Lvl) { + bool dumpTypeName, llvm::Func

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3426661 , @paulwalker-arm wrote: > Thanks for this. Any time, thank you for speaking up when I was about to drop test coverage by accident! In D122983#3426716 , @erich

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 420218. scchan added a comment. - fixed the hip-link-bundle-archive.hip test issue on Windows - fixed a couple of formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3426739 , @paulwalker-arm wrote: > Ok, message understood. I'll try and get these cleaned up, I cannot say > precisely when but will push for before we branch for 15 if that sounds > sensible. Oops, sorry, I

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao created this revision. shangwuyao added reviewers: jlebar, yaxunl, tra. Herald added subscribers: ldrumm, ThomasRaoux, Anastasia. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is req

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 LValue RecordLV, CharUnits Align, - llvm::FunctionCallee Func, int Lvl) { + bool dumpTypeName, llvm::Functio

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. I'll just add that in the recursive call, for record type, it will just print what's between {...} Eg: int printf(const char *, ...); struct A { int x; }; struct B { struct A a; struct C { int b; union X { int i;

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. We discussed this patch in our community call today and some people expressed their reservations about merging this just now. As I mentioned, I would like to have this merged to unblock the CMake PR . As p

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

yaxunl added a comment. Is this because your HIP threadIdx etc are implemented using OpenCL builtins so that the emitted LLVM IR contains calls of OpenCL builtins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123049/new/ https://reviews.llvm.org/

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao added a comment. In D123049#3426849 , @yaxunl wrote: > Is this because your HIP threadIdx etc are implemented using OpenCL builtins > so that the emitted LLVM IR contains calls of OpenCL builtins? Yes, that's correct. Repository: rG LLVM

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

yaxunl added a comment. LGTM since currently there is only one HIP/SPIRV implementation. If in the future there is another HIP/SPIRV implementation that does not need this, it could disable it by triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. I pushed 5d90004874c7b040cd43597826aabb34757d25ab to hopefully address the lion's share of the currently failing precommit CI tests. I'll address the remaining few as an update to this patch.

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 LValue RecordLV, CharUnits Align, - llvm::FunctionCallee Func, int Lvl) { + bool dumpTypeName, llvm::Functio

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

zixuw added a comment. Has this landed yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122798/new/ https://reviews.llvm.org/D122798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D123056: [clang][extract-api] Undefining macros should not result in a crash

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes the situation where a undefining a not previously defined macro

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420242. aaron.ballman added a comment. Herald added subscribers: kbarton, nemanjai. Updated the release note and hopefully addressed the remaining test failures found by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

dang added a comment. In D122798#3427004 , @zixuw wrote: > Has this landed yet? Doing it now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122798/new/ https://reviews.llvm.org/D122798 __

[clang] 422d05e - [clang][extract-api][NFC] Add documentation

Author: Daniel Grumberg Date: 2022-04-04T18:59:44+01:00 New Revision: 422d05e792dbd6a97f5afd4cdd5e8aa677e97444 URL: https://github.com/llvm/llvm-project/commit/422d05e792dbd6a97f5afd4cdd5e8aa677e97444 DIFF: https://github.com/llvm/llvm-project/commit/422d05e792dbd6a97f5afd4cdd5e8aa677e97444.dif

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422d05e792db: [clang][extract-api][NFC] Add documentation (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa updated this revision to Diff 420254. yihanaa added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/dump-st

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

aaron.ballman added a comment. In D119609#3426279 , @erichkeane wrote: > I think LGTM on technical perspective, Please don't commit until > @aaron.ballman confirms he is OK with the direction, or would like to wait > longer for GCC. I spotted some tec

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 ___ cfe-commits mai

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added a comment. In D122808#3425703 , @antoniofrighetto wrote: > Looks definitely better! How about this slightly changed version protecting > the interface? > > /// Helper which adds two underlying types of enumeration type. > templat

[clang-tools-extra] 6f3f1e9 - [clangd] Remove trivial uses of FileEntry::getName

Author: Sam McCall Date: 2022-04-04T20:59:51+02:00 New Revision: 6f3f1e98686575004bef4257cbc6c825de5382af URL: https://github.com/llvm/llvm-project/commit/6f3f1e98686575004bef4257cbc6c825de5382af DIFF: https://github.com/llvm/llvm-project/commit/6f3f1e98686575004bef4257cbc6c825de5382af.diff LO

[PATCH] D123059: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".""

devin.jeanpierre created this revision. devin.jeanpierre added a reviewer: gribozavr2. Herald added subscribers: dexonsmith, pengfei. Herald added a reviewer: aaron.ballman. Herald added a project: All. devin.jeanpierre requested review of this revision. Herald added a project: clang. Herald added

  1   2   >