erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
I think LGTM on technical perspective, Please don't commit until @aaron.ballman
confirms he is OK with the direction, or would like to wait longer for GCC.
================
Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:3
+
+void foo() {
+ void fn(int i, int = ({ 1; })); // expected-error {{expression statement not
permitted in default argument}}
----------------
erichkeane wrote:
> Do we also prohibit in a template argument?
Template args were already disallowed, right? Presumably there is a test for
that?
================
Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:10
+
+ void fn(int i, int j = ({{}, {}, {,}}), int k = ""); // expected-error
{{expression statement not permitted in default argument}} expected-error
{{cannot initialize a parameter of type 'int' with an lvalue of type 'const
char[1]'}} expected-note {{passing argument to parameter 'k' here}}
+}
----------------
junaire wrote:
> @erichkeane Do you mean this one? Or I get you wrong?
Ah, missed that, thank you! This is sufficient for my concerns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119609/new/
https://reviews.llvm.org/D119609
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
