kadircet added a comment.
> Right! I think I also need to do that in SymbolCollector.cpp.
Now that you mentioned this too, it feels like the issue is not about being
consistent, as I think all of the places that we have today are actually making
use of `FileEntry::getName` as keys to
`CanonicalIncludes::{addMapping,mapHeader}`. Are we sure we're not relying on
some sort of canonization of file path (AFAICT, that's not the case the only
canonization that's happening is dropping `..`) when you use
`tryGetRealPathName` instead of `getName`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123031/new/
https://reviews.llvm.org/D123031
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
