[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419650. cor3ntin added a comment. Fix tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp c

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu updated this revision to Diff 419649. ChuanqiXu added a reviewer: MaskRay. ChuanqiXu added a comment. Herald added a subscriber: StephenFan. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 Files: clang/include/cla

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419657. cor3ntin added a comment. - formatting - add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopC

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:79 +for (BoolValue *Constraint : Env1.getFlowConditionConstraints()) { + Expr1 = &Env1.makeA

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 419658. cor3ntin added a comment. - Add missing static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/include/clang/AST/DeclCXX.h clang/include/cla

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18242 +bool CheckCaptureUseBeforeLambdaQualifiers(Sema &S, VarDecl *Var, + SourceLocation ExprLoc, Chuan

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added a comment. In D119136#3418585 , @ChuanqiXu wrote: > I've just skimmed over the patch and it is a little bit hard to understand > for people who don't have a strong background. Is it possible to sp

[clang] c7ed65b - [C++20][Modules] Limit ModuleInternalLinkage to modules-ts.

Author: Iain Sandoe Date: 2022-04-01T09:10:30+01:00 New Revision: c7ed65b4bcbd8c26704efc4193243831e3c13d3c URL: https://github.com/llvm/llvm-project/commit/c7ed65b4bcbd8c26704efc4193243831e3c13d3c DIFF: https://github.com/llvm/llvm-project/commit/c7ed65b4bcbd8c26704efc4193243831e3c13d3c.diff L

[PATCH] D122413: [C++20][Modules] Limit ModuleInternalLinkage to modules-ts.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7ed65b4bcbd: [C++20][Modules] Limit ModuleInternalLinkage to modules-ts. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122413/new/ htt

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 updated this revision to Diff 419662. njames93 added a comment. Split PointerUnion to work on 32bit platforms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 Files: clang/lib/ASTMatchers/ASTMat

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

mgorny updated this revision to Diff 419666. mgorny added a comment. Used `__builtin_ia32_crc32*` along with `-mcrc32` to fix compatibility with GCC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 Files: compiler-rt/cmake/config-ix.cmake

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good! Comment at: clang-tools-extra/pseudo/include/clang-pseudo/DirectiveMap.h:95 // FIXME: add heuristically selection of conditional branches. // FIXM

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Use `err_target_unsuppo

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong added a comment. In D122805#3420111 , @steakhal wrote: > In D122805#3419662 , @martong wrote: > >> In D122805#3419129 , @steakhal >> wrote: >> >>> Please add a te

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, iains, urnathan, ChuanqiXu. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As in: http://www.open-std.org/jtc1/sc22/wg21/docs/paper

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong added a comment. In D122805#3421676 , @martong wrote: > In D122805#3420111 , @steakhal > wrote: > >> In D122805#3419662 , @martong >> wrote: >> >>> In D122805#34

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong updated this revision to Diff 419683. martong added a comment. - Add extNonConstS to the externalDefMap.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D122805 Files: clang/include/clang/CrossTU/Cro

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

steakhal added a comment. In D122805#3421746 , @martong wrote: > In D122805#3421676 , @martong wrote: > >> In D122805#3420111 , @steakhal >> wrote: >> >>> In D122805#3419

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 updated this revision to Diff 419690. njames93 added a comment. Use macro to reduce duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Not familiar with this code, but the newest version does resolve the build failure with GCC, so I guess this is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://

[PATCH] D122008: [flang][driver] Add support for generating executables

Leporacanthicus accepted this revision. Leporacanthicus added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 ___ cfe-commits mailing list cfe-c

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong added a comment. In D122805#3421802 , @steakhal wrote: > In D122805#3421746 , @martong wrote: > >> In D122805#3421676 , @martong >> wrote: >> >>> In D122805#34201

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong added a comment. > even if something changes in the extdefmap tool We already have a separate test file for that. That is `func-mapping-test.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D122805

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong updated this revision to Diff 419702. martong added a comment. - Rebase to llvm/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D122805 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h c

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 419704. tingwang added a comment. Update based on comments: (1) Reuse diag error message. (2) Update clang test case for those diag messages. (3) Add TODO comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang marked an inline comment as done. tingwang added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : E

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

hvdijk added inline comments. Comment at: clang/test/Modules/cxx20-hu-04.cpp:22 +// RUN: %clang_cc1 -std=c++20 -emit-module-interface importer-01.cpp \ +// RUN: -fmodule-file=hu-02.pcm -o B.pcm -DTDIR=%t -verify + On Windows, when the path starts with `C:\Users\

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd1da784ac64: [compiler-rt] [scudo] Use -mcrc32 on x86 when available (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan added a comment. I can;t really tell what you're doing. C++20 lexes import (&module) declarations as preprocessor directives. the parser must also recognize only such declarations that came through from lexing such directives. It is unrelated to #import. GCC's implementation drops

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419710. cor3ntin added a comment. Fix typo in test, fix captureInLambda (was crashing in release and not debug) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains added inline comments. Comment at: clang/test/Modules/cxx20-hu-04.cpp:22 +// RUN: %clang_cc1 -std=c++20 -emit-module-interface importer-01.cpp \ +// RUN: -fmodule-file=hu-02.pcm -o B.pcm -DTDIR=%t -verify + hvdijk wrote: > On Windows, when the path starts

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan added a comment. oh, also in 'import "bob";', "bob" needs to be lexed as a #include name, not a string. (and likewise 'import ;') Hence treating these lines in the preprocessor in directive-processing-mode was the way GCC went. Comment at: clang/test/Modules/P1703R

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:79 +for (BoolValue *Constraint : Env1.getFlowConditionConstraints()) { + Expr1 = &Env1.makeAnd(*Expr1, *Constraint); +} sgatev wrote: > xazax.hun wrot

[PATCH] D122871: Clang-Formatting

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I'm confused -- the issue you linked is for a bug with clang-format but the changes in your patch don't modify clang-format, just modifies a test file to be formatted.

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong updated this revision to Diff 419717. martong added a comment. - remove extNonConstS from the externalDefMap.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D122805 Files: clang/include/clang/CrossT

[PATCH] D122871: Clang-Formatting

ps-19 added a comment. okay now i understand the issue completely. If i just mentioned that i am formatting a test file it would be correct then according to my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D122805 ___

[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[clang] e63b81d - [analyzer][ctu] Only import const and trivial VarDecls

Author: Gabor Marton Date: 2022-04-01T13:49:39+02:00 New Revision: e63b81d10e023b4d8e9f61ca29a678c74ce2c1cb URL: https://github.com/llvm/llvm-project/commit/e63b81d10e023b4d8e9f61ca29a678c74ce2c1cb DIFF: https://github.com/llvm/llvm-project/commit/e63b81d10e023b4d8e9f61ca29a678c74ce2c1cb.diff

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe63b81d10e02: [analyzer][ctu] Only import const and trivial VarDecls (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

adamcz added a comment. Thanks, I was just about to fix that! Comment at: clang-tools-extra/clangd/TUScheduler.cpp:115 bool IsFirstPreamble) { - static llvm::once_flag OnceFlag; - llvm::call_once(OnceFlag, [&] { + auto RecordWithLabel = [&Stats](llv

[PATCH] D122871: Clang-Formatting

aaron.ballman added a comment. In D122871#3422061 , @ps-19 wrote: > okay now i understand the issue completely. > If i just mentioned that i am formatting a test file it would be correct then > according to my patch. We don't typically reformat whole fi

[PATCH] D122871: Clang-Formatting

junaire added a comment. You are not supposed to format the test, because the comment is actually something we called regression tests. If you reformat it (put it in the wrong place), the test will fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

hokein added a comment. in case you missed that, friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121375/new/ https://reviews.llvm.org/D121375 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D122677: [prototype] include-cleaner library

sammccall updated this revision to Diff 419723. sammccall added a comment. Herald added a project: clang. Add "hints", used for ranking candidates for suggestions. Not totally happy with this design: - its intrusive to a bunch of the types - computing/sorting these eagerly seems wasteful when th

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, eli.friedman, hubert.reinterpretcast, erichkeane, clang-language-wg. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Fun

[PATCH] D122852: [OPENMP] Fix assertion in clang::ASTContext::getTypeInfoImpl

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8072-8088 + QualType CanonType = + I->getAssociatedExpression()->getType().getCanonicalType(); + if (CanonType->isSpecificBuiltinType(BuiltinType::OMPArraySection)) { +

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. As mentioned in my previous comment, here is the RFC proposing a new `annotate_type` attribute: https://discourse.llvm.org/t/rfc-new-attribute-annotate-type-iteration-2/61378 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks good? to me. :-) Despite this complicating things by a fair amount, I don't have a better suggestion to offer. LGTM Comment at: clang/lib/A

[PATCH] D122871: Clang-Formatting

ps-19 added a comment. Pardon, it was my mistake i didn't see that the file i was amending was actually a test file i just search "switch" statement in my script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.org/D

[PATCH] D122871: Clang-Formatting

ps-19 abandoned this revision. ps-19 added a comment. Closed as: 1. Formating test file causes build to fail. 2. Formatting of whole page is not accpeted in LLVM as it created problem future with commands like `git blame` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel added a comment. All tests have been passed. Could anyone with the committer privileges help me with landing, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/ https://reviews.llvm.org/D122587

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman updated this revision to Diff 419734. aaron.ballman added a comment. Rebased, no changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ https://reviews.llvm.org/D122895 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td clan

[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

kadircet updated this revision to Diff 419737. kadircet added a comment. - Fix c/p error.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122894/new/ https://reviews.llvm.org/D122894 Files: clang-tools-extra/clangd/TUScheduler.cpp Index: clang-

[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:115 bool IsFirstPreamble) { - static llvm::once_flag OnceFlag; - llvm::call_once(OnceFlag, [&] { + auto RecordWithLabel = [

[clang-tools-extra] e2f598b - [clangd] Record IO precentage for first preamble build of the instance

Author: Kadir Cetinkaya Date: 2022-04-01T15:12:37+02:00 New Revision: e2f598bc1b377f7e5fe2f7044fb653faf3c18bb6 URL: https://github.com/llvm/llvm-project/commit/e2f598bc1b377f7e5fe2f7044fb653faf3c18bb6 DIFF: https://github.com/llvm/llvm-project/commit/e2f598bc1b377f7e5fe2f7044fb653faf3c18bb6.dif

[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGe2f598bc1b37: [clangd] Record IO precentage for first preamble build of the instance (authored by kadircet

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. I'm not opposed, but this does muddy the waters about the target-specific nature of the attribute. Currently, the semantic attribute cannot be used outside of Itanium ABI targets, so it doesn't work on Windows (and we don't want it to -- Microsoft hasn't picked th

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added a comment. The changes here look correct to me, but they complicate the code a reasonable amount. I almost wonder whether we want to add a helper function (perhaps even to STLExtras.h?) along the lines of a cleaned up version of: template auto addEnumValues(EnumTy1 LHS,

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane updated this revision to Diff 419741. erichkeane marked 9 inline comments as done. erichkeane added a comment. Fix all the things @tahonermann found. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122608/new/ https://reviews.llvm.org/D122608 Files: clang/lib/CodeGen/CodeGe

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6390-6391 llvm::GlobalValue *Val = I.second; -if (Val && !getModule().getNamedValue(Name->getName())) +llvm::GlobalValue *ExistingElem = +getModule().getNamedValue(Name->getName

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419743. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/Analysis/FlowSensitive/StorageLocation.

[clang] 69a7777 - [OpenMP] Make linker wrapper thin-lto default thread count use all

Author: Joseph Huber Date: 2022-04-01T09:44:28-04:00 New Revision: 69a1a9f5e577083338c3cebd61bbeb417843 URL: https://github.com/llvm/llvm-project/commit/69a1a9f5e577083338c3cebd61bbeb417843 DIFF: https://github.com/llvm/llvm-project/commit/69a1a9f5e577083338c3cebd61bbeb417843.diff

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419744. ymandel marked 5 inline comments as done. ymandel added a comment. add clarifying comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/inclu

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/StorageLocation.h:59-60 /// can be traced independently by abstract interpretation. For example: a -/// struct with public members. +/// struct with public members. Note that the corresponding

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

aaron.ballman added a comment. General question about the new syntax -- how does this work on field declarations of a record? e.g., struct S { int i : SV_GroupIndex; }; (Please tell me the answer is: it doesn't, because bit-fields are a thing.) Similar question applies to other places

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 419746. Herald added a subscriber: pengfei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5566-5567 +def warn_non_prototype_changes_behavior : Warning< + "this function declaration without a prototype is deprecated in all versions " + "of C and changes behavior in C2x">, In

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

thakis added a comment. In D122766#3421410 , @mstorsjo wrote: > In D122766#3420925 , @thakis wrote: > >> Windows can handle slashes, but several tools can't. I worry that if we do >> something different than cl,

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz added a comment. In D122699#3422298 , @aaron.ballman wrote: > General question about the new syntax -- how does this work on field > declarations of a record? e.g., > > struct S { > int i : SV_GroupIndex; > }; > > (Please tell me the answe

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane updated this revision to Diff 419748. erichkeane added a comment. Update to 'diag' instead of crash, as implied/requested by @rjmccall CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122820/new/ https://reviews.llvm.org/D122820 Files: clang/lib/AST/ItaniumMangle.cpp clang/

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5576 + "program to refer to the anonymous union, and there is therefore no need " + "to mangle its name. '"); +} rjmccall wrote: > erichkeane wrote: > > rjmccall wrote: > > >

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419751. ymandel added a comment. tweak comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/Analysis/FlowSensitive/StorageLocation.h

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 419750. erichkeane added a comment. Do a rebase, only conflict was with ReleaseNotes.rst. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:489 + // Attn Reviewers: we need to do this for the function constraints for + // comparison of constraints to work, but do we also need to do it for + // CheckInstantiatedFunctionConstraints? That o

[clang] cd55e51 - Add prototypes to functions which need them; NFC

Author: Aaron Ballman Date: 2022-04-01T10:32:46-04:00 New Revision: cd55e51516f03203f3bf632ff4a65ae7518a8319 URL: https://github.com/llvm/llvm-project/commit/cd55e51516f03203f3bf632ff4a65ae7518a8319 DIFF: https://github.com/llvm/llvm-project/commit/cd55e51516f03203f3bf632ff4a65ae7518a8319.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5566-5567 +def warn_non_prototype_changes_behavior : Warning< + "this function declaration without a prototype is deprecated in all v

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2052 Types[Context.BoolTy] = "%d"; Types[Context.SignedCharTy] = "%hhd"; Types[Context.UnsignedCharTy] = "%hhu"; I think this types should have been promoted according to th

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:79 +for (BoolValue *Constraint : Env1.getFlowConditionConstraints()) { + Expr1 = &Env1.makeAnd(*Expr1, *Constraint); +} ---

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added a comment. In D122822#3421089 , @yihanaa wrote: > I also agree that this is a useful debugging builtin, and no program logic > should be forced to depend on the output of this builtin. It's just used to > print out some useful debugging

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

jyknight added a comment. Starting by looking at the test cases, I've got some suggestions on making the diagnostics a bit less confusing. Comment at: clang/test/CodeGen/2009-06-01-addrofknr.c:8 -static int func(f) +static int func(f) // expected-warning {{this function decl

[clang] 36d4e84 - [clang][dataflow] Fix handling of base-class fields.

Author: Yitzhak Mandelbaum Date: 2022-04-01T15:01:32Z New Revision: 36d4e84427a704599bfd8bd72edf46ecd27ff5e5 URL: https://github.com/llvm/llvm-project/commit/36d4e84427a704599bfd8bd72edf46ecd27ff5e5 DIFF: https://github.com/llvm/llvm-project/commit/36d4e84427a704599bfd8bd72edf46ecd27ff5e5.diff

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36d4e84427a7: [clang][dataflow] Fix handling of base-class fields. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122908: [clang][dataflow] Add support for clang's `__builtin_expect`.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds basic modeling of `__builtin_expect`, just to pr

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a comment. In D122874#3422263 , @aaron.ballman wrote: > I'm not opposed, but this does muddy the waters about the target-specific > nature of the attribute. Currently, the semantic attribute cannot be used > outside of Itanium ABI targets

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 419763. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaAttr.cpp clang

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

ymandel updated this revision to Diff 419764. ymandel added a comment. Add comment about future optimization potential. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122838/new/ https://reviews.llvm.org/D122838 Files: clang/include/clang/Analysi

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419765. cor3ntin added a comment. Add a diagnostic in openmp mode. Supporting structured bindings in OpenMP mode requires OpenMP expertise, so we emit a diagnostic in -fopenmp mode informing that feature is not supported yet. My idea is that whether and how

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:79 +for (BoolValue *Constraint : Env1.getFlowConditionConstraints()) { + Expr1 = &Env1.makeAnd(*Expr1, *Constraint); +} -

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added a comment. In D122822#3422463 , @erichkeane wrote: > In D122822#3421089 , @yihanaa wrote: > >> I also agree that this is a useful debugging builtin, and no program logic >> should be forced to depe

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa marked 3 inline comments as done. yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2113-2117 if (CanonicalType->isRecordType()) { - TmpRes = dumpRecord(CGF, CanonicalType, FieldPtr, Align, Func, Lvl + 1); + TmpRes = dumpRecord(CGF,

[PATCH] D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic

yaxunl accepted this revision. yaxunl added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.org/D121951 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

hans added a comment. In D122766#3420925 , @thakis wrote: > Do you know what cl.exe does to paths in pdb files? Does it write > mixed-slashiness for foo/bar.h includes, or does it write backslashes > throughout? Looks like just backslashes: cl /nolo

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2113-2117 if (CanonicalType->isRecordType()) { - TmpRes = dumpRecord(CGF, CanonicalType, FieldPtr, Align, Func, Lvl + 1); + TmpRes = dumpRecord(CGF, CanonicalType, FieldLV, Align, Func, Lvl

[PATCH] D122908: [clang][dataflow] Add support for clang's `__builtin_expect`.

xazax.hun accepted this revision. xazax.hun added a comment. Nice! Speaking of builtins, it might be great to add tests for `__builtin_unreachable`, `__builtin_trap`, `__builtin_debugtrap`. The CFG might already have the right shape so we might not need to add any code to support them. But it

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 added a comment. In D122529#3422158 , @aaron.ballman wrote: > This looks good? to me. :-) > > Despite this complicating things by a fair amount, I don't have a better > suggestion to offer. LGTM This was the "nicest" cheapest way I cou

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

ymandel updated this revision to Diff 419793. ymandel marked 2 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122830/new/ https://reviews.llvm.org/D122830 Files: clang/lib/Analysi

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:53 + if (auto *LHSValue = dyn_cast_or_null( + Env.getValue(*LHSNorm, SkipPast::Reference))) +if (auto *RHSValue = dyn_cast_or_null( ---

[clang] ef1e1b3 - [clang][dataflow] Add support for (built-in) (in)equality operators

Author: Yitzhak Mandelbaum Date: 2022-04-01T17:13:21Z New Revision: ef1e1b3106a544389cf393647cda57b5b0642ef3 URL: https://github.com/llvm/llvm-project/commit/ef1e1b3106a544389cf393647cda57b5b0642ef3 DIFF: https://github.com/llvm/llvm-project/commit/ef1e1b3106a544389cf393647cda57b5b0642ef3.diff

  1   2   >