qiucf added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< ---------------- Use `err_target_unsupported_type`? ================ Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:192 + [llvm_float_ty, llvm_float_ty, llvm_float_ty, llvm_vararg_ty], + [IntrNoMem]>; } ---------------- tingwang wrote: > qiucf wrote: > > Will we support `llvm_f128_ty`? > I'm afraid not at this moment. Document mentions only three types: float, > double, or long double. Can we at least leave a TODO comment here for `llvm_f128_ty` support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.org/D122478 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
