xazax.hun accepted this revision.
xazax.hun added a comment.

Nice!

Speaking of builtins, it might be great to add tests for 
`__builtin_unreachable`, `__builtin_trap`, `__builtin_debugtrap`. The CFG might 
already have the right shape so we might not need to add any code to support 
them. But it would be nice to know :) Maybe we could even add a comment to 
`VisitCallExpr` why those wouldn't need explicit support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122908/new/

https://reviews.llvm.org/D122908

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to