njames93 added a comment. In D122529#3422158 <https://reviews.llvm.org/D122529#3422158>, @aaron.ballman wrote:
> This looks.... good?.... to me. :-) > > Despite this complicating things by a fair amount, I don't have a better > suggestion to offer. LGTM This was the "nicest" cheapest way I could think to implement this, It's also why I thought it best to resubmit this for review. Annoyingly this is now suboptimal for 64bit code, but I'm not sure it's worth writing 2 implementations for 64 and 32 bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
