martong added a comment. In D122805#3421676 <https://reviews.llvm.org/D122805#3421676>, @martong wrote:
> In D122805#3420111 <https://reviews.llvm.org/D122805#3420111>, @steakhal > wrote: > >> In D122805#3419662 <https://reviews.llvm.org/D122805#3419662>, @martong >> wrote: >> >>> In D122805#3419129 <https://reviews.llvm.org/D122805#3419129>, @steakhal >>> wrote: >>> >>>> Please add a test case where the class is trivial but the global variable >>>> of such is non-const, thus the initialized expression is not imported. >>> >>> I've added a new case, but that is not very meaningful, because >>> `clang-extdef-mapping` is not capable of emitting the USR for the non-const >>> variable. >> >> What do you mean by //not capable//? > > It uses `cross_tu::shouldImport()` which returns true only for `const` > declarations. So, having a hand-written `extDevMapping.txt` that contains an > USR for a non-const is not that meaningful, imho. I changed my mind: we can test one side of the logic if we do add `extNonConstS` to the `externalDefMap.txt`. So, just did that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D122805 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
