[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu created this revision. ChuanqiXu added reviewers: urnathan, iains. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. It is simpler to search for module unit by `-fprebuilt-module-path` optio

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

pengfei added a comment. Thanks @andrew.w.kaylor ! You are totally correct about the intention and current implementations. > Concretely, what are the semantics that we want for the BF16 types and > intrinsics? Unlike the other floating-point types, there's no standard to > guide this, so it's

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added a subscriber: MyDeveloperDay. ChuanqiXu added inline comments. Comment at: clang/test/Modules/search-partitions.cppm:20 +//--- partition1.cpp +export module A : Part1; + @MyDeveloperDay hi, I remember the support for partitions in clang-format is

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This test file has grown to the point where it takes a huge

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

fhahn added a comment. Herald added a subscriber: pcwang-thead. Herald added a project: All. Unfortunately some of the intrinsics tests have grown so large the the consistently hit the 10 minute timeout in the Phabricator precommit tests, e.g. see https://reviews.llvm.org/harbormaster/unit/15222

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

fhahn added a comment. Also see https://github.com/llvm/llvm-project/issues/54168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 ___ cfe-commits mailing list c

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test file has g

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

tyb0807 added a comment. Thanks for making this change. However, I think a better split would be - List Item `aarch64-cpus.c` which contains cpu-specific test cases (usually with `-mcpu` flag). Roughly this is until line 515, plus some last test cases from line 926 to end. `aarch64-archs.c` wh

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. > I just pushed 6cb42cd6669785f3b611106e1b6b38bbe65733a9 > to > hopefully fix this. Thank you Craig! That fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

simon_tatham added a comment. > While splitting up the test file is not ideal [...] Actually I'm not so sure. I'd almost rather go further, and split it up into lots of //much// smaller files, each with some kind of reasonable theme, like "all the basically v8.1-A stuff" or "all the v8M". The

[PATCH] D120812: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

hokein added a comment. In D120812#3354308 , @sammccall wrote: > Very nice! I thought we had considered and rejected this in the past, but I > think it was rather allowing lookup to find invalid decls in cases where it > doesn't today. Yeah, in the pas

[clang] ba6c71b - [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

Author: Haojian Wu Date: 2022-03-03T10:33:40+01:00 New Revision: ba6c71b1377e8c99b62b2115a8519df74465f53c URL: https://github.com/llvm/llvm-project/commit/ba6c71b1377e8c99b62b2115a8519df74465f53c DIFF: https://github.com/llvm/llvm-project/commit/ba6c71b1377e8c99b62b2115a8519df74465f53c.diff LO

[PATCH] D120812: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGba6c71b1377e: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl. (authored by ho

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn added a comment. In D120875#3356432 , @simon_tatham wrote: >> While splitting up the test file is not ideal [...] > > Actually I'm not so sure. I'd almost rather go further, and split it up into > lots of //much// smaller files, each with some kin

[PATCH] D120873: [clang-format] Handle wrapped else for RemoveBracesLLVM

curdeius accepted this revision. curdeius added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120873/new/ https://reviews.llvm.org/D120873 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D120812: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

sammccall added a comment. To preserve the decl, we could consider as a next step building a recoveryexpr wrapping a declrefexpr pointing at the invalid decl. This was discussed in the patch you linked, but I don't think it was tried? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

arcbbb added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4683 +Ops.push_back(VL); +Ops.push_back(DAG.getUNDEF(XLenVT)); // Policy + } kito-cheng wrote: > Is this operand for tail policy? if so why this is `UNDEF`? I guess thi

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

balazske added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:159-160 Itr != ItrE; ++Itr) { const auto *CallF = dyn_cast((*Itr)->getDecl()); -if (CallF && !isFunctionAsyncSafe(CallF)) { -

[clang] d832078 - [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

Author: Kristóf Umann Date: 2022-03-03T11:27:56+01:00 New Revision: d832078904c6e1d26648236b9f724f699dafb201 URL: https://github.com/llvm/llvm-project/commit/d832078904c6e1d26648236b9f724f699dafb201 DIFF: https://github.com/llvm/llvm-project/commit/d832078904c6e1d26648236b9f724f699dafb201.diff

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

This revision was automatically updated to reflect the committed changes. Closed by commit rGd832078904c6: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators (authored by Szelethus). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D118880

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/54151 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

kwk created this revision. kwk added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. Herald added a project: All. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was requested here (https://reviews.llvm.org/D120398#3353053)

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk abandoned this revision. kwk added a comment. I abandon this revision in favor of https://reviews.llvm.org/D120884. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120398/new/ https://reviews.llvm.org/D120398

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin updated this revision to Diff 412654. cor3ntin added a comment. Fix Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120881/new/ https://reviews.llvm.org/D120881 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 412657. ChuanqiXu added a comment. Rebase and update tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/Module.h clang/includ

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that this is basically always unused. And if it is needed, the end of th

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks updated this revision to Diff 412664. HazardyKnusperkeks added a comment. More Traits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + HazardyKnusperkeks wrot

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

HazardyKnusperkeks added a comment. Please use the clang-format tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120884/new/ https://reviews.llvm.org/D120884 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

kwk added a comment. In D120884#3356746 , @HazardyKnusperkeks wrote: > Please use the clang-format tag. Yes, sorry that I forgot it again. And thank you for approving. Shall I wait for the others to approve this or land the patch? Repository: rG LL

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Thanks for handling other traits! LGTM % alias test. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integr

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

balazske updated this revision to Diff 412665. balazske added a comment. Improved the test to fix failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120824/new/ https://reviews.llvm.org/D120824 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel created this revision. ymandel added a reviewer: sgatev. Herald added subscribers: tschuett, steakhal, mgrang, mgorny. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds a simpe lattice used to collect source loctions. An

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 412669. urnathan added a comment. Herald added a project: All. Updated to new partitions API CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Decl.

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

aaron.ballman added a comment. Herald added a subscriber: alextsao1999. I'm seeing debug failures again on Windows after this. FAIL: Clang :: Syntax/lr-build-conflicts.test (14728 of 14729) TEST 'Clang :: Syntax/lr-build-conflicts.test' FAILED Scri

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:13 + +#ifndef LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_SOURCELOCATIONS_LATTICE_H_ +#define LLVM_

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

steakhal added a comment. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120824/new/ https://reviews.llvm.org/D120824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3090-3093 +#define TYPE_TRAIT(N, I, K) case tok::kw_##I: +#define ARRAY_TYPE_TRAIT(I, E, K) case tok::kw_##I: +#define EXPRESSION_TRAIT(I, E, K) case tok::kw_##I: +#include "clang/Basic/TokenKinds

[clang] 1aa608a - [clang-format] Handle wrapped else for RemoveBracesLLVM

Author: owenca Date: 2022-03-03T04:53:15-08:00 New Revision: 1aa608a0208bc6a6945550a2071285ab51d899f1 URL: https://github.com/llvm/llvm-project/commit/1aa608a0208bc6a6945550a2071285ab51d899f1 DIFF: https://github.com/llvm/llvm-project/commit/1aa608a0208bc6a6945550a2071285ab51d899f1.diff LOG: [

[PATCH] D120873: [clang-format] Handle wrapped else for RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1aa608a0208b: [clang-format] Handle wrapped else for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

iains added inline comments. Comment at: clang/test/Modules/search-partitions.cppm:20 +//--- partition1.cpp +export module A : Part1; + ChuanqiXu wrote: > @MyDeveloperDay hi, I remember the support for partitions in clang-format is > done in https://reviews.llvm

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

aaron.ballman added a comment. In D119609#3355878 , @junaire wrote: > Frankly speaking, this is really a randomly written patch, and I have never > thought it would raise so much concern. But I believe I can handle it if you > guys can give me some trus

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

hokein added a comment. In D120723#3356831 , @aaron.ballman wrote: > I'm seeing debug failures again on Windows after this. > > FAIL: Clang :: Syntax/lr-build-conflicts.test (14728 of 14729) > TEST 'Clang :: Syntax/lr-build-confl

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

aaron.ballman added a comment. Thanks for looking into this, that's a rather amusing bug. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3398-3399 +if (isInstField && +D.getName().getKind() == UnqualifiedIdKind::IK_TemplateId) { + Diag(D.getIdentifierLoc(), diag:

[clang] 28ccf32 - [pseudo] Fix an out-of-bound access for LRTable::Actions.

Author: Haojian Wu Date: 2022-03-03T14:27:44+01:00 New Revision: 28ccf326725d0fea8648834c8acdbdfe3aa40d7a URL: https://github.com/llvm/llvm-project/commit/28ccf326725d0fea8648834c8acdbdfe3aa40d7a DIFF: https://github.com/llvm/llvm-project/commit/28ccf326725d0fea8648834c8acdbdfe3aa40d7a.diff LO

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

hokein added a comment. Fixed in 28ccf326725d0fea8648834c8acdbdfe3aa40d7a . Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:115 TargetedStates, [&Src](LRTable::StateID S) { return S < Src; });

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme abandoned this revision. mboehme added a comment. Herald added a project: All. Thanks for all of the input! Rather than going deeper into the discussion of the attribute here (on an only vaguely related change), I think it would be better to continue the discussion on the forum. I'm cu

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin updated this revision to Diff 412689. cor3ntin added a comment. - Fix redundant check - move test to p17.cpp which seems more approriate - add a couple of tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120881/new/ https://reviews.llvm

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2. Herald added subscribers: tschuett, steakhal, mgorny. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adds `MatchSwitch`, a library for simplifying implementation of t

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Do you have push rights, or do you need someone to push for you? If you need someone to push for you, please post the name and email address you'd like the commit under. Repository:

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

ymandel updated this revision to Diff 412693. ymandel added a comment. Adjust tests to use two different handlers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120900/new/ https://reviews.llvm.org/D120900 Files: clang/include/clang/Analysis/Flo

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

royjacobson added a comment. In D120255#3357007 , @erichkeane wrote: > Do you have push rights, or do you need someone to push for you? If you need > someone to push for you, please post the name and email address you'd like > the commit under. Thank

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Do we have a test somewhere to check the variable template specialization case to make sure that didn't break? Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

aaron.ballman added a comment. In D120723#3356925 , @hokein wrote: > Fixed in 28ccf326725d0fea8648834c8acdbdfe3aa40d7a > . Thanks! I can confirm this is fixed on my end now. Reposito

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:26 + +// Lattice for dataflow analysis that keeps track of a set of source locations. +// Doc comments start with `///`. Comment at:

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin added a comment. In D120881#3357015 , @erichkeane wrote: > Do we have a test somewhere to check the variable template specialization > case to make sure that didn't break? Otherwise LGTM. Thanks for the review. It seems fairly well covered in

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 412698. achieveartificialintelligence marked 7 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 5aeaabf - [Concepts] Check constraints for explicit template instantiations

Author: Roy Jacobson Date: 2022-03-03T06:33:49-08:00 New Revision: 5aeaabf35eaddf9e5bfb05c0ec901a8aecfaa36a URL: https://github.com/llvm/llvm-project/commit/5aeaabf35eaddf9e5bfb05c0ec901a8aecfaa36a DIFF: https://github.com/llvm/llvm-project/commit/5aeaabf35eaddf9e5bfb05c0ec901a8aecfaa36a.diff

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5aeaabf35ead: [Concepts] Check constraints for explicit template instantiations (authored by royjacobson, committed by erichkeane). Repository: rG

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

urnathan added inline comments. Herald added a project: All. Comment at: clang/test/Modules/inconsist-export-template.cpp:19-23 +// FIXME: We should reject following specialization, +// since it tries to export a name which is already introduced. +export template <> +void f1() {

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel updated this revision to Diff 412701. ymandel added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://reviews.llvm.org/D120890 Files: clang/include/clang/Analysis/FlowSensitive/SourceLocationsL

[PATCH] D120902: [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel marked 5 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:56 +// Returns a string that represents the source locations of the lattice. +std::string DebugString(const SourceLocationsLat

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (I'm a bit sad about the diagnostic differences, but I understand why they're different a bit better now, so this is fine.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1208

[clang] 942c039 - [Clang] Diagnose invalid member variable with template parameters

Author: Corentin Jabot Date: 2022-03-03T15:51:46+01:00 New Revision: 942c03910aef43de1cd2c733a82370fd3e2c9981 URL: https://github.com/llvm/llvm-project/commit/942c03910aef43de1cd2c733a82370fd3e2c9981 DIFF: https://github.com/llvm/llvm-project/commit/942c03910aef43de1cd2c733a82370fd3e2c9981.diff

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG942c03910aef: [Clang] Diagnose invalid member variable with template parameters (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

lei created this revision. lei added reviewers: hubert.reinterpretcast, nemanjai, jsji. Herald added a subscriber: shchenz. Herald added a project: All. lei requested review of this revision. Herald added projects: clang, libc++, LLVM. Herald added subscribers: llvm-commits, libcxx-commits, cfe-com

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

lei updated this revision to Diff 412710. lei added a comment. remove unintented change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.llvm.org/D120907 Files: clang/docs/ReleaseNotes.rst libcxx/docs/ReleaseNotes.rst

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

jsji accepted this revision. jsji added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.llvm.org/D120907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412714. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:115 TargetedStates, [&Src](LRTable::StateID S) { return S < Src; }); - if (It == TargetedStates.end()) + if (Start == TargetedStates.end()) return {}; hokein wr

[PATCH] D120910: [HIP] Fix job action offloading kind for mixed HIP/C++ compilation

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. When both HIP and C++ programs are input files to clang with -c, clang treats C++ programs as HIP programs, which is incorrect. This is due to action builder does not

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. When both CUDA or HIP programs and C++ programs are passed to clang driver without `-c`, C++ programs are treated as CUDA or

[clang] 7b85f0f - [PS4] isPS4 and isPS4CPU are not meaningfully different

Author: Paul Robinson Date: 2022-03-03T11:36:59-05:00 New Revision: 7b85f0f32f81f594016b065f71b58373cf2f7d35 URL: https://github.com/llvm/llvm-project/commit/7b85f0f32f81f594016b065f71b58373cf2f7d35 DIFF: https://github.com/llvm/llvm-project/commit/7b85f0f32f81f594016b065f71b58373cf2f7d35.diff

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added a comment. Herald added a project: All. In D120132#3352255 , @tra wrote: > In D120132#3351999 , @yaxunl wrote: > >> In D120132#3351853 , @tra wrote: >> >>> In

[clang] 3717b96 - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-03T08:54:46-08:00 New Revision: 3717b9661fd660933811c980a36a5e5deb8dcf40 URL: https://github.com/llvm/llvm-project/commit/3717b9661fd660933811c980a36a5e5deb8dcf40 DIFF: https://github.com/llvm/llvm-project/commit/3717b9661fd660933811c980a36a5e5deb8dcf40.diff

[PATCH] D120856: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBlocks.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3717b9661fd6: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM for libc++. I assume this is targeting `release/14.x` only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.llv

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

xazax.hun added a comment. Is there anything special about `SourceLocation`s? I wonder whether we just want a templated `Set` lattice and instantiate it with `SourceLocation`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://revi

[clang] de5785a - [NFC] Change TemplateInstantiator to refer to the base using a typedef

Author: Erich Keane Date: 2022-03-03T09:12:05-08:00 New Revision: de5785ad9d61c6b59793a6438a08973da42f9039 URL: https://github.com/llvm/llvm-project/commit/de5785ad9d61c6b59793a6438a08973da42f9039 DIFF: https://github.com/llvm/llvm-project/commit/de5785ad9d61c6b59793a6438a08973da42f9039.diff L

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel added a comment. In D120890#3357438 , @xazax.hun wrote: > Is there anything special about `SourceLocation`s? I wonder whether we just > want a templated `PowerSet` lattice and instantiate it with `SourceLocation`s. Not really. Just that we use t

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:51 +template +using MatchSwitch = std::function; + When we instantiate this with `TransferState` we have `ASTContext` both as an argument and as a member of `S

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

xazax.hun accepted this revision. xazax.hun added a comment. Herald added a subscriber: rnkovacs. In D120890#3357454 , @ymandel wrote: > In D120890#3357438 , @xazax.hun > wrote: > >> Is there anything special abo

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua updated this revision to Diff 412746. li.zhe.hua marked 7 inline comments as done. li.zhe.hua added a comment. Fixes from comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llvm.org/D120360 Files: clang

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:300 /// Constructs a simple \c RewriteRule. RewriteRule makeRule(ast_matchers::internal::DynTypedMatcher M, + EditGenerator Edits); ymandel w

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel updated this revision to Diff 412747. ymandel added a comment. added FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://reviews.llvm.org/D120890 Files: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattic

[PATCH] D120814: [clang-tidy] Add check to perfer pre-increment over post-increment

njames93 added a comment. See D72553 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120814/new/ https://reviews.llvm.org/D120814 ___ cfe-commits mailing list cfe-commits

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:56 +// Returns a string that represents the source locations of the lattice. +std::string DebugString(const SourceLocationsLattice &Lattic

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1917c88a32: [analyzer] Done some changes to detect Uninitialized read by the char array… (authored by Shivam <75530356+phybrack...@users.noreply.github.com>, committed by phyBrackets). Changed prior t

[clang] bd1917c - [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

Author: Shivam Date: 2022-03-03T23:21:26+05:30 New Revision: bd1917c88a32c0930864d04f4e71155dcc3fa592 URL: https://github.com/llvm/llvm-project/commit/bd1917c88a32c0930864d04f4e71155dcc3fa592 DIFF: https://github.com/llvm/llvm-project/commit/bd1917c88a32c0930864d04f4e71155dcc3fa592.diff LOG: [

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the fast review! Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:51 +template +using MatchSwitch = std::function; + xazax.hun wrote: > When we instantiate this w

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

dblaikie added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:19-23 +// FIXME: We should reject following specialization, +// since it tries to export a name which is already introduced. +export template <> +void f1() { + urnathan w

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

tra added a comment. We should probably also check what happens when we specify compilation language explicitly: E.g. `clang -x cuda a.cu -x c++ b.cc`, `clang -x cuda a.cu b.cc` and `clang a.cu -x cuda b.cc`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120911/new/ https://review

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

lei added a comment. In D120907#3357433 , @ldionne wrote: > LGTM for libc++. I assume this is targeting `release/14.x` only. yes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.l

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. https://github.com/llvm/llvm-project/commit/bd1917c88a32c0930864d04f4e71155dcc3fa592 , Hey @steakhal , I land it but why it is not showing the void emitUninitializedReadBug(CheckerContext &C, ProgramStateRef State, const Expr *E) co

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua updated this revision to Diff 412755. li.zhe.hua added a comment. Fix use-after-move in asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llvm.org/D120360 Files: clang-tools-extra/clang-tidy/abseil/Clea

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

ymandel added a comment. Looks like this broke the build. I'm getting: FAILED: tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/CStringChecker.cpp.o /usr/bin/clang++-11 ... -std=c++14 -MD -MT tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangS

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

lei closed this revision. lei added a comment. Commited to release/14.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.llvm.org/D120907 ___ cfe-commits mailing list cfe-commits

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

ronlieb added a comment. broke our hip buildbot as well. https://lab.llvm.org/buildbot/#/builders/165/builds/17076 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

ymandel updated this revision to Diff 412763. ymandel marked an inline comment as done. ymandel added a comment. moved to `MatchFinder::MatchResult`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120900/new/ https://reviews.llvm.org/D120900 Files:

  1   2   >