sgatev accepted this revision. sgatev added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:56 +// Returns a string that represents the source locations of the lattice. +std::string DebugString(const SourceLocationsLattice &Lattice, + const ASTContext &Context); ---------------- ymandel wrote: > sgatev wrote: > > Can you please add tests for this too? > I'm not sure what I would test, since it (intentionally) has no guaranteed > API. Do you have something particular in mind? I generally avoid testing > things like DebugString because we don't want users to rely on them. Fair point. Let's keep it as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://reviews.llvm.org/D120890 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
