sgatev accepted this revision.
sgatev added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:13
+
+#ifndef LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_SOURCELOCATIONS_LATTICE_H_
+#define LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_SOURCELOCATIONS_LATTICE_H_
----------------
Remove the last `_` for consistency with the other headers.
================
Comment at:
clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:46
+
+ llvm::DenseSet<SourceLocation> &getSourceLocations() { return Locs; }
+ const llvm::DenseSet<SourceLocation> &getSourceLocations() const {
----------------
Add an empty line after this member to separate it from the next?
================
Comment at: clang/lib/Analysis/FlowSensitive/SourceLocationsLattice.cpp:45
+ std::string result;
+ llvm::raw_string_ostream Os(result);
+ llvm::interleaveComma(Locations, Os);
----------------
Call this `OS`? It seems to be common.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120890/new/
https://reviews.llvm.org/D120890
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
