tyb0807 added a comment.

Thanks for making this change. However, I think a better split would be

- List Item

`aarch64-cpus.c` which contains cpu-specific test cases (usually with `-mcpu` 
flag). Roughly this is until line 515, plus some last test cases from line 926 
to end.
`aarch64-archs.c` which contains architecture-specific test cases (with 
`-march` flag).

Or better yet, we can further break down the `aarch64-archs.c`, with 
feature-specific test cases going into a feature-specific file, just as what we 
are doing with new features (`aarch64-hbc.c`, `aarch64-mops.c`, ...). I can 
submit a separate patch for this if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120875/new/

https://reviews.llvm.org/D120875

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to