[PATCH] D117090: Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Sockke created this revision. Sockke added reviewers: danielmarjamaki, njames93, aaron.ballman, MTC. Herald added a subscriber: carlosgalvezp. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The checker missed a check for

[clang-tools-extra] c4db521 - [clang] Introduce support for disabling warnings in system macros

Author: Carlos Galvez Date: 2022-01-12T08:18:19Z New Revision: c4db521cea32fcfb714d1a622e0efce69a564a28 URL: https://github.com/llvm/llvm-project/commit/c4db521cea32fcfb714d1a622e0efce69a564a28 DIFF: https://github.com/llvm/llvm-project/commit/c4db521cea32fcfb714d1a622e0efce69a564a28.diff LOG:

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4db521cea32: [clang] Introduce support for disabling warnings in system macros (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

carlosgalvezp added a comment. In D116833#3236209 , @rsmith wrote: > Thanks, this looks nice. > > I think we'll need to think carefully before changing the default here. It > seems like the choice here would depend on what token the location of the > di

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei updated this revision to Diff 399235. pengfei marked an inline comment as done. pengfei added a comment. Add comments in code. @rnk, thanks for your patient review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.l

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4583-4589 + if (T.isArch64Bit() || !T.isWindowsMSVCEnvironment()) +return Res; - return (Groups[1] + AddrSpaces + Groups[3]).str(); + StringRef Ref = Res; + auto I = Ref.find("-f80:32-"); + if (I !=

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 ___ cfe-commits mailing list cfe-commits

[PATCH] D117090: Fix `readability-non-const-parameter` for parameter referenced by an lvalue

MTC added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp:86-99 + // Data passed by nonconst reference should not be made const. + unsigned ArgNr = 0U; + if (const auto *CD = CE->getConstructor()) { +for (co

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 created this revision. xbolva00 added reviewers: reames, rjmccall, jdoerfert. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. alloc align https://clang.llvm.org/docs/AttributeReference.html#alloc-align alloc size https://c

[PATCH] D116025: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

gamesh411 updated this revision to Diff 399246. gamesh411 added a comment. Tidy things up thanks to the recommendations of @steakhal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116025/new/ https://reviews.llvm.org/D116025 Files: clang/include/

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. Thanks Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D117037: [clang][CodeComplete] Perform approximate member search in bases

kadircet updated this revision to Diff 399252. kadircet marked 5 inline comments as done. kadircet added a comment. - Replace clangd unittest with clang lit - get rid of non-cxxrecorddecl handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117037

[PATCH] D117037: [clang][CodeComplete] Perform approximate member search in bases

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3459 + const std::string Code = R"cpp( +struct Base { Base foo(); }; + sammccall wrote: > does this also work if the base is dependent (Base)? yes

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116294/new/ https://reviews.llvm.org/D116294 __

[clang] 1bb0caf - [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

Author: Phoebe Wang Date: 2022-01-12T17:50:37+08:00 New Revision: 1bb0caf561688681be67cc91560348c9e43fcbf3 URL: https://github.com/llvm/llvm-project/commit/1bb0caf561688681be67cc91560348c9e43fcbf3 DIFF: https://github.com/llvm/llvm-project/commit/1bb0caf561688681be67cc91560348c9e43fcbf3.diff L

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bb0caf56168: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match… (authored by pengfei). Repository: rG LLVM Github Mono

[clang] dfd9879 - [Clang] Make Clang copy its CMake modules into the build dir

Author: Andrzej Warzynski Date: 2022-01-12T09:51:14Z New Revision: dfd9879d6f43949443ba3c58cf3969ed582d7466 URL: https://github.com/llvm/llvm-project/commit/dfd9879d6f43949443ba3c58cf3969ed582d7466 DIFF: https://github.com/llvm/llvm-project/commit/dfd9879d6f43949443ba3c58cf3969ed582d7466.diff

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd9879d6f43: [Clang] Make Clang copy its CMake modules into the build dir (authored by awarzynski). Changed prior to commit: https://reviews.llvm

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

mstorsjo added a comment. The relanded version in rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 seems to be breaking some builds with PCH for me, failing asserts like this: clang: ../tools/clang/include/clang/Basic/SourceLocat

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Ping. `Zfinx` has been ratified, could we spend some time on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 __

[PATCH] D117037: [clang][CodeComplete] Perform approximate member search in bases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG612f5ed88231: [clang][CodeComplete] Perform approximate member search in bases (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGE

[clang] 612f5ed - [clang][CodeComplete] Perform approximate member search in bases

Author: Kadir Cetinkaya Date: 2022-01-12T10:56:06+01:00 New Revision: 612f5ed8823120b30cb3c8bbde79a7f0ae9d1761 URL: https://github.com/llvm/llvm-project/commit/612f5ed8823120b30cb3c8bbde79a7f0ae9d1761 DIFF: https://github.com/llvm/llvm-project/commit/612f5ed8823120b30cb3c8bbde79a7f0ae9d1761.dif

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116088/new/ https://reviews.llvm.org/D116088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 399262. qiucf edited the summary of this revision. qiucf added a comment. Also check glibc version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files: clang/inclu

[clang] eadb4cf - Revert (2) "[AST] Add RParen loc for decltype AutoTypeloc."

Author: Florian Hahn Date: 2022-01-12T10:09:37Z New Revision: eadb4cfeeff55678eac0c9225f095567e1564424 URL: https://github.com/llvm/llvm-project/commit/eadb4cfeeff55678eac0c9225f095567e1564424 DIFF: https://github.com/llvm/llvm-project/commit/eadb4cfeeff55678eac0c9225f095567e1564424.diff LOG:

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

fhahn added a comment. In D116919#3236899 , @mstorsjo wrote: > The relanded version in rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 > seems > to be breaking some builds with PCH for me,

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

hokein added a comment. In D116919#3236899 , @mstorsjo wrote: > The relanded version in rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 > seems > to be breaking some builds with PCH for me

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added inline comments. Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21 + // CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to different values Anastasia wrote: > Anastasia wrote: > > I can't remember if we have d

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov updated this revision to Diff 399269. azabaznov added a comment. Rebase, remove extra 'verify' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://reviews.llvm.org/D115640 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 399270. achieveartificialintelligence added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Much nicer :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116904/new/ https://reviews.llvm.org/D116904 ___

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 399271. mubashar_ set the repository for this revision to rG LLVM Github Monorepo. mubashar_ added a comment. Windows tests are now expected to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/

[clang-tools-extra] 35cca45 - Misleading bidirectional detection

Author: serge-sans-paille Date: 2022-01-12T11:38:36+01:00 New Revision: 35cca45b09b87cc31cda35a66fc93bf4d630f8d2 URL: https://github.com/llvm/llvm-project/commit/35cca45b09b87cc31cda35a66fc93bf4d630f8d2 DIFF: https://github.com/llvm/llvm-project/commit/35cca45b09b87cc31cda35a66fc93bf4d630f8d2.d

[PATCH] D112913: Misleading bidirectional detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35cca45b09b8: Misleading bidirectional detection (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D112913?vs=398

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

mstorsjo added a comment. Ok, now I managed to make a standalone reproducer: https://martin.st/temp/pch-preproc.hxx and https://martin.st/temp/main-preproc.cpp $ bin/clang -target x86_64-w64-mingw32 -w -x c++-header -c pch-preproc.hxx -o pch-preproc.hxx.pch -std=c++17 -O3 $ bin/clang -targ

[PATCH] D116659: [llvm][clang][vfs] NFC: Extract directory iteration boilerplate into macro

jansvoboda11 updated this revision to Diff 399275. jansvoboda11 added a comment. Herald added a subscriber: hiraditya. Replace macro with range of new iterators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116659/new/ https://reviews.llvm.org/D116

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

fhahn added a comment. It looks like this may be causing the following bot to fail https://lab.llvm.org/buildbot/#/builders/16/builds/22138 with TEST 'lld :: COFF/lto-lazy-reference.ll' FAILED Script: -- : 'RUN: at line 2'; /b/1/llvm-clang-x8

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. Thanks @fhahn ! I saw the failure. I think it just needs to update the datalayout in the lit tests. I am checking on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 ___

[PATCH] D116659: [llvm][clang][vfs] NFC: Simplify directory iteration

jansvoboda11 added a comment. I agree that introducing new iterator and implementing `iterator_range<...> FileSystem::dir_range()` is better solution than a macro. I'm not sure the `dir_range` function needs to take an `std::error_code` out-param though. The error code is only used to stop the

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:387 + + return a.isArmT32(); +} For example Arm7-a defines the T32 instruction set, buy we still want a warning. Maybe we need `return a.isArmT32() && a.isArmMClass()`. I'm not actually su

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

Jimerlife updated this revision to Diff 399281. Jimerlife added a comment. Herald added a subscriber: jacquesguan. format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116994/new/ https://reviews.llvm.org/D116994 Files: clang/include/clang/

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. Should be fixed by rG9b43237128da . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 _

[clang] bf5f235 - [NFC] [Coroutines] Add regression tests for symmetric transfer and coroutine elision

Author: Chuanqi Xu Date: 2022-01-12T19:39:56+08:00 New Revision: bf5f2354fa6e3f31a1acea75a229fee54359e279 URL: https://github.com/llvm/llvm-project/commit/bf5f2354fa6e3f31a1acea75a229fee54359e279 DIFF: https://github.com/llvm/llvm-project/commit/bf5f2354fa6e3f31a1acea75a229fee54359e279.diff LO

[clang] 4b85800 - [OpenCL] Set external linkage for block enqueue kernels

Author: Sven van Haastregt Date: 2022-01-12T13:30:09Z New Revision: 4b85800bfd6ca6c3ecedf68ffbba6c3f2bc9c8ae URL: https://github.com/llvm/llvm-project/commit/4b85800bfd6ca6c3ecedf68ffbba6c3f2bc9c8ae DIFF: https://github.com/llvm/llvm-project/commit/4b85800bfd6ca6c3ecedf68ffbba6c3f2bc9c8ae.diff

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b85800bfd6c: [OpenCL] Set external linkage for block enqueue kernels (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. In D27800#3235066 , @efriedma wrote: > Looks like all the review comments have been addressed. LGTM Thanks for the review, but unfortunately I found an issue right before committing, taking a look at it now. Repository: rG LL

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet updated this revision to Diff 399300. kadircet marked 5 inline comments as done. kadircet added a comment. - Change the variant acception mechanism to work with specific variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114724/new/ h

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. During pop() we conve

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk marked 2 inline comments as done. JackAKirk added a comment. ping @tra I thought I should let you know that I do not have commit access to land the patch. I'm also happy to wait a little longer in case you think other interested parties might still chime in. Thanks ==

[clang] 732ad8e - [clang][auto-init] Provide __builtin_alloca*_uninitialized variants

Author: Marco Elver Date: 2022-01-12T15:13:10+01:00 New Revision: 732ad8ea62edc403727af57537b5d83dcfa937aa URL: https://github.com/llvm/llvm-project/commit/732ad8ea62edc403727af57537b5d83dcfa937aa DIFF: https://github.com/llvm/llvm-project/commit/732ad8ea62edc403727af57537b5d83dcfa937aa.diff L

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

This revision was automatically updated to reflect the committed changes. Closed by commit rG732ad8ea62ed: [clang][auto-init] Provide __builtin_alloca*_uninitialized variants (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115440/

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich created this revision. philipp.tomsich added reviewers: kristof.beyls, jgreenhalgh. Herald added a subscriber: hiraditya. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add support for the

[clang-tools-extra] c490f8f - [clangd][StdSymbolMap] Prefer std::remove from algorithm

Author: Kadir Cetinkaya Date: 2022-01-12T15:25:42+01:00 New Revision: c490f8feb71e837dd7011e7a7d8a7928507c9c76 URL: https://github.com/llvm/llvm-project/commit/c490f8feb71e837dd7011e7a7d8a7928507c9c76 DIFF: https://github.com/llvm/llvm-project/commit/c490f8feb71e837dd7011e7a7d8a7928507c9c76.dif

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

This revision was automatically updated to reflect the committed changes. Closed by commit rGc490f8feb71e: [clangd][StdSymbolMap] Prefer std::remove from algorithm (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114724/new/ htt

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

yaxunl added a comment. It is possible that block kernels are defined and invoked in static functions, therefore two block kernels in different TU's may have the same name. Making such kernels external may cause duplicate symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. In D105340#3232671 , @NoQ wrote: > This looks great with the option flag. Landing this patch will enable more > people to test the new mode and produce feedback on whether the constraint > solver keeps working well enough

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:231 + +compileDeviceRTLLibrary(x86_64 vgpu -target x86_64-vgpu -std=c++20 -stdlib=libc++ -I${devicertl_base_directory}/../plugins/vgpu/src) It's not a good practice to

[PATCH] D27800: [clang] Fix crash for sizeof on VLAs

pmatos updated this revision to Diff 399320. pmatos retitled this revision from "Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo" to "[clang] Fix crash for sizeof on VLAs". pmatos edited the summary of this revision. pmatos added a comment. Ensure that we only call transform o

[PATCH] D27800: [clang] Fix crash for sizeof on VLAs

pmatos added a comment. In D27800#3235066 , @efriedma wrote: > Looks like all the review comments have been addressed. LGTM Minor change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://r

[clang] 6cbebfc - [clang-format] Fix comment. NFC.

Author: Marek Kurdej Date: 2022-01-12T16:10:03+01:00 New Revision: 6cbebfc7fb3468a080b04c58bfe374f8bee33d12 URL: https://github.com/llvm/llvm-project/commit/6cbebfc7fb3468a080b04c58bfe374f8bee33d12 DIFF: https://github.com/llvm/llvm-project/commit/6cbebfc7fb3468a080b04c58bfe374f8bee33d12.diff

[clang] 968be05 - [clang] Fix crash for sizeof on VLAs

Author: Paulo Matos Date: 2022-01-12T16:10:58+01:00 New Revision: 968be05b8fdc1d23c055cc4963230a89efbc5967 URL: https://github.com/llvm/llvm-project/commit/968be05b8fdc1d23c055cc4963230a89efbc5967 DIFF: https://github.com/llvm/llvm-project/commit/968be05b8fdc1d23c055cc4963230a89efbc5967.diff L

[PATCH] D27800: [clang] Fix crash for sizeof on VLAs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG968be05b8fdc: [clang] Fix crash for sizeof on VLAs (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang-tools-extra] dcc2014 - [clang-tidy] UseDefaultMemberInitCheck::checkDefaultInit - Use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-12T15:35:37Z New Revision: dcc20143e170b912aa0831dbedb5c1de07958012 URL: https://github.com/llvm/llvm-project/commit/dcc20143e170b912aa0831dbedb5c1de07958012 DIFF: https://github.com/llvm/llvm-project/commit/dcc20143e170b912aa0831dbedb5c1de07958012.diff LOG:

[clang] 497a4b2 - CGBuiltin - Use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-12T15:35:37Z New Revision: 497a4b26c487a9640847c485f9b0c36c110a8545 URL: https://github.com/llvm/llvm-project/commit/497a4b26c487a9640847c485f9b0c36c110a8545 DIFF: https://github.com/llvm/llvm-project/commit/497a4b26c487a9640847c485f9b0c36c110a8545.diff LOG:

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

egorzhdan updated this revision to Diff 399327. egorzhdan added a comment. Add a test for a diagnostic without VersionMap & fix clang-format warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116822/new/ https://reviews.llvm.org/D116822 Files:

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

t4c1 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:1057 + +BUILTIN(__nvvm_atom_xchg_global_i, "iiD*i", "n") +TARGET_BUILTIN(__nvvm_atom_cta_xchg_global_i, "iiD*i", "n", SM_60) tra wrote: > Naghasan wrote: > > tra wrote: > > > t4c1

[PATCH] D117119: [clang] Remove uses of `std::vector`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. LLVM Progr

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

saiislam created this revision. saiislam added reviewers: sdmitriev, jdoerfert, grokos, JonChesterfield, carlo.bertolli, vzakhari. Herald added a subscriber: arphaman. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add t

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 399336. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clan

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 399337. aaron.ballman added a comment. Updating based on review feedback -- adds the signed versions of the __macros__ for consistency and uses them in limits.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115253/new/ https://reviews.llvm.o

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 399334. steffenlarsen added a comment. I have made the changes suggested in my previous comment. This makes significantly more changes to the parsing of attribute arguments as the old path was needed for attributes that allow both expressions and types

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__", Twin

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with comments Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13 +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH +// ERR-HOT

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 399341. tyb0807 marked an inline comment as done. tyb0807 added a comment. Removed checks that set HBC flag based on the target architecture and unset it if command line explicitly disables it. This is because HBC feature does not require any new intrinsic in

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114787/new/ https://reviews.llvm.org/D114787 ___

[PATCH] D117123: [clang][dataflow] Add transfer functions for initializers

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

martong added a comment. In D105340#3237430 , @ASDenysPetrov wrote: > In D105340#3232671 , @NoQ wrote: > >> This looks great with the option flag. Landing this patch will enable more >> people to test the new mo

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda updated this revision to Diff 399345. kda added a comment. Herald added subscribers: Sanitizers, ormris, dexonsmith, dang. Herald added a project: Sanitizers. enable eager-checks in llvm via flag (-fsanitize-memory-param-retval). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda updated this revision to Diff 399347. kda added a comment. Correcting diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116701/new/ https://reviews.llvm.org/D116701 Files: clang/include/clang/Driver/SanitizerArgs.h clang/lib/CodeGen/Back

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116701/new/ https://reviews.llvm.org/D116701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

martong added a comment. Thanks for the review guys. Artem, I agree, that we should remove `LocAsInteger`. `LocaAsInteger` is a primitive handling of a specific cast operation (when we cast a pointer to an integer). The integration of `LocaAsInteger` into the `SymExpr` hierarchy is problemati

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13 +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH +// ERR-HOTPATCH: error: unsupported option '/hotpatch' for t

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a comment. In D105169#3236484 , @hyeongyukim wrote: > @nathanchance > > I tried to reproduce the last warning (intelfbhw_validate_mode), but I failed > to produce it. > I think my reproducer is correct, but it does not make any warnin

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

kda updated this revision to Diff 399352. kda added a comment. Herald added subscribers: luke957, s.egerton, simoncook. add param usage test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116701/new/ https://reviews.llvm.org/D116701 Files: clang/

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

martong added a comment. Ah, I forgot to mention one last point: 5. Revert D115149 . We should never reach that problematic assertion once we produce the `SymbolCast`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 118f966 - [clang][#51931] Enable `-Wdeclaration-after-statement` for all C versions

Author: Markus Böck Date: 2022-01-12T18:21:46+01:00 New Revision: 118f966b46cfb60897b56a9878e1c68fd0e2afa4 URL: https://github.com/llvm/llvm-project/commit/118f966b46cfb60897b56a9878e1c68fd0e2afa4 DIFF: https://github.com/llvm/llvm-project/commit/118f966b46cfb60897b56a9878e1c68fd0e2afa4.diff L

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

This revision was automatically updated to reflect the committed changes. Closed by commit rG118f966b46cf: [clang][#51931] Enable `-Wdeclaration-after-statement` for all C versions (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116994/new/ https://reviews.llvm.org/D116994 ___

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399362. kda added a comment. add test to validate that flag does not conflict with enable-noundef-analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files: clang/

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added a comment. >>> This needs a clang/test/Driver test to show that `%clang >>> -fsanitize-memory-param-retval` translates to CC1 >>> `-fsanitize-memory-param-retval`. >> >> Could you point me to an example? > > `test/Driver/fpatchable-function-entry.c` `test/Driver/fbinutils-version.c` :)

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

jyknight added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__", Twine(TI.

[clang] 3a32d2e - [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

Author: Egor Zhdan Date: 2022-01-12T17:40:18Z New Revision: 3a32d2e74e5c03d97a41ef7b0a01f206af62ad4f URL: https://github.com/llvm/llvm-project/commit/3a32d2e74e5c03d97a41ef7b0a01f206af62ad4f DIFF: https://github.com/llvm/llvm-project/commit/3a32d2e74e5c03d97a41ef7b0a01f206af62ad4f.diff LOG: [C

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a32d2e74e5c: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3237410 , @yaxunl wrote: > It is possible that block kernels are defined and invoked in static > functions, therefore two block kernels in different TU's may have the same > name. Making such kernels external may ca

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:1057 + +BUILTIN(__nvvm_atom_xchg_global_i, "iiD*i", "n") +TARGET_BUILTIN(__nvvm_atom_cta_xchg_global_i, "iiD*i", "n", SM_60) t4c1 wrote: > tra wrote: > > Naghasan wrote: > > > tra

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

tra added a comment. In D116673#3237342 , @JackAKirk wrote: > I thought I should let you know that I do not have commit access to land the > patch. I'm also happy to wait a little longer in case you think other > interested parties might still chime in

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk marked 2 inline comments as done. JackAKirk added a comment. >> I can land the patch on your behalf. Are you OK to use the name/email in >> this patch or do you prefer to use a different email for the LLVM commit? > > Thanks very much. Yes the name/email in the patch is fine. CHA

[PATCH] D117098: [RISCV] update zfh and zfhmin extention to v1.0

craig.topper added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:207 // RUN: %clang -target riscv32-unknown-linux-gnu -menable-experimental-extensions \ +// RUN: -march=rv32izfhmin1p0 -x c -E -dM %s \ If it's not experimental no

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

gribozavr2 added inline comments. Comment at: clang/lib/AST/CommentLexer.cpp:278 + +again: + size_t End = I'd suggest refactoring to a `while (true)` if you don't mind. Comment at: clang/lib/AST/CommentLexer.cpp:290 +if (End != StringRef::

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__", Twin

  1   2   3   >