hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
lgtm with comments ================ Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13 +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH +// ERR-HOTPATCH: error: unsupported option '/hotpatch' for target +// HOTPATCH: S_COMPILE3 [size = [[#]]] ---------------- Does MSVC error for ARM/ARM64 too, or does it just ignore the flag? ================ Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:19 +/// +// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c %s -o %t.obj +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=NO-HOTPATCH ---------------- nit: We still need -- before %s with clang-cl (%s could be /Users/... and get interpreted as a flag), and so it needs to come last. Same for the line in debug-info-hotpatch.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116511/new/ https://reviews.llvm.org/D116511 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
