gribozavr2 added inline comments.

================
Comment at: clang/lib/AST/CommentLexer.cpp:278
+
+again:
+  size_t End =
----------------
I'd suggest refactoring to a `while (true)` if you don't mind.


================
Comment at: clang/lib/AST/CommentLexer.cpp:290
+    if (End != StringRef::npos && *(TokenPtr + End) == '\"')
+      TokenPtr += End + 1;
+    goto again;
----------------
Does Doxygen understand escaped quotes?

```
/// "@hello\"@hello"
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116190/new/

https://reviews.llvm.org/D116190

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to