hokein added a comment. In D116919#3236899 <https://reviews.llvm.org/D116919#3236899>, @mstorsjo wrote:
> The relanded version in rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 > <https://reviews.llvm.org/rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3> seems > to be breaking some builds with PCH for me, failing asserts like this: > > clang: ../tools/clang/include/clang/Basic/SourceLocation.h:135: > clang::SourceLocation > clang::SourceLocation::getLocWithOffset(clang::SourceLocation::IntTy) const: > Assertion `((getOffset()+Offset) & MacroIDBit) == 0 && "offset overflow"' > failed. Thanks for raising this. It would be great if you can provide a reproduce case and a more detailed log. A failed PCH build usually indicates something wrong around the ASTReader/ASTWriter code, but I didn't spot out any issue there. At the mean time, I will try to investigate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116919/new/ https://reviews.llvm.org/D116919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
