[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3822 +def DiagnoseAs : InheritableAttr { + let Spellings = [Clang<"diagnose_as">]; + let Args = [ExprArgument<"Function">, aaron.ballman wrote: > george.burgess.iv wrote: > >

[PATCH] D112158: mips: fix search path for multilib o32

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112158/new/ https://reviews.llvm.org/D112158 ___ cfe-commits mailing list cfe-com

[PATCH] D112459: [AArch64] Enablement of Cortex-X2

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112459/new/ https://reviews.llvm.org/D112459 ___ cfe-commits mailing list cfe

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

steakhal added a comment. I'm still worried about regressions. Please split the patch into two by separating the tests into an NFC patch, on which you would apply the behavioral change. That way it would be clear what and why changed. It would also help us to see what previously had defects you

[clang] 284c2eb - [clang][MIPS] Fix search path for Debian multilib O32

Author: YunQiang Su Date: 2021-10-28T10:23:06+03:00 New Revision: 284c2ebc5e057a0fda23257b899260d274e69a27 URL: https://github.com/llvm/llvm-project/commit/284c2ebc5e057a0fda23257b899260d274e69a27 DIFF: https://github.com/llvm/llvm-project/commit/284c2ebc5e057a0fda23257b899260d274e69a27.diff L

[PATCH] D112158: mips: fix search path for multilib o32

This revision was automatically updated to reflect the committed changes. Closed by commit rG284c2ebc5e05: [clang][MIPS] Fix search path for Debian multilib O32 (authored by wzssyqa, committed by atanasyan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity added reviewers: aaron.ballman, xazax.hun. whisperity added a comment. Herald added a subscriber: rnkovacs. Why `readability-`, if the intent is to make users move to a newer API? @xazax.hun I think you did something similar wrt. `empty()`, right? Could you take a look at this? ===

[clang] 897c86d - [clang] [MinGW] Rename the 'Arch' member to 'SubdirName'. NFC.

Author: Martin Storsjö Date: 2021-10-28T10:26:54+03:00 New Revision: 897c86dec5af2780d443edd852aa5911e2650ec6 URL: https://github.com/llvm/llvm-project/commit/897c86dec5af2780d443edd852aa5911e2650ec6 DIFF: https://github.com/llvm/llvm-project/commit/897c86dec5af2780d443edd852aa5911e2650ec6.diff

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG897c86dec5af: [clang] [MinGW] Rename the 'Arch' member to 'SubdirName'. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112387/new

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev updated this revision to Diff 382939. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112663/new/ https://reviews.llvm.org/D112663 Files: clang/include/clang/CodeGen/ModuleBuilder

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

dmgreen added a comment. > The total vector bandwidth includes unrolling so currently having > `VScaleForTuning=1` and `MaxInterleaveFactor=4` implies 512 tvb. If the > target has >128bit vectors then vector loops will likely have more work than > they can handle in parallel but as long as tha

[clang] 2186b01 - [Driver][AArch64]Add driver support for neoverse-512tvb target

Author: Caroline Concatto Date: 2021-10-28T09:08:40+01:00 New Revision: 2186b011e96669b447896c103c10a07dd3aa6203 URL: https://github.com/llvm/llvm-project/commit/2186b011e96669b447896c103c10a07dd3aa6203 DIFF: https://github.com/llvm/llvm-project/commit/2186b011e96669b447896c103c10a07dd3aa6203.d

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2186b011e966: [Driver][AArch64]Add driver support for neoverse-512tvb target (authored by CarolineConcatto). Changed prior to commit: https://revi

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo updated this revision to Diff 382946. mstorsjo marked an inline comment as done. mstorsjo added a comment. Fixed the naming of the new function, using `--target=` in the newly added test lines, fixed a case of missed clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

steakhal added a comment. It looks good to me. But I'm leaving the approval up to the //tidy// folks. BTW shouldn't we use //backticks// in the giant list? Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:45-50 +// The following functions are +// deliberately ex

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offset is 41 + // It sh

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offset is 41 + // It s

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

whisperity added a comment. Okay. I think I am convinced. And removing a bogus automated fix is always a positive change! Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:144 + << (InvocationParm->getFunctionScopeIndex() + 1) + << Re

[clang] 49285f4 - [analyzer] sprintf is a taint propagator not a source

Author: Balazs Benics Date: 2021-10-28T11:03:02+02:00 New Revision: 49285f43e5ed17206235e43c9cd17762d77ed275 URL: https://github.com/llvm/llvm-project/commit/49285f43e5ed17206235e43c9cd17762d77ed275 DIFF: https://github.com/llvm/llvm-project/commit/49285f43e5ed17206235e43c9cd17762d77ed275.diff

[PATCH] D112558: [analyzer] sprintf is a taint propagator not a source

This revision was automatically updated to reflect the committed changes. Closed by commit rG49285f43e5ed: [analyzer] sprintf is a taint propagator not a source (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

ostannard added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:4083 def : t2InstAlias<"csdb$p", (t2HINT 20, pred:$p), 1>; +def : t2InstAlias<"pacbti$p r12,lr,sp", (t2HINT 13, pred:$p), 1>; +def : t2InstAlias<"bti$p", (t2HINT 15, pred:$p), 1>; --

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Headers without include guards

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382955. kbobyrev added a comment. Update the docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev planned changes to this revision. kbobyrev added a comment. Aww, I think this is the wrong place to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 __

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. @rjmccall I assume, I have fixed all your review comments. In case, if I have missed something OR if you think, few more changes are required for the patch, please do let me know so that I will proceed as per the comments/suggestions. I would like to bring this patch to

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

ostannard added a comment. In the commit message: s/armclang/clang/ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1832 // Enable/disable return address signing and indirect branch targets. if (Arg *A = Args.getLastArg(options::OPT_msign_return_address_EQ,

[PATCH] D112422: [clang][ARM] emit PACBTI-M feature defines

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM, I assume that the pre-commit test failure is because the bot hasn't applied the parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382968. kbobyrev added a comment. Put the check into the right place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleane

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382969. kbobyrev added a comment. Remove redundant changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp cl

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382970. kbobyrev added a comment. Revert docs change that is no longer true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/Includ

[clang-tools-extra] 56a8aee - [clangd] NFC: Match function signature in the header and source file

Author: Kirill Bobyrev Date: 2021-10-28T12:13:18+02:00 New Revision: 56a8aee1000149408facdaa1825b043c08cd35ad URL: https://github.com/llvm/llvm-project/commit/56a8aee1000149408facdaa1825b043c08cd35ad DIFF: https://github.com/llvm/llvm-project/commit/56a8aee1000149408facdaa1825b043c08cd35ad.diff

[clang-tools-extra] f9201c7 - [clangd] NFC: Use more idiomatic way of checking for definition

Author: Kirill Bobyrev Date: 2021-10-28T12:25:12+02:00 New Revision: f9201c70ad082a1c1d13b24f1c9cadab8b470e38 URL: https://github.com/llvm/llvm-project/commit/f9201c70ad082a1c1d13b24f1c9cadab8b470e38 DIFF: https://github.com/llvm/llvm-project/commit/f9201c70ad082a1c1d13b24f1c9cadab8b470e38.diff

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

asb added a comment. Is this blocked on anything or is it good to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111062/new/ https://reviews.llvm.org/D111062 ___ cfe-commits mailing list cfe-commits

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. > Why readability-, if the intent is to make users move to a newer API? My line of thinking was: 1. The very similar `readability-container-size-empty` pass is also a readability pass. 2. The main reason why I want people to use `contains` over `count` is because

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:341-343 + `cert-exp42-c `_, `bugprone-suspicious-memory-comparison `_, `cert-fio38-c `_, `misc-non-copyable-objects `_, + `cert-flp37-c `_, `bugprone-suspicious-memory-com

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Ashimaru added a comment. In D34654#3022728 , @alexfh wrote: > Repeating my question from an earlier comment: would a header glob list > (similar to how the format of the `-checks=` flag) be enough for the use > cases folks have? On the one hand glob lis

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offset is 41 + //

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 382982. avogelsgesang added a comment. Fix formatting; remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 Files: clang-tools-extra/clang

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang marked 2 inline comments as done. avogelsgesang added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:341-343 + `cert-exp42-c `_, `bugprone-suspicious-memory-comparison `_, `cert-fio38-c `_, `misc-non-copyable-objects `_, + `

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. I've recently fiddled with the `GlobList` to enable globbing in `NOLINT` expressions, so I have it quite fresh and I think it could easily be re-used here. I'd be happy to implement this feature, should I (can I?) continue on this patch or create a brand new one?

[clang] 4d50803 - [libomptarget] Build DeviceRTL for amdgpu

Author: Jon Chesterfield Date: 2021-10-28T12:34:01+01:00 New Revision: 4d50803ce49ce6b57c4865361c9ba0ad7063b7be URL: https://github.com/llvm/llvm-project/commit/4d50803ce49ce6b57c4865361c9ba0ad7063b7be DIFF: https://github.com/llvm/llvm-project/commit/4d50803ce49ce6b57c4865361c9ba0ad7063b7be.di

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d50803ce49c: [libomptarget] Build DeviceRTL for amdgpu (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D112227?vs=382866&id=382987#toc Repository: rG LLVM Github Mon

[PATCH] D112704: Re-instate -Wweak-template-vtables as a no-op flag

hans created this revision. hans added reviewers: thakis, dblaikie. hans requested review of this revision. Herald added a project: clang. Follow-up to https://github.com/llvm/llvm-project/commit/8c136805242014b6ad9ff1afcac9d7f4a18bec3f to allow a less abrupt migration for users. Repository:

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

frasercrmck added a comment. Herald added a reviewer: luke957. Just nits from me at this stage. Comment at: clang/include/clang/Basic/AttrDocs.td:2150 + let Content = [{ +Users could use the attribute to specify the policy of destination tail and +destination inactive masked-o

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. Landed a slightly modified version of this - code and test changes are included, but the tests are not run by default. I'm hopeful this will help the process of working out why ~10 are failing on CI and passing locally. Repository: rG LLVM Github Monorepo CH

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. On the other hand, switching from Regex to Glob will be quite a breaking change - everyone has `.*` in their config file, which will silently stop to work when switching to Glob and suddenly people won't get their headers linted. What do you think? Repository:

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. For expression with RecordDecl t

[PATCH] D112404: [SPIR-V] Add translator tool

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. This part looks good to me. Just a couple of minor style comments. Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:18 + +void SPIRV::constructTranslateCommand(Compilation &C,

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. There is no need to do anything with this. You can commit as-is. I've done it myself, and it seems like your patch only turns `TRUE` for the cases where it was `UNKNOWN` or `FALSE` previous

[PATCH] D112704: Re-instate -Wweak-template-vtables as a no-op flag

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112704/new/ https://reviews.llvm.org/D112704

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 382999. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Updated comments briefly explaining the root of the existing issue. Thanks, @steakhal and @martong. I appreciate your efforts! CHANGES SINCE LAST ACTION https

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 383001. linjamaki added a comment. Rename SPIRV::Translator's tool names as suggested by bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 Files: clang/lib/D

[clang] 4d2765e - Re-instate -Wweak-template-vtables as a no-op flag

Author: Hans Wennborg Date: 2021-10-28T14:40:59+02:00 New Revision: 4d2765e9949f3113799527db265cd2fa1994a05e URL: https://github.com/llvm/llvm-project/commit/4d2765e9949f3113799527db265cd2fa1994a05e DIFF: https://github.com/llvm/llvm-project/commit/4d2765e9949f3113799527db265cd2fa1994a05e.diff

[PATCH] D112704: Re-instate -Wweak-template-vtables as a no-op flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d2765e9949f: Re-instate -Wweak-template-vtables as a no-op flag (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112704/new/ https://revie

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. Also, the new header filter expresion would need to be: `HeaderFilter: '*/mydir/*' instead of `HeaderFilter: 'mydir'` Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added a comment. In D107339#3093207 , @steakhal wrote: > Next time I would rather have two patches, one of which adds tests to > document the existing behavior and a follow-up changing the behavior. It makes sense. I will take this into ac

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki marked an inline comment as done. linjamaki added a comment. Thanks for the review. Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:18 + +void SPIRV::constructTranslateCommand(Compilation &C, const Tool &T, + const JobAction &JA,

[clang-tools-extra] fbf1745 - [clangd] Escape error message in AddUsing

Author: Kadir Cetinkaya Date: 2021-10-28T14:52:12+02:00 New Revision: fbf1745722a0df95608128561d58744ae7b6f311 URL: https://github.com/llvm/llvm-project/commit/fbf1745722a0df95608128561d58744ae7b6f311 DIFF: https://github.com/llvm/llvm-project/commit/fbf1745722a0df95608128561d58744ae7b6f311.dif

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

asb added a comment. Herald added a reviewer: luke957. This doesn't apply cleanly to current HEAD, could you please rebase? I think the second part of this that you list, where the ISA extension version becomes optional is undesirable. We made the explicit choice of requiring the version string

[PATCH] D112712: [clangd] SelectionTree should prefer lexical declcontext

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is important especially fo

[PATCH] D112712: [clangd] SelectionTree should prefer lexical declcontext

kadircet updated this revision to Diff 383008. kadircet edited the summary of this revision. kadircet added a comment. - Related https://github.com/clangd/clangd/issues/900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112712/new/ https://reviews.

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. Herald added a subscriber: asavonic. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108643/new/ https://reviews.llvm.org/D108643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille added a comment. I second @aaron.ballman there. I compiled the sqlite3.c amalgamation, -O0, with both approach, measuring the number of instructions as gathered by `valgrind --tool=callgrind` - when walking redecls:9001630039 instructions, I changed the implementation

Re: [Lldb-commits] [lldb] aee4925 - Recommit: Compress formatting of array type names (int [4] -> int[4])

On 26/10/2021 23:14, Jim Ingham via lldb-commits wrote: On Oct 26, 2021, at 12:45 PM, David Blaikie wrote: On Tue, Oct 26, 2021 at 12:15 PM Raphael Isemann wrote: Not sure how many LLDB users would (or can) write AST matchers though. And (lldb) type summary add "foo[4]" ... is arguably

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb added a comment. Herald added a reviewer: luke957. From an initial look, I think this is almost ready to land - thank you. One suggestion would be to review the various `Subtarget.hasStdExtZfhmin() || Subtarget.hasStdExtZfh()`. I'd first thought adding a new helper to RISCVSubtarget to be c

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki updated this revision to Diff 383019. linjamaki added a comment. Rebase on updated llvm-spirv tool (D112404 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.llvm.org/D112410 F

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. Attribute bits look good to me, but I'd appreciate if @dblaikie could weigh in on whether he thinks the CodeGen changes are fine. My concern there is around whether the changes to function signatures to accept a `TypeLoc` are reasonable or not.

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

frasercrmck added inline comments. Herald added a reviewer: luke957. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmand.c:97 // CHECK-RV64-LABEL: @test_vmandnot_mm_b8( +// CHECK-RV64-LABEL: @test_vmandn_mm_b8( Was this test manually updated?

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:51 + Result.insert(Definition ? Definition->getLocation() + : RD->getMostRecentDecl()->getLocation()); + return true; i think this migh

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

steakhal added a comment. What's the status on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98726/new/ https://reviews.llvm.org/D98726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, Oct 25, 2021 at 9:06 PM Nico Weber wrote: > Looks like the reason for this check was that > https://github.com/llvm/llvm-project/blob/3b42fc8a07c37e47efae80c931eff7e63103e0e9/clang/include/clang/Basic/Attr.td#L1946 > contains __unsafe_unretained despite it just being a macro here: > http:

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2980 +def warn_unsupported_branch_protection_spec : Warning< + "unsupported branch protection specification '%0'">, InGroup; + Comment at: cla

[PATCH] D112712: [clangd] SelectionTree should prefer lexical declcontext

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:893 const DeclContext &SelectionTree::Node::getDeclContext() const { for (const Node *CurrentNode = this; C

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

t4c1 created this revision. t4c1 added reviewers: jholewinski, bader. Herald added subscribers: asavonic, hiraditya. t4c1 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo ht

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. > everyone has .* in their config file, which will silently stop to work Nevermind this. `.*` treated as a glob will turn into the regex `..*` which is equivalent. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://re

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo added inline comments. Comment at: clang/lib/Driver/ToolChains/MinGW.h:63 + static void FixTripleArch(const Driver &D, llvm::Triple &Triple, +const llvm::opt::ArgList &Args); MaskRay wrote: > Use `functionName` for newer fu

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Thu, Oct 28, 2021 at 9:55 AM Nico Weber wrote: > > On Mon, Oct 25, 2021 at 9:06 PM Nico Weber wrote: >> >> Looks like the reason for this check was that >> https://github.com/llvm/llvm-project/blob/3b42fc8a07c37e47efae80c931eff7e63103e0e9/clang/include/clang/Basic/Attr.td#L1946 >> contains _

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

vhscampos added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:4083 def : t2InstAlias<"csdb$p", (t2HINT 20, pred:$p), 1>; +def : t2InstAlias<"pacbti$p r12,lr,sp", (t2HINT 13, pred:$p), 1>; +def : t2InstAlias<"bti$p", (t2HINT 15, pred:$p), 1>; --

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

luke957 resigned from this revision. luke957 added a comment. So sorry for my bad herald script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 ___ cfe-commits

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

luke957 resigned from this revision. luke957 added a comment. So sorry for my bad herald script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111062/new/ https://reviews.llvm.org/D111062 ___ cfe-commits

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for this! Mostly just bikeshedding on names (allowlist as a verb sounds weird to me), feel free to take or leave the suggestions. LG aside from the formatting nits.

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

luke957 resigned from this revision. luke957 added a comment. So sorry for my bad herald script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 ___ cfe-commits

[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

carlosgalvezp created this revision. carlosgalvezp added a project: clang-tools-extra. Herald added subscribers: libc-commits, arphaman, zzheng, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: libc-project. carlosgalvezp requested review of this revision. Herald added subscribers: cf

[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

carlosgalvezp updated this revision to Diff 383034. carlosgalvezp added a comment. Fixed typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112720/new/ https://reviews.llvm.org/D112720 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. Here's a patch that uses Globs, let me know how you like it! https://reviews.llvm.org/D112720 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654 ___ c

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

thakis added a comment. This doesn't seem to be working very well: thakis@thakis:~/src/llvm-project$ cat test.cc #include #include #include int main() { uint16_t hextets[8]; int chars_scanned; char buf[] = "1234:5678:9abc:def0:1234:5678:9abc:def0"; sscanf(buf,

[clang] bf87294 - Revert "[clang] Fortify warning for scanf calls with field width too big."

Author: Nico Weber Date: 2021-10-28T10:41:18-04:00 New Revision: bf87294cd4fa5781aa2fc0954e117712befedf87 URL: https://github.com/llvm/llvm-project/commit/bf87294cd4fa5781aa2fc0954e117712befedf87 DIFF: https://github.com/llvm/llvm-project/commit/bf87294cd4fa5781aa2fc0954e117712befedf87.diff LO

[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

lebedev.ri added a comment. Not in favor of general directions like this. Does it not break the existing uses (existing `.clang-tidy`'s e.g.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112720/new/ https://reviews.llvm.org/D112720 ___ cfe-c

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. In D111617#3076994 , @rogfer01 wrote: > In D111617#3060377 , @HsiangKai > wrote: > >> Although it reduces the header size, this patch will increase the binary >> size of clang. > > Opt

[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

carlosgalvezp updated this revision to Diff 383036. carlosgalvezp added a comment. Fixed formatting of release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112720/new/ https://reviews.llvm.org/D112720 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-

[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

carlosgalvezp added a comment. In D112720#3093636 , @lebedev.ri wrote: > Not in favor of general directions like this. > Does it not break the existing uses (existing `.clang-tidy`'s e.g.) Yep, it's a breaking change. The purpose of this patch is mostly

[PATCH] D112722: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative

courbet created this revision. courbet added reviewers: flx, ymandel, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. courbet requested review of this revision. Herald added a project: clang-tools-extra. We're missing all cases where the return value is a type alias. Unfortunat

[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

carlosgalvezp added a comment. Just to clarify, this patch is the solution proposed by @alexfh here: https://reviews.llvm.org/D34654#3022728 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112720/new/ https://reviews.llvm.org/D112720 ___ cfe-c

[PATCH] D112722: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative

flx accepted this revision. flx added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112722/new/ https://reviews.llvm.org/D112722 __

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 383040. achieveartificialintelligence added a comment. Address @asb 's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/te

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

vhscampos added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135 StringRef &Err) const { - llvm::AArch64::ParsedBranchProtection PBP; - if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err)) + llvm::

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

manojgupta added a comment. @kcc do you have any concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112091/new/ https://reviews.llvm.org/D112091 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] 6f9c251 - [OpenMP] Initial parsing/sema for the 'omp loop' construct

Author: Mike Rice Date: 2021-10-28T08:26:43-07:00 New Revision: 6f9c25167d16acff3ff8e4f54a8c14a2a175fc59 URL: https://github.com/llvm/llvm-project/commit/6f9c25167d16acff3ff8e4f54a8c14a2a175fc59 DIFF: https://github.com/llvm/llvm-project/commit/6f9c25167d16acff3ff8e4f54a8c14a2a175fc59.diff LOG

  1   2   3   >