frasercrmck added a comment.
Herald added a reviewer: luke957.
Just nits from me at this stage.
================
Comment at: clang/include/clang/Basic/AttrDocs.td:2150
+ let Content = [{
+Users could use the attribute to specify the policy of destination tail and
+destination inactive masked-off elements in the vector operations. There are
----------------
Nit, but the use of `could` seems out of place in this documentation. Is `can`
or `may` perhaps more common?
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:895
ListSeparator LS;
for (unsigned i = 0; i < InputTypes.size(); ++i)
OS << LS << InputTypes[i]->getTypeStr();
----------------
This variable `i` shadowing the outer loop's induction variable is a little
odd. Perhaps the outer loop could use a range-based for?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
