aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2980
+def warn_unsupported_branch_protection_spec : Warning<
+ "unsupported branch protection specification '%0'">,
InGroup<BranchProtection>;
+
----------------
================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef &Err) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+ llvm::ARM::ParsedBranchProtection PBP;
+ if (!llvm::ARM::parseBranchProtection(Spec, PBP, Err))
return false;
----------------
This change surprises me. Why should AArch64TargetInfo prefer calling into ARM
instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
